From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68563C77B61 for ; Thu, 13 Apr 2023 16:12:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229647AbjDMQM3 (ORCPT ); Thu, 13 Apr 2023 12:12:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbjDMQM2 (ORCPT ); Thu, 13 Apr 2023 12:12:28 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B51AE6B; Thu, 13 Apr 2023 09:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681402347; x=1712938347; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=u3In46KoV7jrlPQBLlMpa2pfQ3+DhOK7gwXj89ZvQh0=; b=fz34nK6Ha1m34z4HWQpV73uEcSYigx5Ggbf5mM9iUb+pp20bNoK2Uhpq IXMRepbftMliBM6JMDB0u/OglxpUr+QSueSrmQP5wTWTtgj+g4ybrpoov aqNcexjFyqIwiuciwx/pfeaayxtWkWv5PtoSrzVVvdER+qLcT9VBqWiI9 IWCcl0uDby6PEiUETWwj17X0y2+1dTwUIqnCXtdAe8TnTY7FJ+lEzG6Z4 ElCJ/mkpn60djxvr6CgKjlolZyPtZuF8WZOCoTgPX+jfKgDVRthAtvviC KWhLdJOD3uQwbFfgLgnCfMkyhtARHzgOUc5XzW0G/HjSGGJI73tVCFFeh A==; X-IronPort-AV: E=McAfee;i="6600,9927,10679"; a="323853012" X-IronPort-AV: E=Sophos;i="5.99,194,1677571200"; d="scan'208";a="323853012" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2023 09:12:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10679"; a="758753815" X-IronPort-AV: E=Sophos;i="5.99,194,1677571200"; d="scan'208";a="758753815" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 13 Apr 2023 09:12:16 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pmzYT-00GchC-2q; Thu, 13 Apr 2023 19:12:13 +0300 Date: Thu, 13 Apr 2023 19:12:13 +0300 From: Andy Shevchenko To: Ryan Chen Cc: Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Rob Herring , Krzysztof Kozlowski , Andrew Jeffery , Philipp Zabel , Wolfram Sang , linux-i2c@vger.kernel.org, Florian Fainelli , Jean Delvare , William Zhang , Tyrone Ting , Tharun Kumar P , Conor Dooley , Phil Edworthy , openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 2/2 RESEND] i2c: aspeed: support ast2600 i2c new register mode driver Message-ID: References: <20230413075327.1397306-1-ryan_chen@aspeedtech.com> <20230413075327.1397306-3-ryan_chen@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Apr 13, 2023 at 07:10:56PM +0300, Andy Shevchenko wrote: > On Thu, Apr 13, 2023 at 03:53:27PM +0800, Ryan Chen wrote: > > Add i2c new register mode driver to support AST2600 i2c > > new register mode. AST2600 i2c controller have legacy and > > new register mode. The new register mode have global register > > support 4 base clock for scl clock selection, and new clock > > divider mode. The i2c new register mode have separate register > > set to control i2c master and slave. > > There is already i2c-aspeed.c in the kernel. Can you elaborate what's wrong > with the extending existing driver? (It seems to me that so called "legacy" > mode is exactly what is being serviced by that driver.) Okay, it seems the answer is in cover letter. -- With Best Regards, Andy Shevchenko