From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE02C77B73 for ; Thu, 20 Apr 2023 19:12:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229523AbjDTTMc (ORCPT ); Thu, 20 Apr 2023 15:12:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229625AbjDTTMc (ORCPT ); Thu, 20 Apr 2023 15:12:32 -0400 Received: from the.earth.li (the.earth.li [IPv6:2a00:1098:86:4d:c0ff:ee:15:900d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 234FF26B2; Thu, 20 Apr 2023 12:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=earth.li; s=the; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2+GOjpE5zP3l/Yj2zge3EDzVuoeZQl9/VD1vHaJbzx8=; b=onvz42aaty3fwxg9Ca5yT7zvbj ApCgI1YVT0f5FoEGBkWJxsWjY/I3p/YK6pev3OKfqIv4sdqdqnJdP8kYC0PMw7CZDVL50uMQx2gZU +DJWKf8jiwN9ZA9UTStq6aaGgInOXUrnbL31TGAs4xLkUAqBnOVgc8LQt5mrFwM++xLlu4Ejohbai Ra1YNhokSow9BBIo23A3W6ZKGDhQ649mvu1I4rYyvmgWLeL+0LO0aEiihsvfGJy+E+SsCuNTSlRCl wv4vbUjMxyYOHpEfWC3dv5a6PSwas1pRY6AyjBXe8g5DidDpAS+BLa0WswtgIvgQlWQGzsHasGfoL S6dHsp7Q==; Received: from noodles by the.earth.li with local (Exim 4.94.2) (envelope-from ) id 1ppZhb-002Tg3-Ac; Thu, 20 Apr 2023 20:12:19 +0100 Date: Thu, 20 Apr 2023 20:12:19 +0100 From: Jonathan McDowell To: Andre Przywara , Saravana Kannan , Greg Kroah-Hartman Cc: Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ARM: dts: sun5i: chip: Enable bluetooth Message-ID: References: <20230416012421.255bfd19@slackpad.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230416012421.255bfd19@slackpad.lan> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Apr 16, 2023 at 01:24:21AM +0100, Andre Przywara wrote: > On Sat, 15 Apr 2023 18:46:03 +0100 > Jonathan McDowell wrote: > > > The C.H.I.P has an rtl8723bs device with the bluetooth interface hooked > > up on UART3. Support for this didn't exist in mainline when the DTS was > > initially added, but it does now, so enable it. > > > > Signed-off-by: Jonathan McDowell > > --- > > arch/arm/boot/dts/sun5i-r8-chip.dts | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun5i-r8-chip.dts b/arch/arm/boot/dts/sun5i-r8-chip.dts > > index fd37bd1f3920..4d72a181d8aa 100644 > > --- a/arch/arm/boot/dts/sun5i-r8-chip.dts > > +++ b/arch/arm/boot/dts/sun5i-r8-chip.dts > > @@ -255,6 +255,10 @@ &uart3 { > > pinctrl-0 = <&uart3_pg_pins>, > > <&uart3_cts_rts_pg_pins>; > > status = "okay"; > > + > > + bluetooth { > > + compatible = "realtek,rtl8723bs-bt"; > > + } > > As the kernel test robot already pointed out, there is a semicolon > missing here. > Otherwise looks good (dt-validate passes), but don't know if there are > any wakeup GPIOs connected (can't seem to find a schematic?). So there are wakeups, but if I add: device-wake-gpios = <&axp_gpio 3 GPIO_ACTIVE_LOW>; host-wake-gpios = <&pio 1 3 GPIO_ACTIVE_HIGH>; /* PB3 */ then some odd sort of dependency issue happens where the serial port load is deferred waiting for the GPIO to appear, and then the device doesn't work. Error in dmesg is: serial serial0-0: deferred probe pending on 6.3-rc and on 6.1 I get: dw-apb-uart 1c28c00.serial: Failed to create device link (0x180) with axp20x-gpio I'm not clear why it's trying to link the serial port to the GPIO; it seems that it should be the bluetooth device that depends on both the UART and the GPIO, and that the GPIO is actually optional so shouldn't hold up loading, but I can't see how that should be represented. Adding Greg + Saravana in the hope they can tell me what I've done wrong here. The LED driver using a different GPIO line on the axp209 works fine, so the device is definitely loaded and working ok. > > }; > > > > &usb_otg { > J. -- Sex, truth and jellibabies. | .''`. Debian GNU/Linux Developer | : :' : Happy to accept PGP signed | `. `' or encrypted mail - RSA | `- key on the keyservers.