From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiri Valek - 2N <jiriv@axis.com>
Cc: krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH 2/2] Input: cap11xx - add advanced sensitivity settings
Date: Thu, 11 May 2023 16:57:49 -0700 [thread overview]
Message-ID: <ZF2A/STY66sqoOLX@google.com> (raw)
In-Reply-To: <20230414233815.4004526-3-jiriv@axis.com>
Hi Jiri,
On Sat, Apr 15, 2023 at 01:38:15AM +0200, Jiri Valek - 2N wrote:
> @@ -474,7 +645,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
> if (error)
> return error;
>
> - irq = irq_of_parse_and_map(node, 0);
> + irq = irq_of_parse_and_map(dev->of_node, 0);
Do you know if this is actually needed or we can rely on I2C core to
figure out the interrupt for us?
Also, could I ask you to move the driver from of_property_*() to
device_property_*() API?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2023-05-11 23:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 23:38 [PATCH 0/2] Input: cap11xx add advanced sensitivity settings Jiri Valek - 2N
2023-04-14 23:38 ` [PATCH 1/2] dt-bindings: input: microchip,cap11xx: " Jiri Valek - 2N
2023-04-15 9:10 ` Krzysztof Kozlowski
2023-04-17 13:10 ` Rob Herring
2023-04-14 23:38 ` [PATCH 2/2] Input: cap11xx - " Jiri Valek - 2N
2023-05-11 23:57 ` Dmitry Torokhov [this message]
2023-06-13 13:35 ` Jiri Valek - 2N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZF2A/STY66sqoOLX@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jiriv@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).