From: Bjorn Helgaas <helgaas@kernel.org>
To: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, krzysztof.kozlowski@linaro.org,
bhelgaas@google.com, michals@xilinx.com, robh+dt@kernel.org,
nagaradhesh.yeleswarapu@amd.com, bharat.kumar.gogada@amd.com,
lorenzo.pieralisi@arm.com
Subject: Re: [PATCH v2 3/3] PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver
Date: Fri, 12 May 2023 14:32:40 -0500 [thread overview]
Message-ID: <ZF6UWBd0x9LxAhoJ@bhelgaas> (raw)
In-Reply-To: <20230512062725.1208385-4-thippeswamy.havalige@amd.com>
On Fri, May 12, 2023 at 11:57:25AM +0530, Thippeswamy Havalige wrote:
> Add support for Xilinx XDMA Soft IP core as Root Port.
> ...
> +#include <linux/of_pci.h>
> +#include <linux/irqchip/chained_irq.h>
The trend seems to be to alphabetize the system includes above.
> +#include "pcie-xilinx-common.h"
> +
> +#include "../pci.h"
Put the pcie-xilinx-common.h include here, as you did for
pcie-xilinx-cpm.c:
#include <linux/irqchip/chained_irq.h>
#include "../pci.h"
#include "pcie-xilinx-common.h"
pcie-xilinx.c has a very similar list of register definitions, which
makes me wonder why it can't share pcie-xilinx-common.h as well.
Obviously it would take a bit of rework since it uses BIT(x) instead
of just "x". But you hide the "BIT()" inside IMR(), which is arguably
slightly obscure since the #define value is not a register mask:
> +#define IMR(x) BIT(XILINX_PCIE_INTR_ ##x)
I don't really care either way, but it seems like a possibly needless
difference.
Bjorn
next prev parent reply other threads:[~2023-05-12 19:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 6:27 [PATCH v2 0/3] Add support for Xilinx XDMA Soft IP as Root Port Thippeswamy Havalige
2023-05-12 6:27 ` [PATCH v2 1/3] Move error interrupt bits to a common header Thippeswamy Havalige
2023-05-12 6:45 ` Michal Simek
2023-05-12 19:23 ` Bjorn Helgaas
2023-05-12 6:27 ` [PATCH v2 2/3] dt-bindings: PCI: xilinx-xdma: Add YAML schemas for Xilinx XDMA PCIe Root Port Bridge Thippeswamy Havalige
2023-05-12 6:50 ` Michal Simek
2023-05-12 11:26 ` Krzysztof Kozlowski
2023-05-12 6:27 ` [PATCH v2 3/3] PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver Thippeswamy Havalige
2023-05-12 7:04 ` Michal Simek
2023-05-12 17:43 ` Bjorn Helgaas
2023-05-18 4:55 ` Havalige, Thippeswamy
2023-05-12 19:32 ` Bjorn Helgaas [this message]
2023-05-18 4:58 ` Havalige, Thippeswamy
2023-05-16 17:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZF6UWBd0x9LxAhoJ@bhelgaas \
--to=helgaas@kernel.org \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=michals@xilinx.com \
--cc=nagaradhesh.yeleswarapu@amd.com \
--cc=robh+dt@kernel.org \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox