From: Mark Brown <broonie@kernel.org>
To: Yinbo Zhu <zhuyinbo@loongson.cn>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Jianmin Lv <lvjianmin@loongson.cn>,
wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v9 2/2] spi: loongson: add bus driver for the loongson spi controller
Date: Mon, 8 May 2023 22:20:04 +0900 [thread overview]
Message-ID: <ZFj3BEHCDc/XLBZB@finisterre.sirena.org.uk> (raw)
In-Reply-To: <20230426071045.20753-3-zhuyinbo@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]
On Wed, Apr 26, 2023 at 03:10:45PM +0800, Yinbo Zhu wrote:
> This bus driver supports the Loongson spi hardware controller in the
> Loongson platforms and supports to use DTS and PCI framework to
> register spi device resources.
This breaks an x86 allmodconfig build:
/build/stage/linux/drivers/spi/spi-loongson-core.c: In function ‘loongson_spi_init_master’:
/build/stage/linux/drivers/spi/spi-loongson-core.c:222:31: error: implicit declaration of function ‘of_node_get’ [-Werror=implicit-function-declaration]
222 | master->dev.of_node = of_node_get(dev->of_node);
| ^~~~~~~~~~~
/build/stage/linux/drivers/spi/spi-loongson-core.c:222:29: error: assignment to ‘struct device_node *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
222 | master->dev.of_node = of_node_get(dev->of_node);
| ^
/build/stage/linux/drivers/spi/spi-loongson-core.c:242:13: error: implicit declaration of function ‘of_get_property’ [-Werror=implicit-function-declaration]
242 | if (of_get_property(dev->of_node, "spi-nocs", NULL))
| ^~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-05-08 13:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 7:10 [PATCH v9 0/2] spi: loongson: add bus driver for the loongson spi Yinbo Zhu
2023-04-26 7:10 ` [PATCH v9 1/2] dt-bindings: spi: add " Yinbo Zhu
2023-04-26 7:10 ` [PATCH v9 2/2] spi: loongson: add bus driver for the loongson spi controller Yinbo Zhu
2023-05-08 13:20 ` Mark Brown [this message]
2023-05-09 1:26 ` zhuyinbo
2023-05-08 15:04 ` andy.shevchenko
2023-05-09 4:39 ` Mark Brown
2023-05-10 7:03 ` Andy Shevchenko
2023-05-12 8:12 ` zhuyinbo
2023-05-12 9:40 ` Andy Shevchenko
2023-05-13 6:16 ` zhuyinbo
2023-05-11 7:18 ` zhuyinbo
2023-05-15 8:14 ` zhuyinbo
2023-05-15 9:15 ` andy.shevchenko
2023-05-15 12:01 ` zhuyinbo
2023-05-15 13:54 ` Andy Shevchenko
2023-05-16 0:50 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFj3BEHCDc/XLBZB@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox