From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <devicetree-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1810FC77B7C
	for <linux-devicetree@archiver.kernel.org>; Wed, 10 May 2023 17:56:28 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235824AbjEJR40 (ORCPT
        <rfc822;linux-devicetree@archiver.kernel.org>);
        Wed, 10 May 2023 13:56:26 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45964 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229773AbjEJR4Z (ORCPT
        <rfc822;devicetree@vger.kernel.org>); Wed, 10 May 2023 13:56:25 -0400
Received: from smtp.dudau.co.uk (dliviu.plus.com [80.229.23.120])
        by lindbergh.monkeyblade.net (Postfix) with ESMTP id 27E7D4200;
        Wed, 10 May 2023 10:56:24 -0700 (PDT)
Received: from mail.dudau.co.uk (bart.dudau.co.uk [192.168.14.2])
        by smtp.dudau.co.uk (Postfix) with SMTP id BC40E41D13BF;
        Wed, 10 May 2023 18:56:21 +0100 (BST)
Received: by mail.dudau.co.uk (sSMTP sendmail emulation); Wed, 10 May 2023 18:56:21 +0100
Date:   Wed, 10 May 2023 18:56:21 +0100
From:   Liviu Dudau <liviu@dudau.co.uk>
To:     =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Paul Burton <paulburton@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Sergio Paracuellos <sergio.paracuellos@gmail.com>,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH] mips: dts: ralink: Clarify usage of MT7621 ethernet phy
 arguments
Message-ID: <ZFvaxVwVOnzVofrU@bart.dudau.co.uk>
References: <20230509200032.308934-1-liviu@dudau.co.uk>
 <a5fdd37e-6f42-2f37-357f-ad5bb082fa7d@arinc9.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a5fdd37e-6f42-2f37-357f-ad5bb082fa7d@arinc9.com>
Precedence: bulk
List-ID: <devicetree.vger.kernel.org>
X-Mailing-List: devicetree@vger.kernel.org

Hi Arınç,

On Wed, May 10, 2023 at 02:59:44PM +0200, Arınç ÜNAL wrote:
> On 9.05.2023 22:00, Liviu Dudau wrote:
> > The device tree uses numbers as arguments to the phys property that are
> > confusing for newcomers. Define names for the values and use them in the
> > device tree.
> > 
> > Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
> 
> You should document this on
> Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml instead of
> doing this. Under the phys property, add 'description:' and explain this.

There is already some sort of explanation under
Documentation/devicetree/bindings/phy/mediatek,mt7621-pci-phy.yaml, so I'm
not sure what I'm improving by adding new text in the /pci/ section.

Maybe I haven't explained properly in the commit message, this is meant to
give a name to the 1 and 0 values used in the device tree, not to clarify
any perceived missing documentation.

> 
> Arınç

Best regards,
Liviu

--
Everyone who uses computers frequently has had, from time to time,
a mad desire to attack the precocious abacus with an axe.
       	   	      	     	  -- John D. Clark, Ignition!