From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E546C7EE22 for ; Wed, 10 May 2023 21:12:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236570AbjEJVMN (ORCPT ); Wed, 10 May 2023 17:12:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjEJVMM (ORCPT ); Wed, 10 May 2023 17:12:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BEBDE53; Wed, 10 May 2023 14:12:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C74356358F; Wed, 10 May 2023 21:12:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1710C433EF; Wed, 10 May 2023 21:12:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683753130; bh=HizRoK5fj7AB/DRhebcy+ie0+Ty6tdVrnKdXSa4wsjM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=pGqgAfOa2dGWGZoJHS1lFroIibP2K6fxBIvBd+qM9kAnQR7Z9RJk7NSrK09c1DZcD 5TrjP2IkYOVMmv/OOAn/Cac2i9uWDMaR2iBqvK4EetkMjQ4MatOjfWnMBLKuFRAr9d tynbPwoBMRFMWws0nMSOOb/lvhedrRQGqMBvbFSe/xg9+cS0rm6nvBv7pQfsnYAFFS Bv5lKlRaySTU+4VIYHETHrP78FwDcbw6l7WbpurBfnskH66piJA/ydlS0UkoNB+3C7 hhXNDzmPsxQBgGx+gcouNL6HOSfR4IvMVFGq6XoCIRdXnruDM9l48vr5aagBOlxwXZ +wMEwQU7sChQQ== Date: Wed, 10 May 2023 16:12:08 -0500 From: Bjorn Helgaas To: Krzysztof Kozlowski Cc: Christian Gmeiner , Rob Herring , Dominic Rath , krzysztof.kozlowski+dt@linaro.org, tjoseph@cadence.com, bhelgaas@google.com, lpieralisi@kernel.org, nm@ti.com, vigneshr@ti.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, bahle@ibv-augsburg.de Subject: Re: [PATCH v2 1/3] dt-bindings: phy: cadence-torrent: Add latency properties Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a36a4ad-6d46-4e4e-1724-ed27513a72ef@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, May 10, 2023 at 09:08:39AM +0200, Krzysztof Kozlowski wrote: > On 09/05/2023 23:57, Bjorn Helgaas wrote: > > On Tue, May 09, 2023 at 05:31:19PM +0200, Christian Gmeiner wrote: > >>> On Thu, Apr 27, 2023 at 07:50:30AM +0200, Dominic Rath wrote: > >>>> From: Alexander Bahle > >>>> > >>>> Add "tx-phy-latency-ps" and "rx-phy-latency-ps" DT bindings for > >>>> setting the PCIe PHY latencies. > >>>> The properties expect a list of uint32 PHY latencies in picoseconds for > >>>> every supported speed starting at PCIe Gen1, e.g.: > >>>> > >>>> tx-phy-latency-ps = <100000 200000>; /* Gen1: 100ns, Gen2: 200ns */ > >>>> rx-phy-latency-ps = <150000 250000>; /* Gen1: 150ns, Gen2: 250ns */ > >>> > >>> Are these things that could/should be described in a more generic > >>> place? They don't look necessarily Cadence-specific. > >> > >> As there is currently no generic binding, would you like to see a new > >> yaml binding > >> added (Documentation/devicetree/bindings/phy/phy.yaml) that contains just the > >> two phy properties? > > > > The whole thing is more a question for Rob. > > For which you might wait a bit currently. > > If the question is only about location of the properties - device schema > or something generic - then for now you can keep it here. Moving to > generic schema is always easy later. > > Better to have proper names for properties. Good point. The current names seem fine to me since the names themselves aren't Cadence-specific. Bjorn