From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4F32C7EE24 for ; Thu, 11 May 2023 09:07:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232224AbjEKJHe (ORCPT ); Thu, 11 May 2023 05:07:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233814AbjEKJHd (ORCPT ); Thu, 11 May 2023 05:07:33 -0400 Received: from smtp.dudau.co.uk (dliviu.plus.com [80.229.23.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CCD7555A2; Thu, 11 May 2023 02:07:29 -0700 (PDT) Received: from mail.dudau.co.uk (bart.dudau.co.uk [192.168.14.2]) by smtp.dudau.co.uk (Postfix) with SMTP id D614A41D13BF; Thu, 11 May 2023 10:07:27 +0100 (BST) Received: by mail.dudau.co.uk (sSMTP sendmail emulation); Thu, 11 May 2023 10:07:27 +0100 Date: Thu, 11 May 2023 10:07:27 +0100 From: Liviu Dudau To: Sergio Paracuellos Cc: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Thomas Bogendoerfer , Paul Burton , Rob Herring , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] mips: dts: ralink: Clarify usage of MT7621 ethernet phy arguments Message-ID: References: <20230509200032.308934-1-liviu@dudau.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, May 11, 2023 at 06:13:41AM +0200, Sergio Paracuellos wrote: > Hi Liviu, Hi Sergio, > > On Wed, May 10, 2023 at 7:56 PM Liviu Dudau wrote: > > > > Hi Arınç, > > > > On Wed, May 10, 2023 at 02:59:44PM +0200, Arınç ÜNAL wrote: > > > On 9.05.2023 22:00, Liviu Dudau wrote: > > > > The device tree uses numbers as arguments to the phys property that are > > > > confusing for newcomers. Define names for the values and use them in the > > > > device tree. > > > > > > > > Signed-off-by: Liviu Dudau > > > > > > You should document this on > > > instead of > > > doing this. Under the phys property, add 'description:' and explain this. > > > > There is already some sort of explanation under > > Documentation/devicetree/bindings/phy/mediatek,mt7621-pci-phy.yaml, so I'm > > not sure what I'm improving by adding new text in the /pci/ section. > > > > Maybe I haven't explained properly in the commit message, this is meant to > > give a name to the 1 and 0 values used in the device tree, not to clarify > > any perceived missing documentation. > > What is that useful for if the bindings are well documented? The > description in the > 'Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml' file > for the '#phy-cells' > property is already telling you what that cell is used for. It is > obvious that zero means not dual ported and one means dual ported. > So for me there is no need to add anything extra but in case you want > to clarify anything you should modify binding documentation not the > device tree file at all. Understood. Then please feel free to ignore this patch. Best regards, Liviu > > Thanks, > Sergio Paracuellos > > > > > > > > Arınç > > > > Best regards, > > Liviu -- Everyone who uses computers frequently has had, from time to time, a mad desire to attack the precocious abacus with an axe. -- John D. Clark, Ignition!