From: andy.shevchenko@gmail.com
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jirislaby@kernel.org, jringle@gridpoint.com,
tomasz.mon@camlingroup.com, l.perczak@camlintechnologies.com,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH v3 00/11] serial: sc16is7xx: fix GPIO regression and rs485 improvements
Date: Thu, 25 May 2023 13:27:52 +0300 [thread overview]
Message-ID: <ZG84KCeMIINFVTMh@surfacebook> (raw)
In-Reply-To: <20230525040324.3773741-1-hugo@hugovil.com>
Thu, May 25, 2023 at 12:03:13AM -0400, Hugo Villeneuve kirjoitti:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> Hello,
> this patch series mainly fixes a GPIO regression and improve RS485 flags and properties
> detection from DT.
>
> It now also includes various small fixes and improvements that were previously
> sent as separate patches, but that made testing everything difficult.
> Patches 1 and 2 are simple comments fix/improvements.
Usually we put fixes at the beginning of the series, but these patches are
missing Fixed tag. Are they really fixes or can be simply moved to the end of
the series?
> Patch 3 fixes an issue when debugging IOcontrol register. After testing the GPIO
> regression patches (patches 6 and 7, tests done by Lech Perczak), it appers that
> this patch is also necessary for having the correct IOcontrol register values.
>
> Patch 4 introduces a delay after a reset operation to respect datasheet
> timing recommandations.
>
> Patch 5 fixes an issue with init of first port during probing. This commit
> brings some questions and I appreciate if people from the serial subsystem could
> comment on my proposed solution.
>
> Patch 6 fixes a bug with the output value when first setting the GPIO direction.
>
> Patch 7, 8 and 9 fix a GPIO regression by (re)allowing to choose GPIO function for
> GPIO pins shared with modem status lines.
>
> Patch 10 allows to read common rs485 device-tree flags and properties.
>
> Patch 11 add a custom dump function as relying on regmal debugfs is not really
> practical for this driver.
>
> I have tested the changes on a custom board with two SC16IS752 DUART using a
> Variscite IMX8MN NANO SOM.
Other comments are per individual emails.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-05-25 10:28 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 4:03 [PATCH v3 00/11] serial: sc16is7xx: fix GPIO regression and rs485 improvements Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 01/11] serial: sc16is7xx: fix syntax error in comments Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 02/11] serial: sc16is7xx: improve comments about variants Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 03/11] serial: sc16is7xx: mark IOCONTROL register as volatile Hugo Villeneuve
2023-05-25 11:02 ` Ilpo Järvinen
2023-05-25 13:45 ` Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 04/11] serial: sc16is7xx: add post reset delay Hugo Villeneuve
2023-05-25 10:30 ` andy.shevchenko
2023-05-25 13:18 ` Hugo Villeneuve
2023-05-25 11:05 ` Ilpo Järvinen
2023-05-25 14:05 ` Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 05/11] serial: sc16is7xx: fix broken port 0 uart init Hugo Villeneuve
2023-05-25 11:20 ` Ilpo Järvinen
2023-05-25 15:10 ` Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 06/11] serial: sc16is7xx: fix bug when first setting GPIO direction Hugo Villeneuve
2023-05-25 11:10 ` andy.shevchenko
2023-05-25 14:24 ` Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 07/11] dt-bindings: sc16is7xx: Add property to change GPIO function Hugo Villeneuve
2023-05-25 11:11 ` andy.shevchenko
2023-05-25 14:34 ` Hugo Villeneuve
2023-05-25 15:15 ` Conor Dooley
2023-05-26 18:28 ` andy.shevchenko
2023-05-25 4:03 ` [PATCH v3 08/11] serial: sc16is7xx: fix regression with GPIO configuration Hugo Villeneuve
2023-05-25 11:19 ` andy.shevchenko
2023-05-25 15:02 ` Hugo Villeneuve
2023-05-26 18:34 ` andy.shevchenko
2023-05-25 12:03 ` Ilpo Järvinen
2023-05-25 15:19 ` Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 09/11] serial: sc16is7xx: add I/O register translation offset Hugo Villeneuve
2023-05-25 11:22 ` andy.shevchenko
2023-05-25 15:31 ` Hugo Villeneuve
2023-05-25 17:20 ` Hugo Villeneuve
2023-05-26 18:36 ` andy.shevchenko
2023-05-25 12:10 ` Ilpo Järvinen
2023-05-25 15:25 ` Hugo Villeneuve
2023-05-25 4:03 ` [PATCH v3 10/11] serial: sc16is7xx: add call to get rs485 DT flags and properties Hugo Villeneuve
2023-05-25 12:17 ` Ilpo Järvinen
2023-05-25 4:03 ` [PATCH v3 11/11] serial: sc16is7xx: add dump registers function Hugo Villeneuve
2023-05-25 11:26 ` andy.shevchenko
2023-05-25 19:49 ` Hugo Villeneuve
2023-05-26 18:38 ` andy.shevchenko
2023-05-28 11:56 ` Greg KH
2023-05-25 10:27 ` andy.shevchenko [this message]
2023-05-25 13:26 ` [PATCH v3 00/11] serial: sc16is7xx: fix GPIO regression and rs485 improvements Hugo Villeneuve
2023-05-25 13:37 ` Andy Shevchenko
2023-05-25 13:39 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG84KCeMIINFVTMh@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=jringle@gridpoint.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.perczak@camlintechnologies.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).