Re: [PATCH v9 2/2] spi: loongson: add bus driver for the loongson spi controller

zhuyinbo
2023-05-09T01:26:29Z

在 2023/5/8 下午9:20, Mark Brown 写道:
> On Wed, Apr 26, 2023 at 03:10:45PM +0800, Yinbo Zhu wrote:
>> This bus driver supports the Loongson spi hardware controller in the
>> Loongson platforms and supports to use DTS and PCI framework to
>> register spi device resources.
>
> This breaks an x86 allmodconfig build:
>
> /build/stage/linux/drivers/spi/spi-loongson-core.c: In function ‘loongson_spi_init_master’:
> /build/stage/linux/drivers/spi/spi-loongson-core.c:222:31: error: implicit declaration of function ‘of_node_get’ [-Werror=implicit-function-declaration]
> 222 | master->dev.of_node = of_node_get(dev->of_node);
> | ^~~~~~~~~~~
> /build/stage/linux/drivers/spi/spi-loongson-core.c:222:29: error: assignment to ‘struct device_node *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
> 222 | master->dev.of_node = of_node_get(dev->of_node);
> | ^
> /build/stage/linux/drivers/spi/spi-loongson-core.c:242:13: error: implicit declaration of function ‘of_get_property’ [-Werror=implicit-function-declaration]
> 242 | if (of_get_property(dev->of_node, "spi-nocs", NULL))
> | ^~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors

These errors was due to the function of_node_get and of_get_property
loss a declaration and I will add "#include <linux/of.h>" in
spi-loongson-core.c to fix it.

Thanks.
>