From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3450CC77B75 for ; Mon, 15 May 2023 11:58:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241696AbjEOL6H (ORCPT ); Mon, 15 May 2023 07:58:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241705AbjEOL5s (ORCPT ); Mon, 15 May 2023 07:57:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A77A40E3; Mon, 15 May 2023 04:55:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9C729614A2; Mon, 15 May 2023 11:54:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04E4CC433D2; Mon, 15 May 2023 11:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684151699; bh=kh1kY/KhPkOpkYVPUCfFY3w8ObJ/nJNgBlNa4gelO4c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hzgQWD7bVW5NZ64o0Hk29zdp3hNcGMVcH3Xa3KVWNAvNhDg0DgjqbeV7p882MNW5/ i8bJq5rZmUCotx1A6xgE1J4bajAIFLQEw0lXLOHxFz5G/28admhEttNQqoSRfka7R8 41AgS7KCXXJTWWC0hQmndSenHynLhjQ/IA29MHJ3IrTzvwB2uQQYs7GZ2nxSysEX3o DQ/3CSjqhMxtRobrbSZ5Z1zfsKjtVFHta++1YYxoAQVNQ9gV3qWzUc+gcro6wDLBp9 9Inf0rxksfRRcSP/Go3YsGbLmDGnsWbURx+ddNo4WY9bhlVmMlf3wLOildNBOPTUj1 PLGDB7MN12mVQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pyWn2-00040G-FC; Mon, 15 May 2023 13:54:56 +0200 Date: Mon, 15 May 2023 13:54:56 +0200 From: Johan Hovold To: Bjorn Andersson Cc: Konrad Dybcio , Bjorn Andersson , Andy Gross , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Flush RSC sleep & wake votes Message-ID: References: <20230512150425.3171122-1-quic_bjorande@quicinc.com> <20230515023828.jqrrqkit5ygovimp@ripper> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515023828.jqrrqkit5ygovimp@ripper> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, May 14, 2023 at 07:38:28PM -0700, Bjorn Andersson wrote: > On Sat, May 13, 2023 at 11:09:07AM +0200, Konrad Dybcio wrote: > > > > > > On 12.05.2023 17:04, Bjorn Andersson wrote: > > > The rpmh driver will cache sleep and wake votes until the cluster > > > power-domain is about to enter idle, to avoid unnecessary writes. So > > > associate the apps_rsc with the cluster pd, so that it can be notified > > > about this event. > > > > > > Without this, only AMC votes are being commited. > > Ouch. > > > > Should we make this required: in bindings and add it to all > > platforms? > > > > I though this was an optimization and in the absence of this callback > the driver would just write out wake and sleep sets as well. But per the > current implementation (and perhaps some underlying cause?) it is indeed > required, if you care about power consumption. > > > > > > > Signed-off-by: Bjorn Andersson > > > --- > > Reviewed-by: Konrad Dybcio > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > > > > The Fixes sounds reasonable. Note that support for the cluster domain was not added until 6.2 and commit 25092e6100ac ("soc: qcom: rpmh-rsc: Attach RSC to cluster PM domain") while support for sc8280xp went into 5.19 IIRC. Johan