From: Jisheng Zhang <jszhang@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Samuel Holland <samuel@sholland.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org,
Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: [PATCH v3 06/10] dt-bindings: riscv: Add bouffalolab bl808 board compatibles
Date: Thu, 18 May 2023 23:59:55 +0800 [thread overview]
Message-ID: <ZGZLe6kGaD7HWQJ3@xhacker> (raw)
In-Reply-To: <20230514-kinetic-backlog-b9573ae06507@spud>
On Sun, May 14, 2023 at 07:39:28PM +0100, Conor Dooley wrote:
> On Mon, May 15, 2023 at 12:56:47AM +0800, Jisheng Zhang wrote:
>
> > +title: Bouffalo Lab Technology SoC-based boards
>
> I know you're only propagating an existing pattern, but the "SoC-based"
> looks rather odd!
>
> > +properties:
> > + $nodename:
> > + const: '/'
> > + compatible:
> > + oneOf:
> > + - description: Carrier boards for the Sipeed M1s SoM
> > + items:
> > + - enum:
> > + - sipeed,m1s-dock
>
> BTW, do you know of any other m1s compatible docks?
> I couldn't find any other ones via Google, so maybe it is just worth
FWICT, there's no other m1s compatible docks, but in theory the SoM
can be used to build different docks, I just keep it as is since you
are fine with it too ;)
> swapping the enum here for another const.
> Either is fine by me though.
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> Thanks,
> Conor.
next prev parent reply other threads:[~2023-05-18 16:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-14 16:56 [PATCH v3 00/10] riscv: add Bouffalolab bl808 support Jisheng Zhang
2023-05-14 16:56 ` [PATCH v3 01/10] dt-bindings: vendor-prefixes: add bouffalolab Jisheng Zhang
2023-05-14 16:56 ` [PATCH v3 02/10] dt-bindings: interrupt-controller: Add bouffalolab bl808 plic Jisheng Zhang
2023-05-14 18:33 ` Conor Dooley
2023-05-14 16:56 ` [PATCH v3 03/10] dt-bindings: serial: add documentation for Bouffalolab UART Driver Jisheng Zhang
2023-05-14 18:17 ` Conor Dooley
2023-05-14 23:28 ` Jisheng Zhang
2023-05-15 16:58 ` Conor Dooley
2023-05-15 6:24 ` Krzysztof Kozlowski
2023-05-14 16:56 ` [PATCH v3 04/10] serial: bflb_uart: add " Jisheng Zhang
2023-05-14 19:25 ` kernel test robot
2023-05-14 23:30 ` Jisheng Zhang
2023-05-14 16:56 ` [PATCH v3 05/10] riscv: add the Bouffalolab SoC family Kconfig option Jisheng Zhang
2023-05-14 16:56 ` [PATCH v3 06/10] dt-bindings: riscv: Add bouffalolab bl808 board compatibles Jisheng Zhang
2023-05-14 18:39 ` Conor Dooley
2023-05-18 15:59 ` Jisheng Zhang [this message]
2023-05-14 16:56 ` [PATCH v3 07/10] riscv: dts: bouffalolab: add the bl808 SoC base device tree Jisheng Zhang
2023-05-14 16:56 ` [PATCH v3 08/10] riscv: dts: bouffalolab: add Sipeed M1s SoM and Dock devicetree Jisheng Zhang
2023-05-14 16:56 ` [PATCH v3 09/10] MAINTAINERS: riscv: add entry for Bouffalolab SoC Jisheng Zhang
2023-05-14 16:56 ` [PATCH v3 10/10] riscv: defconfig: enable BOUFFALOLAB SoC Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGZLe6kGaD7HWQJ3@xhacker \
--to=jszhang@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).