* [PATCH] arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC
@ 2023-06-01 10:38 Abel Vesa
2023-06-01 10:42 ` Konrad Dybcio
2023-06-13 23:48 ` Bjorn Andersson
0 siblings, 2 replies; 5+ messages in thread
From: Abel Vesa @ 2023-06-01 10:38 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, Linux Kernel Mailing List
The USB HC node is missing the interconnect paths, so add them.
Fixes: 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 75cd374943eb..4991b2e962d1 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -2793,6 +2793,10 @@ usb_1: usb@a6f8800 {
resets = <&gcc GCC_USB30_PRIM_BCR>;
+ interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>,
+ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>;
+ interconnect-names = "usb-ddr", "apps-usb";
+
status = "disabled";
usb_1_dwc3: usb@a600000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC
2023-06-01 10:38 [PATCH] arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC Abel Vesa
@ 2023-06-01 10:42 ` Konrad Dybcio
2023-06-01 10:49 ` Abel Vesa
2023-06-13 23:48 ` Bjorn Andersson
1 sibling, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2023-06-01 10:42 UTC (permalink / raw)
To: Abel Vesa, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, Linux Kernel Mailing List
On 1.06.2023 12:38, Abel Vesa wrote:
> The USB HC node is missing the interconnect paths, so add them.
>
> Fixes: 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes")
For context, it's a fix in the context of "we should prooobably have
this if we want to fix the icc driver to include sync state".
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
sidenote:
on recent SoCs there's also an USB-IPA path:
aggre1_noc MASTER_USB3_0 <-> &config_noc SLAVE_IPA_CFG
I don't think we really make use of that upstream today or whether it
would make enabling IPA necessary (to enable the clocks and reach the
IPA hardware), but it's something to think about.
Konrad
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 75cd374943eb..4991b2e962d1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -2793,6 +2793,10 @@ usb_1: usb@a6f8800 {
>
> resets = <&gcc GCC_USB30_PRIM_BCR>;
>
> + interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>,
> + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>;
> + interconnect-names = "usb-ddr", "apps-usb";
> +
> status = "disabled";
>
> usb_1_dwc3: usb@a600000 {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC
2023-06-01 10:42 ` Konrad Dybcio
@ 2023-06-01 10:49 ` Abel Vesa
2023-06-01 10:50 ` Konrad Dybcio
0 siblings, 1 reply; 5+ messages in thread
From: Abel Vesa @ 2023-06-01 10:49 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree,
Linux Kernel Mailing List
On 23-06-01 12:42:22, Konrad Dybcio wrote:
>
>
> On 1.06.2023 12:38, Abel Vesa wrote:
> > The USB HC node is missing the interconnect paths, so add them.
> >
> > Fixes: 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes")
> For context, it's a fix in the context of "we should prooobably have
> this if we want to fix the icc driver to include sync state".
Fair enough...
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
>
>
> sidenote:
>
> on recent SoCs there's also an USB-IPA path:
>
> aggre1_noc MASTER_USB3_0 <-> &config_noc SLAVE_IPA_CFG
AFAIK, support for IPA on SM8550 is not added yet.
We can worry about this 3rd path when IPA support for this platform is
upstreamed.
>
> I don't think we really make use of that upstream today or whether it
> would make enabling IPA necessary (to enable the clocks and reach the
> IPA hardware), but it's something to think about.
>
> Konrad
> > arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> > index 75cd374943eb..4991b2e962d1 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> > @@ -2793,6 +2793,10 @@ usb_1: usb@a6f8800 {
> >
> > resets = <&gcc GCC_USB30_PRIM_BCR>;
> >
> > + interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>,
> > + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>;
> > + interconnect-names = "usb-ddr", "apps-usb";
> > +
> > status = "disabled";
> >
> > usb_1_dwc3: usb@a600000 {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC
2023-06-01 10:49 ` Abel Vesa
@ 2023-06-01 10:50 ` Konrad Dybcio
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2023-06-01 10:50 UTC (permalink / raw)
To: Abel Vesa
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree,
Linux Kernel Mailing List
On 1.06.2023 12:49, Abel Vesa wrote:
> On 23-06-01 12:42:22, Konrad Dybcio wrote:
>>
>>
>> On 1.06.2023 12:38, Abel Vesa wrote:
>>> The USB HC node is missing the interconnect paths, so add them.
>>>
>>> Fixes: 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes")
>> For context, it's a fix in the context of "we should prooobably have
>> this if we want to fix the icc driver to include sync state".
>
> Fair enough...
>
>>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
>>> ---
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>
>>
>>
>> sidenote:
>>
>> on recent SoCs there's also an USB-IPA path:
>>
>> aggre1_noc MASTER_USB3_0 <-> &config_noc SLAVE_IPA_CFG
>
> AFAIK, support for IPA on SM8550 is not added yet.
>
> We can worry about this 3rd path when IPA support for this platform is
> upstreamed.
Right, that's what I'm saying. I'm not even sure we have tethering
acceleration upstream (where IPA pushes data quickly for sharing mobile
data via USB).
Konrad
>
>>
>> I don't think we really make use of that upstream today or whether it
>> would make enabling IPA necessary (to enable the clocks and reach the
>> IPA hardware), but it's something to think about.
>>
>> Konrad
>>> arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>>> index 75cd374943eb..4991b2e962d1 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>>> @@ -2793,6 +2793,10 @@ usb_1: usb@a6f8800 {
>>>
>>> resets = <&gcc GCC_USB30_PRIM_BCR>;
>>>
>>> + interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>,
>>> + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>;
>>> + interconnect-names = "usb-ddr", "apps-usb";
>>> +
>>> status = "disabled";
>>>
>>> usb_1_dwc3: usb@a600000 {
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC
2023-06-01 10:38 [PATCH] arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC Abel Vesa
2023-06-01 10:42 ` Konrad Dybcio
@ 2023-06-13 23:48 ` Bjorn Andersson
1 sibling, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2023-06-13 23:48 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Abel Vesa, Rob Herring,
Conor Dooley, Konrad Dybcio
Cc: linux-arm-msm, devicetree, Linux Kernel Mailing List
On Thu, 1 Jun 2023 13:38:17 +0300, Abel Vesa wrote:
> The USB HC node is missing the interconnect paths, so add them.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC
commit: 11a1397bbf69e408223bb691858a0fcd295a8f76
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-13 23:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-01 10:38 [PATCH] arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC Abel Vesa
2023-06-01 10:42 ` Konrad Dybcio
2023-06-01 10:49 ` Abel Vesa
2023-06-01 10:50 ` Konrad Dybcio
2023-06-13 23:48 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox