Re: [PATCH 2/2] arm64: dts: renesas: draak: Add overlay for CVBS input

["Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>]

Hi Geert,

On 2023-06-08 08:54:26 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
> 
> Resurrecting this thread...

I still have to resurrect work on this series, but it looks like I have 
to do so in next quarter. I will then try your suggestion of disabling 
the node, thanks for the suggestion.

> 
> On Sat, Feb 11, 2023 at 5:58 PM Niklas Söderlund
> <niklas.soderlund+renesas@ragnatech.se> wrote:
> > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> >
> > The Draak board has an ADV7180 CVBS decoder and an ADV7612 HDMI decoder,
> > both connected to the same VIN input. DIP switches are used to select
> > one of the two devices, with the HDMI decoder being the default. Add an
> > overlay that selects the CVBS decoder.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > [Niklas: Inverted it from HDMI to CVBS]
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> 
> > --- a/arch/arm64/boot/dts/renesas/Makefile
> > +++ b/arch/arm64/boot/dts/renesas/Makefile
> > @@ -87,5 +87,6 @@ dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-smarc.dtb
> >
> >  dtb-$(CONFIG_ARCH_R9A09G011) += r9a09g011-v2mevk2.dtb
> >
> > +dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-cvbs-input.dtbo
> >  dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-ebisu-panel-aa104xd12.dtbo
> >  dtb-$(CONFIG_ARCH_RCAR_GEN3) += salvator-panel-aa104xd12.dtbo
> > diff --git a/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso b/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso
> > new file mode 100644
> > index 000000000000..b833c58c2029
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso
> > @@ -0,0 +1,33 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright 2023 Ideas on Board Oy
> > + *
> > + * Device tree overlay for the Draak board, to enable CVBS input. This requires
> > + * setting DIP switches SW49, SW50, SW51 and SW52 to OFF, and SW53 and SW54 to
> > + * ON.
> > + */
> > +
> > +/dts-v1/;
> > +/plugin/;
> > +
> > +&adv7180_out {
> > +       remote-endpoint = <&vin4_in>;
> > +};
> > +
> > +&i2c0 {
> > +       hdmi-decoder@4c {
> > +               ports {
> > +                       port@2 {
> > +                               /delete-node/ endpoint;
> 
> I'm afraid deleting a node doesn't work...
> Does it work if you change its status to disabled instead?
> 
> > +                       };
> > +               };
> > +       };
> > +};
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
Kind Regards,
Niklas Söderlund