* [PATCH 0/2] arm64: dts: renesas: draak: Make HDMI default video source @ 2023-02-11 16:57 Niklas Söderlund 2023-02-11 16:57 ` [PATCH 1/2] arm64: dts: renesas: draak: Make HDMI the default video input Niklas Söderlund 2023-02-11 16:57 ` [PATCH 2/2] arm64: dts: renesas: draak: Add overlay for CVBS input Niklas Söderlund 0 siblings, 2 replies; 9+ messages in thread From: Niklas Söderlund @ 2023-02-11 16:57 UTC (permalink / raw) To: Geert Uytterhoeven, Laurent Pinchart, devicetree Cc: linux-renesas-soc, Niklas Söderlund Hello, This series makes aligns the Draak board with other Gen3 boards by making the HDMI video source the default video input. Patch 1/2 changes the default, while patch 2/2 provides and overlay to easily be able to select the CVBS video source. Laurent Pinchart (1): arm64: dts: renesas: draak: Add overlay for CVBS input Niklas Söderlund (1): arm64: dts: renesas: draak: Make HDMI the default video input arch/arm64/boot/dts/renesas/Makefile | 1 + .../boot/dts/renesas/draak-cvbs-input.dtso | 33 +++++++++++++++++++ arch/arm64/boot/dts/renesas/draak.dtsi | 24 +++++++------- 3 files changed, 46 insertions(+), 12 deletions(-) create mode 100644 arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso -- 2.39.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] arm64: dts: renesas: draak: Make HDMI the default video input 2023-02-11 16:57 [PATCH 0/2] arm64: dts: renesas: draak: Make HDMI default video source Niklas Söderlund @ 2023-02-11 16:57 ` Niklas Söderlund 2023-02-11 21:46 ` Laurent Pinchart 2023-02-11 16:57 ` [PATCH 2/2] arm64: dts: renesas: draak: Add overlay for CVBS input Niklas Söderlund 1 sibling, 1 reply; 9+ messages in thread From: Niklas Söderlund @ 2023-02-11 16:57 UTC (permalink / raw) To: Geert Uytterhoeven, Laurent Pinchart, devicetree Cc: linux-renesas-soc, Niklas Söderlund Most Gen3 R-Car devices have HDMI as the default video input source, align Draak with them and make HDMI the default. While at it move the bus properties to the VIN node where they can be consumed correctly by the driver. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- arch/arm64/boot/dts/renesas/draak.dtsi | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/draak.dtsi b/arch/arm64/boot/dts/renesas/draak.dtsi index ef3bb835d5c0..e248866c7871 100644 --- a/arch/arm64/boot/dts/renesas/draak.dtsi +++ b/arch/arm64/boot/dts/renesas/draak.dtsi @@ -356,11 +356,10 @@ port@3 { * CVBS and HDMI inputs through SW[49-53] * switches. * - * CVBS is the default selection, link it to - * VIN4 here. + * HDMI is the default selection, leave CVBS + * not connected here. */ adv7180_out: endpoint { - remote-endpoint = <&vin4_in>; }; }; }; @@ -423,13 +422,11 @@ port@2 { * CVBS and HDMI inputs through SW[49-53] * switches. * - * CVBS is the default selection, leave HDMI - * not connected here. + * HDMI is the default selection, link it to + * VIN4 here. */ adv7612_out: endpoint { - pclk-sample = <0>; - hsync-active = <0>; - vsync-active = <0>; + remote-endpoint = <&vin4_in>; }; }; }; @@ -580,8 +577,8 @@ usb0_pins: usb0 { function = "usb0"; }; - vin4_pins_cvbs: vin4 { - groups = "vin4_data8", "vin4_sync", "vin4_clk"; + vin4_pins: vin4 { + groups = "vin4_data24", "vin4_sync", "vin4_clk"; function = "vin4"; }; }; @@ -729,7 +726,7 @@ &usb2_phy0 { }; &vin4 { - pinctrl-0 = <&vin4_pins_cvbs>; + pinctrl-0 = <&vin4_pins>; pinctrl-names = "default"; status = "okay"; @@ -737,7 +734,10 @@ &vin4 { ports { port { vin4_in: endpoint { - remote-endpoint = <&adv7180_out>; + pclk-sample = <0>; + hsync-active = <0>; + vsync-active = <0>; + remote-endpoint = <&adv7612_out>; }; }; }; -- 2.39.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: draak: Make HDMI the default video input 2023-02-11 16:57 ` [PATCH 1/2] arm64: dts: renesas: draak: Make HDMI the default video input Niklas Söderlund @ 2023-02-11 21:46 ` Laurent Pinchart 0 siblings, 0 replies; 9+ messages in thread From: Laurent Pinchart @ 2023-02-11 21:46 UTC (permalink / raw) To: Niklas Söderlund; +Cc: Geert Uytterhoeven, devicetree, linux-renesas-soc Hi Niklas, Thank you for the patch. On Sat, Feb 11, 2023 at 05:57:14PM +0100, Niklas Söderlund wrote: > Most Gen3 R-Car devices have HDMI as the default video input source, > align Draak with them and make HDMI the default. While at it move the > bus properties to the VIN node where they can be consumed correctly by > the driver. I'm fine with the idea, but I'm wondering if this matches the default DIP switches configuration that boards are shipped with. This being said, when I check the switches on my board to test HDMI input a few days ago, I realized they were set to a hybrid configuration, so maybe we should just roll our eyes and merge this :-) > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > arch/arm64/boot/dts/renesas/draak.dtsi | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/boot/dts/renesas/draak.dtsi b/arch/arm64/boot/dts/renesas/draak.dtsi > index ef3bb835d5c0..e248866c7871 100644 > --- a/arch/arm64/boot/dts/renesas/draak.dtsi > +++ b/arch/arm64/boot/dts/renesas/draak.dtsi > @@ -356,11 +356,10 @@ port@3 { > * CVBS and HDMI inputs through SW[49-53] > * switches. > * > - * CVBS is the default selection, link it to > - * VIN4 here. > + * HDMI is the default selection, leave CVBS > + * not connected here. > */ > adv7180_out: endpoint { > - remote-endpoint = <&vin4_in>; > }; Endpoints are required to have a remote-endpoint property, so you should drop the endpoint completely. This will require a change in patch 2/2 as you'll have to create the endpoint there. > }; > }; > @@ -423,13 +422,11 @@ port@2 { > * CVBS and HDMI inputs through SW[49-53] > * switches. > * > - * CVBS is the default selection, leave HDMI > - * not connected here. > + * HDMI is the default selection, link it to > + * VIN4 here. > */ > adv7612_out: endpoint { > - pclk-sample = <0>; > - hsync-active = <0>; > - vsync-active = <0>; This will cause the bus type to change from parallel to BT656. Is that desired ? If not, I'd set the bus-type property explicitly. Actually, I'd set it explicitly in any case. This change is worth being split to a separate patch. > + remote-endpoint = <&vin4_in>; > }; > }; > }; > @@ -580,8 +577,8 @@ usb0_pins: usb0 { > function = "usb0"; > }; > > - vin4_pins_cvbs: vin4 { > - groups = "vin4_data8", "vin4_sync", "vin4_clk"; > + vin4_pins: vin4 { > + groups = "vin4_data24", "vin4_sync", "vin4_clk"; > function = "vin4"; > }; > }; > @@ -729,7 +726,7 @@ &usb2_phy0 { > }; > > &vin4 { > - pinctrl-0 = <&vin4_pins_cvbs>; > + pinctrl-0 = <&vin4_pins>; > pinctrl-names = "default"; > > status = "okay"; > @@ -737,7 +734,10 @@ &vin4 { > ports { > port { > vin4_in: endpoint { > - remote-endpoint = <&adv7180_out>; > + pclk-sample = <0>; > + hsync-active = <0>; > + vsync-active = <0>; > + remote-endpoint = <&adv7612_out>; > }; > }; > }; -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] arm64: dts: renesas: draak: Add overlay for CVBS input 2023-02-11 16:57 [PATCH 0/2] arm64: dts: renesas: draak: Make HDMI default video source Niklas Söderlund 2023-02-11 16:57 ` [PATCH 1/2] arm64: dts: renesas: draak: Make HDMI the default video input Niklas Söderlund @ 2023-02-11 16:57 ` Niklas Söderlund 2023-02-11 21:37 ` Laurent Pinchart ` (2 more replies) 1 sibling, 3 replies; 9+ messages in thread From: Niklas Söderlund @ 2023-02-11 16:57 UTC (permalink / raw) To: Geert Uytterhoeven, Laurent Pinchart, devicetree Cc: linux-renesas-soc, Niklas Söderlund From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> The Draak board has an ADV7180 CVBS decoder and an ADV7612 HDMI decoder, both connected to the same VIN input. DIP switches are used to select one of the two devices, with the HDMI decoder being the default. Add an overlay that selects the CVBS decoder. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> [Niklas: Inverted it from HDMI to CVBS] Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- arch/arm64/boot/dts/renesas/Makefile | 1 + .../boot/dts/renesas/draak-cvbs-input.dtso | 33 +++++++++++++++++++ 2 files changed, 34 insertions(+) create mode 100644 arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile index 0699b51c1247..f5df37253184 100644 --- a/arch/arm64/boot/dts/renesas/Makefile +++ b/arch/arm64/boot/dts/renesas/Makefile @@ -87,5 +87,6 @@ dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-smarc.dtb dtb-$(CONFIG_ARCH_R9A09G011) += r9a09g011-v2mevk2.dtb +dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-cvbs-input.dtbo dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-ebisu-panel-aa104xd12.dtbo dtb-$(CONFIG_ARCH_RCAR_GEN3) += salvator-panel-aa104xd12.dtbo diff --git a/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso b/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso new file mode 100644 index 000000000000..b833c58c2029 --- /dev/null +++ b/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso @@ -0,0 +1,33 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2023 Ideas on Board Oy + * + * Device tree overlay for the Draak board, to enable CVBS input. This requires + * setting DIP switches SW49, SW50, SW51 and SW52 to OFF, and SW53 and SW54 to + * ON. + */ + +/dts-v1/; +/plugin/; + +&adv7180_out { + remote-endpoint = <&vin4_in>; +}; + +&i2c0 { + hdmi-decoder@4c { + ports { + port@2 { + /delete-node/ endpoint; + }; + }; + }; +}; + +&vin4_in { + remote-endpoint = <&adv7180_out>; +}; + +&vin4_pins { + groups = "vin4_data8", "vin4_sync", "vin4_clk"; +}; -- 2.39.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: draak: Add overlay for CVBS input 2023-02-11 16:57 ` [PATCH 2/2] arm64: dts: renesas: draak: Add overlay for CVBS input Niklas Söderlund @ 2023-02-11 21:37 ` Laurent Pinchart 2023-02-14 9:46 ` Geert Uytterhoeven 2023-06-08 6:54 ` Geert Uytterhoeven 2 siblings, 0 replies; 9+ messages in thread From: Laurent Pinchart @ 2023-02-11 21:37 UTC (permalink / raw) To: Niklas Söderlund; +Cc: Geert Uytterhoeven, devicetree, linux-renesas-soc Hi Niklas, Thank you for the patch. On Sat, Feb 11, 2023 at 05:57:15PM +0100, Niklas Söderlund wrote: > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > The Draak board has an ADV7180 CVBS decoder and an ADV7612 HDMI decoder, > both connected to the same VIN input. DIP switches are used to select > one of the two devices, with the HDMI decoder being the default. Add an > overlay that selects the CVBS decoder. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > [Niklas: Inverted it from HDMI to CVBS] > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm64/boot/dts/renesas/Makefile | 1 + > .../boot/dts/renesas/draak-cvbs-input.dtso | 33 +++++++++++++++++++ > 2 files changed, 34 insertions(+) > create mode 100644 arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso > > diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile > index 0699b51c1247..f5df37253184 100644 > --- a/arch/arm64/boot/dts/renesas/Makefile > +++ b/arch/arm64/boot/dts/renesas/Makefile > @@ -87,5 +87,6 @@ dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-smarc.dtb > > dtb-$(CONFIG_ARCH_R9A09G011) += r9a09g011-v2mevk2.dtb > > +dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-cvbs-input.dtbo > dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-ebisu-panel-aa104xd12.dtbo > dtb-$(CONFIG_ARCH_RCAR_GEN3) += salvator-panel-aa104xd12.dtbo > diff --git a/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso b/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso > new file mode 100644 > index 000000000000..b833c58c2029 > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso > @@ -0,0 +1,33 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2023 Ideas on Board Oy > + * > + * Device tree overlay for the Draak board, to enable CVBS input. This requires > + * setting DIP switches SW49, SW50, SW51 and SW52 to OFF, and SW53 and SW54 to > + * ON. > + */ > + > +/dts-v1/; > +/plugin/; > + > +&adv7180_out { > + remote-endpoint = <&vin4_in>; > +}; > + > +&i2c0 { > + hdmi-decoder@4c { > + ports { > + port@2 { > + /delete-node/ endpoint; > + }; > + }; > + }; > +}; > + > +&vin4_in { > + remote-endpoint = <&adv7180_out>; > +}; > + > +&vin4_pins { > + groups = "vin4_data8", "vin4_sync", "vin4_clk"; > +}; -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: draak: Add overlay for CVBS input 2023-02-11 16:57 ` [PATCH 2/2] arm64: dts: renesas: draak: Add overlay for CVBS input Niklas Söderlund 2023-02-11 21:37 ` Laurent Pinchart @ 2023-02-14 9:46 ` Geert Uytterhoeven 2023-02-14 9:52 ` Laurent Pinchart 2023-06-08 6:54 ` Geert Uytterhoeven 2 siblings, 1 reply; 9+ messages in thread From: Geert Uytterhoeven @ 2023-02-14 9:46 UTC (permalink / raw) To: Niklas Söderlund, Laurent Pinchart; +Cc: devicetree, linux-renesas-soc Hi Niklas, Laurent, On Sat, Feb 11, 2023 at 5:58 PM Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote: > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > The Draak board has an ADV7180 CVBS decoder and an ADV7612 HDMI decoder, > both connected to the same VIN input. DIP switches are used to select > one of the two devices, with the HDMI decoder being the default. Add an > overlay that selects the CVBS decoder. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > [Niklas: Inverted it from HDMI to CVBS] > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso > @@ -0,0 +1,33 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2023 Ideas on Board Oy > + * > + * Device tree overlay for the Draak board, to enable CVBS input. This requires > + * setting DIP switches SW49, SW50, SW51 and SW52 to OFF, and SW53 and SW54 to > + * ON. > + */ > + > +/dts-v1/; > +/plugin/; > + > +&adv7180_out { > + remote-endpoint = <&vin4_in>; > +}; [...] > +&vin4_in { > + remote-endpoint = <&adv7180_out>; > +}; Unfortunately dtc doesn't like references to nodes it cannot find the names of: arch/arm64/boot/dts/renesas/draak-cvbs-input.dtbo: Warning (graph_port): /fragment@0: graph port node name should be 'port' arch/arm64/boot/dts/renesas/draak-cvbs-input.dtbo: Warning (graph_port): /fragment@2: graph port node name should be 'port' arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso:13.14-15.3: Warning (graph_endpoint): /fragment@0/__overlay__: graph endpoint node name should be 'endpoint' arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso:27.10-29.3: Warning (graph_endpoint): /fragment@2/__overlay__: graph endpoint node name should be 'endpoint' Do you think it would be worthwhile to add more hierarchy (like in arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dtso), to get rid of the dtc warnings? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: draak: Add overlay for CVBS input 2023-02-14 9:46 ` Geert Uytterhoeven @ 2023-02-14 9:52 ` Laurent Pinchart 0 siblings, 0 replies; 9+ messages in thread From: Laurent Pinchart @ 2023-02-14 9:52 UTC (permalink / raw) To: Geert Uytterhoeven; +Cc: Niklas Söderlund, devicetree, linux-renesas-soc Hi Geert, On Tue, Feb 14, 2023 at 10:46:48AM +0100, Geert Uytterhoeven wrote: > On Sat, Feb 11, 2023 at 5:58 PM Niklas Söderlund wrote: > > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > > > The Draak board has an ADV7180 CVBS decoder and an ADV7612 HDMI decoder, > > both connected to the same VIN input. DIP switches are used to select > > one of the two devices, with the HDMI decoder being the default. Add an > > overlay that selects the CVBS decoder. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > [Niklas: Inverted it from HDMI to CVBS] > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > Thanks for your patch! > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- /dev/null > > +++ b/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso > > @@ -0,0 +1,33 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright 2023 Ideas on Board Oy > > + * > > + * Device tree overlay for the Draak board, to enable CVBS input. This requires > > + * setting DIP switches SW49, SW50, SW51 and SW52 to OFF, and SW53 and SW54 to > > + * ON. > > + */ > > + > > +/dts-v1/; > > +/plugin/; > > + > > +&adv7180_out { > > + remote-endpoint = <&vin4_in>; > > +}; > > [...] > > > +&vin4_in { > > + remote-endpoint = <&adv7180_out>; > > +}; > > Unfortunately dtc doesn't like references to nodes it cannot find the > names of: > > arch/arm64/boot/dts/renesas/draak-cvbs-input.dtbo: Warning > (graph_port): /fragment@0: graph port node name should be 'port' > arch/arm64/boot/dts/renesas/draak-cvbs-input.dtbo: Warning > (graph_port): /fragment@2: graph port node name should be 'port' > arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso:13.14-15.3: > Warning (graph_endpoint): /fragment@0/__overlay__: graph endpoint node > name should be 'endpoint' > arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso:27.10-29.3: > Warning (graph_endpoint): /fragment@2/__overlay__: graph endpoint node > name should be 'endpoint' > > Do you think it would be worthwhile to add more hierarchy (like in > arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dtso), to get > rid of the dtc warnings? We could, but I think this is an issue that will need to somehow be fixed in dtc. There are lots of warnings when compiling overlays, they can only be validated when applied to a base DT. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: draak: Add overlay for CVBS input 2023-02-11 16:57 ` [PATCH 2/2] arm64: dts: renesas: draak: Add overlay for CVBS input Niklas Söderlund 2023-02-11 21:37 ` Laurent Pinchart 2023-02-14 9:46 ` Geert Uytterhoeven @ 2023-06-08 6:54 ` Geert Uytterhoeven 2023-06-08 13:16 ` Niklas Söderlund 2 siblings, 1 reply; 9+ messages in thread From: Geert Uytterhoeven @ 2023-06-08 6:54 UTC (permalink / raw) To: Niklas Söderlund; +Cc: Laurent Pinchart, devicetree, linux-renesas-soc Hi Niklas, Resurrecting this thread... On Sat, Feb 11, 2023 at 5:58 PM Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote: > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > The Draak board has an ADV7180 CVBS decoder and an ADV7612 HDMI decoder, > both connected to the same VIN input. DIP switches are used to select > one of the two devices, with the HDMI decoder being the default. Add an > overlay that selects the CVBS decoder. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > [Niklas: Inverted it from HDMI to CVBS] > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- a/arch/arm64/boot/dts/renesas/Makefile > +++ b/arch/arm64/boot/dts/renesas/Makefile > @@ -87,5 +87,6 @@ dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-smarc.dtb > > dtb-$(CONFIG_ARCH_R9A09G011) += r9a09g011-v2mevk2.dtb > > +dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-cvbs-input.dtbo > dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-ebisu-panel-aa104xd12.dtbo > dtb-$(CONFIG_ARCH_RCAR_GEN3) += salvator-panel-aa104xd12.dtbo > diff --git a/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso b/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso > new file mode 100644 > index 000000000000..b833c58c2029 > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso > @@ -0,0 +1,33 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2023 Ideas on Board Oy > + * > + * Device tree overlay for the Draak board, to enable CVBS input. This requires > + * setting DIP switches SW49, SW50, SW51 and SW52 to OFF, and SW53 and SW54 to > + * ON. > + */ > + > +/dts-v1/; > +/plugin/; > + > +&adv7180_out { > + remote-endpoint = <&vin4_in>; > +}; > + > +&i2c0 { > + hdmi-decoder@4c { > + ports { > + port@2 { > + /delete-node/ endpoint; I'm afraid deleting a node doesn't work... Does it work if you change its status to disabled instead? > + }; > + }; > + }; > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: draak: Add overlay for CVBS input 2023-06-08 6:54 ` Geert Uytterhoeven @ 2023-06-08 13:16 ` Niklas Söderlund 0 siblings, 0 replies; 9+ messages in thread From: Niklas Söderlund @ 2023-06-08 13:16 UTC (permalink / raw) To: Geert Uytterhoeven; +Cc: Laurent Pinchart, devicetree, linux-renesas-soc Hi Geert, On 2023-06-08 08:54:26 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > Resurrecting this thread... I still have to resurrect work on this series, but it looks like I have to do so in next quarter. I will then try your suggestion of disabling the node, thanks for the suggestion. > > On Sat, Feb 11, 2023 at 5:58 PM Niklas Söderlund > <niklas.soderlund+renesas@ragnatech.se> wrote: > > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > > > The Draak board has an ADV7180 CVBS decoder and an ADV7612 HDMI decoder, > > both connected to the same VIN input. DIP switches are used to select > > one of the two devices, with the HDMI decoder being the default. Add an > > overlay that selects the CVBS decoder. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > [Niklas: Inverted it from HDMI to CVBS] > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > > --- a/arch/arm64/boot/dts/renesas/Makefile > > +++ b/arch/arm64/boot/dts/renesas/Makefile > > @@ -87,5 +87,6 @@ dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-smarc.dtb > > > > dtb-$(CONFIG_ARCH_R9A09G011) += r9a09g011-v2mevk2.dtb > > > > +dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-cvbs-input.dtbo > > dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-ebisu-panel-aa104xd12.dtbo > > dtb-$(CONFIG_ARCH_RCAR_GEN3) += salvator-panel-aa104xd12.dtbo > > diff --git a/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso b/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso > > new file mode 100644 > > index 000000000000..b833c58c2029 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/renesas/draak-cvbs-input.dtso > > @@ -0,0 +1,33 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright 2023 Ideas on Board Oy > > + * > > + * Device tree overlay for the Draak board, to enable CVBS input. This requires > > + * setting DIP switches SW49, SW50, SW51 and SW52 to OFF, and SW53 and SW54 to > > + * ON. > > + */ > > + > > +/dts-v1/; > > +/plugin/; > > + > > +&adv7180_out { > > + remote-endpoint = <&vin4_in>; > > +}; > > + > > +&i2c0 { > > + hdmi-decoder@4c { > > + ports { > > + port@2 { > > + /delete-node/ endpoint; > > I'm afraid deleting a node doesn't work... > Does it work if you change its status to disabled instead? > > > + }; > > + }; > > + }; > > +}; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Kind Regards, Niklas Söderlund ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-06-08 13:16 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-02-11 16:57 [PATCH 0/2] arm64: dts: renesas: draak: Make HDMI default video source Niklas Söderlund 2023-02-11 16:57 ` [PATCH 1/2] arm64: dts: renesas: draak: Make HDMI the default video input Niklas Söderlund 2023-02-11 21:46 ` Laurent Pinchart 2023-02-11 16:57 ` [PATCH 2/2] arm64: dts: renesas: draak: Add overlay for CVBS input Niklas Söderlund 2023-02-11 21:37 ` Laurent Pinchart 2023-02-14 9:46 ` Geert Uytterhoeven 2023-02-14 9:52 ` Laurent Pinchart 2023-06-08 6:54 ` Geert Uytterhoeven 2023-06-08 13:16 ` Niklas Söderlund
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).