From: Stephan Gerhold <stephan@gerhold.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v2 05/12] dt-bindings: remoteproc: Add Qualcomm RPM processor/subsystem
Date: Sat, 10 Jun 2023 18:52:04 +0200 [thread overview]
Message-ID: <ZISqNPnQgPNEsmxa@gerhold.net> (raw)
In-Reply-To: <9cdf22cc-6509-b87e-e631-4e3633d1f542@linaro.org>
On Sat, Jun 10, 2023 at 06:43:17PM +0200, Krzysztof Kozlowski wrote:
> On 08/06/2023 09:10, Stephan Gerhold wrote:
> > On Qualcomm platforms, most subsystems (e.g. audio/modem DSP) are
> > described as remote processors in the device tree, with a dedicated
> > node where properties and services related to them can be described.
> > +
> > + smd-edge:
> > + $ref: /schemas/remoteproc/qcom,smd-edge.yaml#
> > + description:
> > + Qualcomm Shared Memory subnode which represents communication edge,
> > + channels and devices related to the RPM subsystem.
> > +
> > + glink-rpm:
>
> This should be "glink-edge", to be a bit more generic and match existing
> smd-edge.
>
I fully agree and I actually made that change at some point before
sending v1. Unfortunately, it doesn't work: The node name "glink-edge"
is already reserved by qcom,glink-edge.yaml. While it's very similar it
has some subtle differences to glink-rpm-edge.yaml. For example, there
is no qcom,remote-pid in the RPM variant which is required by the normal
glink-edge.
Would "glink-rpm-edge" sound better?
Thanks,
Stephan
next prev parent reply other threads:[~2023-06-10 16:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 7:10 [PATCH v2 00/12] Add dedicated device tree node for RPM processor/subsystem Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 01/12] dt-bindings soc: qcom: smd-rpm: Fix sort order Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 02/12] dt-bindings: soc: qcom: smd-rpm: Add MSM8909 to qcom,smd-channels Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 03/12] dt-bindings: soc: qcom: smd-rpm: Add some more compatibles Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 04/12] soc: qcom: smd-rpm: Match rpmsg channel instead of compatible Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 05/12] dt-bindings: remoteproc: Add Qualcomm RPM processor/subsystem Stephan Gerhold
2023-06-08 8:27 ` Rob Herring
2023-06-10 16:43 ` Krzysztof Kozlowski
2023-06-10 16:52 ` Stephan Gerhold [this message]
2023-06-12 18:19 ` Krzysztof Kozlowski
2023-06-08 7:10 ` [PATCH v2 06/12] soc: qcom: smem: Add qcom_smem_is_available() Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 07/12] rpmsg: qcom_smd: Use qcom_smem_is_available() Stephan Gerhold
2023-06-09 15:07 ` Konrad Dybcio
2023-06-08 7:10 ` [PATCH v2 08/12] soc: qcom: Add RPM processor/subsystem driver Stephan Gerhold
2023-06-09 15:24 ` Konrad Dybcio
2023-06-08 7:10 ` [PATCH v2 09/12] arm64: dts: qcom: Add rpm-proc node for SMD platforms Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 10/12] arm64: dts: qcom: Add rpm-proc node for GLINK gplatforms Stephan Gerhold
2023-06-08 7:10 ` [PATCH v2 11/12] ARM: dts: qcom: Add rpm-proc node for SMD platforms Stephan Gerhold
2023-06-09 15:26 ` Konrad Dybcio
2023-06-08 7:10 ` [PATCH v2 12/12] ARM: dts: qcom: apq8064: Drop redundant /smd node Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZISqNPnQgPNEsmxa@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).