From: Jeff LaBundy <jeff@labundy.com>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Bastien Nocera <hadess@hadess.net>,
Hans de Goede <hdegoede@redhat.com>,
Henrik Rydberg <rydberg@bitmath.org>,
linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 4/4] input: touchscreen: add SPI support for Goodix Berlin Touchscreen IC
Date: Mon, 12 Jun 2023 12:07:59 -0500 [thread overview]
Message-ID: <ZIdQ723G8/a0tNEZ@nixie71> (raw)
In-Reply-To: <a87160e5-b895-3dae-bba0-94fc67c92679@linaro.org>
Hi Neil,
[...]
> > > +static const struct input_id goodix_berlin_spi_input_id = {
> > > + .bustype = BUS_SPI,
> > > + .vendor = 0x0416,
> > > + .product = 0x1001,
> >
> > After having seen these in the I2C counterpart; consider defining them
> > in goodix_berlin.h.
>
> To be honest, I blindly copied it from goodix.c because the vendor
> driver puts random values here.
>
> input_dev->id.product = 0xDEAD;
> input_dev->id.vendor = 0xBEEF;
>
> So what should I set ?
If there is no explicit guidance from the vendor, I would simply leave
these unassigned; in theory one would imagine that this controller would
have a different product ID than other models.
[...]
Kind regards,
Jeff LaBundy
next prev parent reply other threads:[~2023-06-12 17:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 14:31 [PATCH RFC 0/4] input: touchscreen: add initial support for Goodix Berlin touchscreen IC Neil Armstrong
2023-06-06 14:31 ` [PATCH RFC 1/4] dt-bindings: input: document Goodix Berlin Touchscreen IC Neil Armstrong
2023-06-07 8:35 ` Krzysztof Kozlowski
2023-06-14 22:28 ` Rob Herring
2023-06-06 14:31 ` [PATCH RFC 2/4] input: touchscreen: add core support for " Neil Armstrong
2023-06-12 4:45 ` Jeff LaBundy
2023-06-12 8:37 ` Neil Armstrong
2023-06-12 16:59 ` Jeff LaBundy
2023-06-06 14:31 ` [PATCH RFC 3/4] input: touchscreen: add I2C " Neil Armstrong
2023-06-12 3:09 ` Jeff LaBundy
2023-06-06 14:31 ` [PATCH RFC 4/4] input: touchscreen: add SPI " Neil Armstrong
2023-06-12 3:31 ` Jeff LaBundy
2023-06-12 12:01 ` Neil Armstrong
2023-06-12 17:07 ` Jeff LaBundy [this message]
2023-06-15 8:20 ` Neil Armstrong
2023-06-06 15:31 ` [PATCH RFC 0/4] input: touchscreen: add initial support for Goodix Berlin touchscreen IC Hans de Goede
2023-06-06 18:12 ` Neil Armstrong
2023-06-06 18:44 ` Dmitry Torokhov
2023-06-06 18:55 ` Neil Armstrong
2023-06-06 19:02 ` Dmitry Torokhov
2023-06-06 18:55 ` Hans de Goede
2023-06-19 7:06 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIdQ723G8/a0tNEZ@nixie71 \
--to=jeff@labundy.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox