From: Stephan Gerhold <stephan@gerhold.net>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: msm8996: Fix HDMI node
Date: Thu, 15 Jun 2023 10:22:12 +0200 [thread overview]
Message-ID: <ZIrJ86IsLOm_Scbc@gerhold.net> (raw)
In-Reply-To: <20230615-topic-8996hdmi-v1-1-39584bfd68d2@linaro.org>
On Thu, Jun 15, 2023 at 10:12:32AM +0200, Konrad Dybcio wrote:
> A recent commit messed up the node name and compatibles. Fix it.
>
> Fixes: f43b6dc7d56e ("arm64: dts: qcom: msm8996: rename labels for HDMI nodes")
Looks like that commit did a simple search & replace without checking
the result :')
Can you also fix the weird pinctrl node names in apq8096-db820c?
(mdss_hdmi -> mdss-hdmi, or maybe even rename it back to just hdmi-
since that part doesn't really need grouping...)
The "hdmi-dai-link" was also changed to "mdss_hdmi-dai-link".
Thanks,
Stephan
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 0cb2d4f08c3a..40ac0a784a4a 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1136,8 +1136,8 @@ mdss_dsi1_phy: phy@996400 {
> status = "disabled";
> };
>
> - mdss_hdmi: mdss_hdmi-tx@9a0000 {
> - compatible = "qcom,mdss_hdmi-tx-8996";
> + mdss_hdmi: hdmi-tx@9a0000 {
> + compatible = "qcom,hdmi-tx-8996";
> reg = <0x009a0000 0x50c>,
> <0x00070000 0x6158>,
> <0x009e0000 0xfff>;
> @@ -1180,7 +1180,7 @@ mdss_hdmi_in: endpoint {
>
> mdss_hdmi_phy: phy@9a0600 {
> #phy-cells = <0>;
> - compatible = "qcom,mdss_hdmi-phy-8996";
> + compatible = "qcom,hdmi-phy-8996";
> reg = <0x009a0600 0x1c4>,
> <0x009a0a00 0x124>,
> <0x009a0c00 0x124>,
>
> ---
> base-commit: 925294c9aa184801cc0a451b69a18dd0fe7d847d
> change-id: 20230615-topic-8996hdmi-520fb03bd36c
>
> Best regards,
> --
> Konrad Dybcio <konrad.dybcio@linaro.org>
>
prev parent reply other threads:[~2023-06-15 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 8:12 [PATCH] arm64: dts: qcom: msm8996: Fix HDMI node Konrad Dybcio
2023-06-15 8:19 ` Dmitry Baryshkov
2023-06-15 8:21 ` Dmitry Baryshkov
2023-06-15 8:22 ` Stephan Gerhold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIrJ86IsLOm_Scbc@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).