From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v1 1/1] of/platform: Propagate firmware node by calling device_set_node()
Date: Thu, 15 Jun 2023 17:59:52 +0300 [thread overview]
Message-ID: <ZIsnaE95qIJ2DVzK@smile.fi.intel.com> (raw)
In-Reply-To: <20230615145243.37095-1-andriy.shevchenko@linux.intel.com>
On Thu, Jun 15, 2023 at 05:52:43PM +0300, Andy Shevchenko wrote:
> Insulate of_device_alloc() and of_amba_device_create() from possible
> changes to fwnode_handle implementation by using device_set_node()
> instead of open-coding dev->dev.fwnode assignments.
Side note. When I preparing this change I have noticed a lot of
dev_set_name(... dev_name())
in the code which seems to me problematic in two ways:
1) (minor) the dev_set_name() may fail, no checks are there;
2) (major?) the above construction leaks memory.
Is it on purpose (esp. second point)? If no, can it be fixed?
Note, I'm not familiar with OF platform code, so I would help
reviewing the change, but that's it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-15 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 14:52 [PATCH v1 1/1] of/platform: Propagate firmware node by calling device_set_node() Andy Shevchenko
2023-06-15 14:59 ` Andy Shevchenko [this message]
2023-06-15 15:01 ` Andy Shevchenko
2023-06-15 15:03 ` Andy Shevchenko
2023-06-15 16:44 ` Rob Herring
2023-06-15 17:13 ` Andy Shevchenko
2023-06-15 17:20 ` Andy Shevchenko
2023-06-15 16:48 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIsnaE95qIJ2DVzK@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).