From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81120EB64D8 for ; Wed, 21 Jun 2023 15:10:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232927AbjFUPKx (ORCPT ); Wed, 21 Jun 2023 11:10:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233096AbjFUPKa (ORCPT ); Wed, 21 Jun 2023 11:10:30 -0400 Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB3085262 for ; Wed, 21 Jun 2023 08:05:55 -0700 (PDT) Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-57059626276so66658857b3.3 for ; Wed, 21 Jun 2023 08:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687359940; x=1689951940; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=71z8LhgGLO2daEYFxMvnjOv3P6R9bwnVjy2+4M+RqPE=; b=d1xygi3ixDxKKey0eq8olUuPJSsUaPU0kyW56buZMIEN2kM6opSC8su4XmuliTobzx 3PIir9q9uxV/Isb9+aJqPiasE2uTiD4n5B8wg7H8ONCQ2o632LqTke4NuhmZyc7xYxpm ARkINEWTIuFegaOtNmYLx/yhd1yS/FElhX7H4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687359940; x=1689951940; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=71z8LhgGLO2daEYFxMvnjOv3P6R9bwnVjy2+4M+RqPE=; b=hjxBGqxI16m6KILE7plR6aqop0KbiaOUmpYE9Y07FExpuY4DvcQj8uL1SXpHHs0Sb8 DumXgLe//n4ZinEKVRAmk3wGIydsukrXyorFvXI9NPWY0se4Z31owGUY+V2NCp3zl0a5 uiHnG9/+NzDhxG2ZsFBVQzPjD8aRrx3cz330UM/sLxgk14qUan+rJmXtbE9z4qm1ghP6 iKLXdr/AaTn2kLzQd5Ngn3yUWUKm4A8MvDV9+oJCGjWrd1Fyd57XQ8S8skOgSg6iedH3 VA5FxL58ETi0kNc8K/prP68VzK+5hLxTPaF30K/fT+nS3B0vVS8fi1QnbevWKo7RaGWD cuXA== X-Gm-Message-State: AC+VfDzZ1FrV/y7ievMu6BMiLW942qlb25E4jS7XXOPQtI+zU/CZcWfH lObhSMqhMdugV+qCke6uRsvUB4bEgE10qqWyjBE= X-Google-Smtp-Source: ACHHUZ40pm00cx+5QtNSdK+p1nl1iGTlL8sdLUPf0anon/otCr2jk9289Avlf7F6IwoMeQOYIoCJzQ== X-Received: by 2002:a05:6602:91:b0:780:c787:637b with SMTP id h17-20020a056602009100b00780c787637bmr56097iob.0.1687359425648; Wed, 21 Jun 2023 07:57:05 -0700 (PDT) Received: from localhost (30.23.70.34.bc.googleusercontent.com. [34.70.23.30]) by smtp.gmail.com with UTF8SMTPSA id p7-20020a0566380e8700b0042674500f87sm308659jas.123.2023.06.21.07.57.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 07:57:04 -0700 (PDT) Date: Wed, 21 Jun 2023 14:57:03 +0000 From: Matthias Kaehlcke To: Benjamin Bara Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Bara , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/3] usb: misc: onboard-hub: support multiple power supplies Message-ID: References: <20230620-hx3-v2-0-76a53434c713@skidata.com> <20230620-hx3-v2-1-76a53434c713@skidata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230620-hx3-v2-1-76a53434c713@skidata.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Wed, Jun 21, 2023 at 04:26:27PM +0200, Benjamin Bara wrote: > From: Benjamin Bara > > As some of the onboard hubs require multiple power supplies, provide the > environment to support them. > > Signed-off-by: Benjamin Bara Overall this looks good to me, a few nits inside. > --- > v2: > - replace (err != 0) with (err) > --- > drivers/usb/misc/onboard_usb_hub.c | 36 ++++++++++++++++++++++++++++-------- > drivers/usb/misc/onboard_usb_hub.h | 1 + > 2 files changed, 29 insertions(+), 8 deletions(-) > > diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c > index 12fc6eb67c3b..3de30356a684 100644 > --- a/drivers/usb/misc/onboard_usb_hub.c > +++ b/drivers/usb/misc/onboard_usb_hub.c > @@ -27,6 +27,12 @@ > > #include "onboard_usb_hub.h" > > +#define SUPPLIES_NUM_MAX 2 MAX_SUPPLIES? add empty line > +static const char * const supply_names[] = { > + "vdd", > + "vdd2", > +}; > + > static void onboard_hub_attach_usb_driver(struct work_struct *work); > > static struct usb_device_driver onboard_hub_usbdev_driver; > @@ -40,7 +46,8 @@ struct usbdev_node { > }; > > struct onboard_hub { > - struct regulator *vdd; > + struct regulator_bulk_data supplies[SUPPLIES_NUM_MAX]; > + unsigned int supplies_num; num_supplies? > struct device *dev; > const struct onboard_hub_pdata *pdata; > struct gpio_desc *reset_gpio; > @@ -55,9 +62,9 @@ static int onboard_hub_power_on(struct onboard_hub *hub) > { > int err; > > - err = regulator_enable(hub->vdd); > + err = regulator_bulk_enable(hub->supplies_num, hub->supplies); > if (err) { > - dev_err(hub->dev, "failed to enable regulator: %d\n", err); > + dev_err(hub->dev, "failed to enable supplies: %d\n", err); > return err; > } > > @@ -75,9 +82,9 @@ static int onboard_hub_power_off(struct onboard_hub *hub) > > gpiod_set_value_cansleep(hub->reset_gpio, 1); > > - err = regulator_disable(hub->vdd); > + err = regulator_bulk_disable(hub->supplies_num, hub->supplies); > if (err) { > - dev_err(hub->dev, "failed to disable regulator: %d\n", err); > + dev_err(hub->dev, "failed to disable supplies: %d\n", err); > return err; > } > > @@ -232,6 +239,7 @@ static int onboard_hub_probe(struct platform_device *pdev) > const struct of_device_id *of_id; > struct device *dev = &pdev->dev; > struct onboard_hub *hub; > + unsigned int i; > int err; > > hub = devm_kzalloc(dev, sizeof(*hub), GFP_KERNEL); > @@ -246,9 +254,21 @@ static int onboard_hub_probe(struct platform_device *pdev) > if (!hub->pdata) > return -EINVAL; > > - hub->vdd = devm_regulator_get(dev, "vdd"); > - if (IS_ERR(hub->vdd)) > - return PTR_ERR(hub->vdd); > + if (hub->pdata->supplies_num > SUPPLIES_NUM_MAX) > + return dev_err_probe(dev, -EINVAL, "max %d supplies supported!\n", > + SUPPLIES_NUM_MAX); > + hub->supplies_num = 1; > + if (hub->pdata->supplies_num > 1) > + hub->supplies_num = hub->pdata->supplies_num; Please change the above to: if (hub->pdata->supplies_num != 0) hub->supplies_num = hub->pdata->supplies_num; else hub->supplies_num = 1; > + > + for (i = 0; i < SUPPLIES_NUM_MAX; i++) > + hub->supplies[i].supply = supply_names[i]; > + > + err = devm_regulator_bulk_get(dev, hub->supplies_num, hub->supplies); > + if (err) { > + dev_err(dev, "Failed to get regulator supplies: %d\n", err); > + return err; > + } > > hub->reset_gpio = devm_gpiod_get_optional(dev, "reset", > GPIOD_OUT_HIGH); > diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h > index aca5f50eb0da..657190bf1799 100644 > --- a/drivers/usb/misc/onboard_usb_hub.h > +++ b/drivers/usb/misc/onboard_usb_hub.h > @@ -8,6 +8,7 @@ > > struct onboard_hub_pdata { > unsigned long reset_us; /* reset pulse width in us */ > + unsigned int supplies_num; /* num of supplies: 0 considered as 1 */ num_supplies? s/num of/number of/ > };