From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23F32C001B1 for ; Tue, 27 Jun 2023 15:27:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232370AbjF0P1t (ORCPT ); Tue, 27 Jun 2023 11:27:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232354AbjF0P1q (ORCPT ); Tue, 27 Jun 2023 11:27:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 685842976; Tue, 27 Jun 2023 08:27:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D4353611D6; Tue, 27 Jun 2023 15:27:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CF45C433C8; Tue, 27 Jun 2023 15:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687879655; bh=QJEP2hAFIWiHYLlxATb8rBMxuDVIppvzTaGsfqkN9pI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o8TxVYYJLovhn1bYP0bppqdQn35EJcczSduqWL6V4NiEenm/hQ8kIh3AiOkKfIyE9 ZcFiowMHLIhaiWWlDrknRk7hpxGIU4PDsMNbBdlTvvn+HMpL+EM9QBbfuucUWqA6xA nN62mouD8cp6b3EHgFVpuXPOBAddLd8REsd9aY+Y4EmIMbMFeGfWqNcEimf86GBdST S6Mgo/yXbYesJv9jT2LYGohrHMpl9JP5jpUQM1zFCP9idUSDZG0twMt81IJ6yoxkr/ ITGiOU6M7xAeO8VYhBQ/Im1F5M1NwewE1skeamSeqWILVyw6A0aTGI15mn9Llkg82H rJ0F1lT0DQagw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qEAbM-00049C-FM; Tue, 27 Jun 2023 17:27:33 +0200 Date: Tue, 27 Jun 2023 17:27:32 +0200 From: Johan Hovold To: Manivannan Sadhasivam Cc: Johan Hovold , Bjorn Andersson , Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Patrick Wildt Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp-pmics: add explicit rtc interrupt parent Message-ID: References: <20230627085306.6033-1-johan+linaro@kernel.org> <20230627132406.GA5490@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230627132406.GA5490@thinkpad> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jun 27, 2023 at 06:54:06PM +0530, Manivannan Sadhasivam wrote: > On Tue, Jun 27, 2023 at 10:53:06AM +0200, Johan Hovold wrote: > > Unless explicitly specified the interrupt-parent property is inherited > > from the parent node on Linux even though this may not be in full > > compliance with the devicetree specification. > > > > Following commit 2d5cab9232ba ("arm64: dts: qcom: sc8280xp-pmics: > > Specify interrupt parent explicitly"), add an explicit interrupt parent > > also for the PMIC RTC node for the benefit of other operating systems > > which may be confused by this omission. > > > > Note that any such OS must still implement a fallback to the root > > interrupt domain as most devicetrees are written under the assumption > > that the interrupt parent is inherited. > > > > Reported-by: Patrick Wildt > > Signed-off-by: Johan Hovold > > It is good to encode this in the binding and fix other such instances. Not sure about that. Perhaps the spec should be updated to match reality instead... We have many more instances like this, even for this very SoC, but apparently OpenBSD or whatever OS needs this falls back to the root domain then. Changing this for the rtc node for consistency after you changed the others is a no-brainer, but not sure about trying to do this tree-wide. We already have too many of these one-line DT cleanups... Johan