From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43C59EB64DD for ; Mon, 3 Jul 2023 09:38:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229989AbjGCJiU (ORCPT ); Mon, 3 Jul 2023 05:38:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229981AbjGCJiT (ORCPT ); Mon, 3 Jul 2023 05:38:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0293E12E; Mon, 3 Jul 2023 02:38:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 82B0A60E9A; Mon, 3 Jul 2023 09:38:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC5ECC433C7; Mon, 3 Jul 2023 09:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688377097; bh=vvCvcdLVaW5HY77zDNvNSDkUf9oON5WYhBfmOhVV2LE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FKhjPU9wi0gYdL0JGtCjyCrRK2viaJ1J6DZDySjWrJDHKj/cUz/VJmer7uBKGE5nV nXaDct9eOrdbkzJhqR28P85tkmHgFixtnsBVdN65ywUBPbrCMCpNRYNase4XPham42 ORxneKGlelLynOuyzsWnmATUtwWMknBzm9dTtAUE1nGjIQ5We53lhQQ4/97s1pdtJe ccv4Zp1xU/2DuhOETOgReykTUThNiTGEGAlUoq2ZAIbKowFqPO5mep27tvwlAqFAp/ FcOgGeY2OgrVXp2JmaYVpoPR0SfGiXon5R9IcgfkBnwbieOY29QJXiFTmxq2S8V9fV xykboCtXpZcRA== Received: from johan by xi.lan with local (Exim 4.96) (envelope-from ) id 1qGG0u-0006cO-1C; Mon, 03 Jul 2023 11:38:32 +0200 Date: Mon, 3 Jul 2023 11:38:32 +0200 From: Johan Hovold To: Konrad Dybcio Cc: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] arm64: dts: qcom: minor whitespace cleanup around '=' Message-ID: References: <20230702185051.43867-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jul 03, 2023 at 11:30:24AM +0200, Konrad Dybcio wrote: > On 2.07.2023 20:50, Krzysztof Kozlowski wrote: > > The DTS code coding style expects exactly one space before and after '=' > > sign. > > > > Signed-off-by: Krzysztof Kozlowski > > --- [...] > > diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi > > index 895cafc11480..c4209e2d4b4e 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi > > @@ -155,7 +155,7 @@ CPU7: cpu@3 { > > > > idle-states { > > CPU_SLEEP_0: cpu-sleep-0 { > > - compatible ="qcom,idle-state-spc", "arm,idle-state"; > > + compatible = "qcom,idle-state-spc", "arm,idle-state"; > Will conflict with: > > https://lore.kernel.org/linux-arm-msm/20230627-topic-more_bindings-v1-2-6b4b6cd081e5@linaro.org/ > > there are also a couple of entries with property =\n\t{n}[a-z] > > Otherwise lgtm Konrad, please remember to trim irrelevant context from your replies (e.g. so that we don't have to skim through thousands of lines to find a single comment). Johan