From: Thierry Reding <thierry.reding@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jon Hunter <jonathanh@nvidia.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/7] dt-bindings: arm: tegra: pmc: Improve property descriptions
Date: Mon, 10 Jul 2023 15:19:14 +0200 [thread overview]
Message-ID: <ZKwFUupH_GZoGrKm@orome> (raw)
In-Reply-To: <20230707222941.GA1083838-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]
On Fri, Jul 07, 2023 at 04:29:41PM -0600, Rob Herring wrote:
> On Fri, Jul 07, 2023 at 03:17:05PM +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Reformat the description of various properties to make them more
> > consistent with existing ones. Make use of json-schema's ability to
> > provide a description for individual list items to make improve the
> > documentation further.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > .../arm/tegra/nvidia,tegra20-pmc.yaml | 215 +++++++++---------
> > 1 file changed, 104 insertions(+), 111 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.yaml b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.yaml
> > index 89191cfdf619..a90f01678775 100644
> > --- a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.yaml
> > +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.yaml
> > @@ -21,17 +21,14 @@ properties:
> >
> > reg:
> > maxItems: 1
> > - description:
> > - Offset and length of the register set for the device.
> > + description: Offset and length of the register set for the device.
>
> nit: I'd add this to patch 2.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Indeed, makes sense.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-07-10 13:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 13:17 [PATCH 1/7] dt-bindings: arm: tegra: pmc: Improve property descriptions Thierry Reding
2023-07-07 13:17 ` [PATCH 2/7] dt-bindings: arm: tegra: pmc: Remove useless boilerplate descriptions Thierry Reding
2023-07-07 22:30 ` Rob Herring
2023-07-07 13:17 ` [PATCH 3/7] dt-bindings: arm: tegra: pmc: Move additionalProperties Thierry Reding
2023-07-07 22:30 ` Rob Herring
2023-07-07 13:17 ` [PATCH 4/7] dt-bindings: arm: tegra: pmc: Increase maximum number of clocks per powergate Thierry Reding
2023-07-07 22:31 ` Rob Herring
2023-07-07 13:17 ` [PATCH 5/7] dt-bindings: arm: tegra: pmc: Restructure pad configuration node schema Thierry Reding
2023-07-07 22:35 ` Rob Herring
2023-07-10 13:57 ` Thierry Reding
2023-07-14 15:12 ` Thierry Reding
2023-07-07 13:17 ` [PATCH 6/7] dt-bindings: arm: tegra: pmc: Reformat example Thierry Reding
2023-07-07 22:35 ` Rob Herring
2023-07-07 13:17 ` [PATCH 7/7] dt-bindings: arm: tegra: pmc: Relicense and move into soc/tegra directory Thierry Reding
2023-07-07 22:35 ` Rob Herring
2023-07-07 22:29 ` [PATCH 1/7] dt-bindings: arm: tegra: pmc: Improve property descriptions Rob Herring
2023-07-10 13:19 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKwFUupH_GZoGrKm@orome \
--to=thierry.reding@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).