From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09608C001B0 for ; Mon, 10 Jul 2023 15:54:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232901AbjGJPy2 (ORCPT ); Mon, 10 Jul 2023 11:54:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232755AbjGJPy0 (ORCPT ); Mon, 10 Jul 2023 11:54:26 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9A611A7 for ; Mon, 10 Jul 2023 08:54:02 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-666e64e97e2so2323769b3a.1 for ; Mon, 10 Jul 2023 08:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689004442; x=1691596442; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zMSW+hTxoeJnUQYqOp6d0h2caQRlX9Av8EhOOGVFTdk=; b=j5bN/2rGOIVOFWr6X1GxmlgVr6bzZ0LPBAVI7aDzgir9DCNfZrW1F/SVJgVyq3Rn4Q NDm7p30jKHaWDprDZ+XFmDVuiwsyT1xpW8VI4hyFR5rmOeghNtvx4wRYJD52vImzvUx7 75UmCw8cDp9xCXA2h/bYLZR6WzWHJizYT+colT6IneOP+DatYucsm2TRwuUvv7UEBA1D y4xdA6EjDACtLy0jeSsV23qoqRh5VDo+HsgNbz7ztXFJSg3JoFsaWVy3jYyEcSP9kCzA z4FnEDysqwdH4JzoJ9GoImIJ3yhdKyFIbyFL8wafIPpkg7xrhK5ZLWsQ+PAyT3M8BnnU sekw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689004442; x=1691596442; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zMSW+hTxoeJnUQYqOp6d0h2caQRlX9Av8EhOOGVFTdk=; b=KFyHC0okS785EevkEd5co0FR8YR7hPtDr9AizALqM1KrlL4BYECVqbdzxaexjoATxa VdXqN4vL0cm6mmzIsk2/OvjdgWaLIAne/ZYE1bNHpSsdBqd5Z36I/gYrHO/LZTJczFXO A+2Srv7YGiDsPhuzMa38pw2Qu9KGfKuytX173UgAP+zvmQQLTh9gi/WQrw1kuI1Q/HNW OV8ivz850weOyoXo3s4wx4gFU8WwF2IlWLyyXrhodohwCGHQq5+YBx2QVxbyewEVXW78 ucM0sGFRJT8kY/85a4kLsaTD9qUASToM8dYgVArvQtGSqM60xN5jv4Ij75P2Sby2V/9v cRgQ== X-Gm-Message-State: ABy/qLY2a0VbfGlBog2dEJXfnqMaz2AWxrJ5N8u7UeFexDSS4JJFa3Qo vSJnGFPhwVNry0fLHuxgUbxh9g== X-Google-Smtp-Source: APBJJlG9Kvh6R1bq3ZlIOnrsRa803tXNfyhlL8ge26rigJUw8qNHealMTt6slSq+7Yq3p7tL2TFJlg== X-Received: by 2002:a05:6a20:9188:b0:122:cb38:637c with SMTP id v8-20020a056a20918800b00122cb38637cmr12807361pzd.49.1689004442259; Mon, 10 Jul 2023 08:54:02 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:a799:9acc:26b9:1451]) by smtp.gmail.com with ESMTPSA id bg4-20020a1709028e8400b001b53be3d942sm49863plb.232.2023.07.10.08.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 08:54:01 -0700 (PDT) Date: Mon, 10 Jul 2023 09:53:59 -0600 From: Mathieu Poirier To: Marek Vasut Cc: linux-remoteproc@vger.kernel.org, Peng Fan , Jacky Bai , Ye Li , Bjorn Andersson , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , NXP Linux Team , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] remoteproc: imx_rproc: add start up delay Message-ID: References: <20230707232444.374431-1-marex@denx.de> <20230707232444.374431-2-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230707232444.374431-2-marex@denx.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Jul 08, 2023 at 01:24:44AM +0200, Marek Vasut wrote: > From: Peng Fan > > There is case that after remoteproc start remote processor[M4], the M4 > runs slow and before M4 finish its own rpmsg framework initialization, > linux sends out vring kick message, then M4 firmware drops the kick > message. Some NXP released Cortex-M[x] images has such limitation that > it requires linux sends out vring kick message after M4 firmware finish > its rpmsg framework initialization. > > Reviewed-by: Jacky Bai > Reviewed-by: Ye Li > Signed-off-by: Peng Fan > --- > Note: picked from NXP downstream LF-6630-2 remoteproc: imx_rproc: add start up delay > https://github.com/nxp-imx/linux-imx.git 0b1b91c95b291a3b60d6224b13f6a95a75896abf > --- > Note: Literally all of the NXP BSP 2.13.0 firmware builds fail to boot > without this being set to something like 50..500 ms , so this is > rather useful to have. My stance on this hasn't changed - hacks such as these do not scale and are a nightmare to maintain. The problem should be fixed in the M4's firmware. > --- > Cc: Bjorn Andersson > Cc: Conor Dooley > Cc: Fabio Estevam > Cc: Krzysztof Kozlowski > Cc: Mathieu Poirier > Cc: NXP Linux Team > Cc: Peng Fan > Cc: Pengutronix Kernel Team > Cc: Rob Herring > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-remoteproc@vger.kernel.org > --- > drivers/remoteproc/imx_rproc.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index f9874fc5a80ff..d0eb96d6a4fe1 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -110,6 +111,7 @@ struct imx_rproc { > u32 core_index; > struct device **pd_dev; > struct device_link **pd_dev_link; > + u32 startup_delay; > }; > > static const struct imx_rproc_att imx_rproc_att_imx93[] = { > @@ -382,6 +384,9 @@ static int imx_rproc_start(struct rproc *rproc) > if (ret) > dev_err(dev, "Failed to enable remote core!\n"); > > + if (priv->startup_delay) > + msleep(priv->startup_delay); > + > return ret; > } > > @@ -1090,6 +1095,10 @@ static int imx_rproc_probe(struct platform_device *pdev) > if (rproc->state != RPROC_DETACHED) > rproc->auto_boot = of_property_read_bool(np, "fsl,auto-boot"); > > + ret = of_property_read_u32(dev->of_node, "fsl,startup-delay-ms", &priv->startup_delay); > + if (ret) > + priv->startup_delay = 0; > + > ret = rproc_add(rproc); > if (ret) { > dev_err(dev, "rproc_add failed\n"); > -- > 2.40.1 >