From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7D60C001DC for ; Sat, 15 Jul 2023 16:12:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229483AbjGOQMh (ORCPT ); Sat, 15 Jul 2023 12:12:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjGOQMg (ORCPT ); Sat, 15 Jul 2023 12:12:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 730B62D51 for ; Sat, 15 Jul 2023 09:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689437510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Js70kE6M4tQuHcgETIy8XYzF63AeuA3GvQidoiOZKq8=; b=DdRurhm/yiydoX4ioYtZBcbkIg9ebeX3qhnCaWP74Ze/RpgyUIHq1AFxUR8c+4+eq28oY9 uDuNDwIIpJeBo+FEHGNsslWCs69zqKz0R2HSyr8OJuqtVTK1HYAFEnDWpgEULGc2+lt33a Igvzf1RvPpbqWmAu4YQqwq1UlphqPPA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-549-fVD93zk4OFqK8BYvaHGwew-1; Sat, 15 Jul 2023 12:11:48 -0400 X-MC-Unique: fVD93zk4OFqK8BYvaHGwew-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fa8db49267so14994535e9.3 for ; Sat, 15 Jul 2023 09:11:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689437508; x=1692029508; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Js70kE6M4tQuHcgETIy8XYzF63AeuA3GvQidoiOZKq8=; b=UwQC0siaZNmbyHB3s6kdiuVetXc5kOI1BdbUeHGWA19AT29Dmn9PJVRr5rCR/CDKHh kLXj6UnX1PKK1H+b08SnQ3C13zGnKfqGZrBzSR2tHrVLoXylnbB8xV1yt1JPi1fmbZKj jiyy2z173bgpaSXFhtpWtO4N18FV5Qj3U6XW4iy5sda1PhK/gcrOB+S1jTWZmBfvmoK6 EEV1E6/x0JKn58IAZ6DSDGY00+bXXG/4doDtf/46OrizlrM+XLHzLX1joqtxEtQ1K6Gf p3nCvQf1TmAt+EA7kF4OhW7nVs5+pHxykX8AaNC7hUQ/JSK3bvmAORfygQ2pOti95oXl 2AfA== X-Gm-Message-State: ABy/qLZdkaH9BMyrLu9C81kJ+b3MTa6JsilKUF93Pk8IaoU6HL5sIVXj n8RB1wJsBIuMXtYa2PI4qA+pi6JN8OKKiiPH8+qa9nISO8ZrIB8KheSX7aaDf68XnIi+AkmnLHu 72qQLfzOO7exCapPKwC7SgA== X-Received: by 2002:a7b:c40d:0:b0:3fc:1a6:7764 with SMTP id k13-20020a7bc40d000000b003fc01a67764mr6353259wmi.16.1689437507834; Sat, 15 Jul 2023 09:11:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlG69QqpP0KlK6PdSqxWvSyyuu5NRgXyRxSUWxITz0TGdie9WxsU5U+VqP/uxSgCoNT0EjL9WQ== X-Received: by 2002:a7b:c40d:0:b0:3fc:1a6:7764 with SMTP id k13-20020a7bc40d000000b003fc01a67764mr6353234wmi.16.1689437507258; Sat, 15 Jul 2023 09:11:47 -0700 (PDT) Received: from localhost (net-130-25-106-149.cust.vodafonedsl.it. [130.25.106.149]) by smtp.gmail.com with ESMTPSA id y6-20020a1c4b06000000b003fc3b03e631sm3602905wma.1.2023.07.15.09.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jul 2023 09:11:46 -0700 (PDT) Date: Sat, 15 Jul 2023 18:11:44 +0200 From: Lorenzo Bianconi To: "Russell King (Oracle)" Cc: Daniel Golle , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , =?iso-8859-1?Q?Bj=F8rn?= Mork , Florian Fainelli , Greg Ungerer Subject: Re: [PATCH v2 net-next 6/9] net: ethernet: mtk_eth_soc: add MTK_NETSYS_V3 capability bit Message-ID: References: <6dc1e0ad7e8138835c959fc83a6c1564e8488c59.1689012506.git.daniel@makrotopia.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Eh7tZsXyDFZVqJbt" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --Eh7tZsXyDFZVqJbt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > on thu, jul 13, 2023 at 03:19:49am +0100, daniel golle wrote: > > + > > + if (mtk_has_caps(eth->soc->caps, mtk_netsys_v3)) { >=20 > this is a case in point for one of my previous comments... >=20 > this code started out believing that testing for mtk_netsys_v2 for v2 > features would be sufficient. your first patch ended up having to > change that to !v1. how long until this becomes !v1 && !v2 because > it gets used on v3 and v4 etc? >=20 > this is why i think an integer version field would be a much saner > approach. ack, I will fix it. Regards, Lorenzo >=20 > --=20 > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! >=20 --Eh7tZsXyDFZVqJbt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZLLFQAAKCRA6cBh0uS2t rGs9AP49MdY//QxPjTry+O5HMEDUJz0xScmT7VFDAbt7wb7HwwEAn0Yz8q6MfSkC djHk8lPoM7OXLyH5gZ4UFWEqt305dgI= =nLva -----END PGP SIGNATURE----- --Eh7tZsXyDFZVqJbt--