* Re: [PATCH] pwm: Explicitly include correct DT includes
2023-07-14 17:48 [PATCH] pwm: Explicitly include correct DT includes Rob Herring
@ 2023-07-17 4:01 ` Tzung-Bi Shih
2023-07-17 7:43 ` Uwe Kleine-König
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Tzung-Bi Shih @ 2023-07-17 4:01 UTC (permalink / raw)
To: Rob Herring
Cc: Thierry Reding, Uwe Kleine-König, Hector Martin, Sven Peter,
Alyssa Rosenzweig, Nicolas Ferre, Alexandre Belloni,
Claudiu Beznea, Benson Leung, Guenter Roeck, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Paul Cercueil, Vladimir Zapolskiy, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl, Conor Dooley,
Daire McNamara, Matthias Brugger, AngeloGioacchino Del Regno,
Palmer Dabbelt, Paul Walmsley, Michael Walle, Orson Zhai,
Baolin Wang, Chunyan Zhang, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, Hammer Hsieh, Jonathan Hunter, Nobuhiro Iwamatsu,
devicetree, linux-pwm, linux-kernel, asahi, linux-arm-kernel,
chrome-platform, linux-mips, linux-amlogic, linux-riscv,
linux-mediatek, linux-sunxi, linux-tegra
On Fri, Jul 14, 2023 at 11:48:50AM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
For pwm-cros-ec.c:
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] pwm: Explicitly include correct DT includes
2023-07-14 17:48 [PATCH] pwm: Explicitly include correct DT includes Rob Herring
2023-07-17 4:01 ` Tzung-Bi Shih
@ 2023-07-17 7:43 ` Uwe Kleine-König
2023-07-17 15:59 ` Rob Herring
2023-07-17 22:39 ` nobuhiro1.iwamatsu
` (3 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: Uwe Kleine-König @ 2023-07-17 7:43 UTC (permalink / raw)
To: Rob Herring
Cc: Thierry Reding, Hector Martin, Sven Peter, Alyssa Rosenzweig,
Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, Benson Leung,
Guenter Roeck, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Paul Cercueil, Vladimir Zapolskiy,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Conor Dooley, Daire McNamara, Matthias Brugger,
AngeloGioacchino Del Regno, Palmer Dabbelt, Paul Walmsley,
Michael Walle, Orson Zhai, Baolin Wang, Chunyan Zhang,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Hammer Hsieh,
Jonathan Hunter, Nobuhiro Iwamatsu, chrome-platform, devicetree,
linux-kernel, linux-pwm, linux-mips, linux-mediatek, asahi,
linux-tegra, linux-amlogic, linux-riscv, linux-sunxi,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 4184 bytes --]
On Fri, Jul 14, 2023 at 11:48:50AM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
so the eventual goal here is to prepare for:
- drop #include <linux/of_device.h> from include/linux/of_platform.h
- drop #include <linux/of.h> from include/linux/of_device.h
- drop #include <linux/of_platform.h> from include/linux/of_device.h
- drop #include <linux/platform_device.h> from include/linux/of_device.h
- drop #include <linux/platform_device.h> from include/linux/of_platform.h
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/pwm/core.c | 1 +
> drivers/pwm/pwm-apple.c | 1 +
> drivers/pwm/pwm-atmel-hlcdc.c | 1 +
> drivers/pwm/pwm-atmel-tcb.c | 3 +--
> drivers/pwm/pwm-atmel.c | 1 -
> drivers/pwm/pwm-berlin.c | 1 +
> drivers/pwm/pwm-cros-ec.c | 1 +
> drivers/pwm/pwm-fsl-ftm.c | 3 +--
> drivers/pwm/pwm-hibvt.c | 2 +-
> drivers/pwm/pwm-imx1.c | 1 -
> drivers/pwm/pwm-jz4740.c | 2 +-
> drivers/pwm/pwm-lp3943.c | 1 +
> drivers/pwm/pwm-lpc18xx-sct.c | 1 +
> drivers/pwm/pwm-mediatek.c | 1 -
> drivers/pwm/pwm-meson.c | 1 -
> drivers/pwm/pwm-microchip-core.c | 2 +-
> drivers/pwm/pwm-mtk-disp.c | 1 -
> drivers/pwm/pwm-pxa.c | 1 +
> drivers/pwm/pwm-sifive.c | 1 +
> drivers/pwm/pwm-sl28cpld.c | 1 +
> drivers/pwm/pwm-sprd.c | 1 +
> drivers/pwm/pwm-sun4i.c | 1 -
> drivers/pwm/pwm-sunplus.c | 1 +
> drivers/pwm/pwm-tegra.c | 1 -
> drivers/pwm/pwm-tiecap.c | 2 +-
> drivers/pwm/pwm-tiehrpwm.c | 2 +-
> drivers/pwm/pwm-visconti.c | 2 +-
> drivers/pwm/pwm-vt8500.c | 5 +----
> 28 files changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> index 3dacceaef4a9..d37617c60eae 100644
> --- a/drivers/pwm/core.c
> +++ b/drivers/pwm/core.c
> @@ -8,6 +8,7 @@
>
> #include <linux/acpi.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/pwm.h>
> #include <linux/radix-tree.h>
> #include <linux/list.h>
This file includes neither of_device.h nor of_platform.h and up to now
gets of.h via <linux/pwm.h>.
What is your plan for <linux/pwm.h>'s include? I think it would only need
struct of_phandle_args;
to replace that. (But that would need another patch like this one, as
then e.g. drivers/pwm/pwm-sl28cpld.c fails to compile because
device_property_read_u32() is undeclared. It would need to #include
<linux/property.h> which now it gets transitively via <linux/of.h>.)
If <linux/pwm.h> is planed to continue #including <linux/of.h>, the
explicit include here isn't necessary (and probably elsewhere).
I don't care much either way, but maybe your quest would be a bit
simpler if you only touch files that include the two files you want to
modify?
*shrug*, this patch is still an improvement so:
Acked-by: Uwe Kleine-Köng <u.kleine-koenig@pengutronix.de>
Another thing I wonder is: How did you identify the files that need
these includes. I guess you have a list of types for each header and
search for files that use any of the types but doesn't include the
respecitve header? I wonder if tracking this type -> header mapping in
machine readable form somewhere would be nice, to e.g. make checkpatch
warn if a file uses struct of_node but only gets it by chance?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] pwm: Explicitly include correct DT includes
2023-07-17 7:43 ` Uwe Kleine-König
@ 2023-07-17 15:59 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2023-07-17 15:59 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Thierry Reding, Hector Martin, Sven Peter, Alyssa Rosenzweig,
Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, Benson Leung,
Guenter Roeck, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Paul Cercueil, Vladimir Zapolskiy,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Conor Dooley, Daire McNamara, Matthias Brugger,
AngeloGioacchino Del Regno, Palmer Dabbelt, Paul Walmsley,
Michael Walle, Orson Zhai, Baolin Wang, Chunyan Zhang,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Hammer Hsieh,
Jonathan Hunter, Nobuhiro Iwamatsu, chrome-platform, devicetree,
linux-kernel, linux-pwm, linux-mips, linux-mediatek, asahi,
linux-tegra, linux-amlogic, linux-riscv, linux-sunxi,
linux-arm-kernel
On Mon, Jul 17, 2023 at 1:44 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> On Fri, Jul 14, 2023 at 11:48:50AM -0600, Rob Herring wrote:
> > The DT of_device.h and of_platform.h date back to the separate
> > of_platform_bus_type before it as merged into the regular platform bus.
> > As part of that merge prepping Arm DT support 13 years ago, they
> > "temporarily" include each other. They also include platform_device.h
> > and of.h. As a result, there's a pretty much random mix of those include
> > files used throughout the tree. In order to detangle these headers and
> > replace the implicit includes with struct declarations, users need to
> > explicitly include the correct includes.
>
> so the eventual goal here is to prepare for:
>
> - drop #include <linux/of_device.h> from include/linux/of_platform.h
> - drop #include <linux/of.h> from include/linux/of_device.h
> - drop #include <linux/of_platform.h> from include/linux/of_device.h
> - drop #include <linux/platform_device.h> from include/linux/of_device.h
> - drop #include <linux/platform_device.h> from include/linux/of_platform.h
Yes.
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > drivers/pwm/core.c | 1 +
> > drivers/pwm/pwm-apple.c | 1 +
> > drivers/pwm/pwm-atmel-hlcdc.c | 1 +
> > drivers/pwm/pwm-atmel-tcb.c | 3 +--
> > drivers/pwm/pwm-atmel.c | 1 -
> > drivers/pwm/pwm-berlin.c | 1 +
> > drivers/pwm/pwm-cros-ec.c | 1 +
> > drivers/pwm/pwm-fsl-ftm.c | 3 +--
> > drivers/pwm/pwm-hibvt.c | 2 +-
> > drivers/pwm/pwm-imx1.c | 1 -
> > drivers/pwm/pwm-jz4740.c | 2 +-
> > drivers/pwm/pwm-lp3943.c | 1 +
> > drivers/pwm/pwm-lpc18xx-sct.c | 1 +
> > drivers/pwm/pwm-mediatek.c | 1 -
> > drivers/pwm/pwm-meson.c | 1 -
> > drivers/pwm/pwm-microchip-core.c | 2 +-
> > drivers/pwm/pwm-mtk-disp.c | 1 -
> > drivers/pwm/pwm-pxa.c | 1 +
> > drivers/pwm/pwm-sifive.c | 1 +
> > drivers/pwm/pwm-sl28cpld.c | 1 +
> > drivers/pwm/pwm-sprd.c | 1 +
> > drivers/pwm/pwm-sun4i.c | 1 -
> > drivers/pwm/pwm-sunplus.c | 1 +
> > drivers/pwm/pwm-tegra.c | 1 -
> > drivers/pwm/pwm-tiecap.c | 2 +-
> > drivers/pwm/pwm-tiehrpwm.c | 2 +-
> > drivers/pwm/pwm-visconti.c | 2 +-
> > drivers/pwm/pwm-vt8500.c | 5 +----
> > 28 files changed, 21 insertions(+), 21 deletions(-)
> >
> > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> > index 3dacceaef4a9..d37617c60eae 100644
> > --- a/drivers/pwm/core.c
> > +++ b/drivers/pwm/core.c
> > @@ -8,6 +8,7 @@
> >
> > #include <linux/acpi.h>
> > #include <linux/module.h>
> > +#include <linux/of.h>
> > #include <linux/pwm.h>
> > #include <linux/radix-tree.h>
> > #include <linux/list.h>
>
> This file includes neither of_device.h nor of_platform.h and up to now
> gets of.h via <linux/pwm.h>.
Indeed.
> What is your plan for <linux/pwm.h>'s include? I think it would only need
>
> struct of_phandle_args;
Here's what I'm testing with:
diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index 04ae1d9073a7..5a59a7d53be8 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -4,8 +4,10 @@
#include <linux/err.h>
#include <linux/mutex.h>
-#include <linux/of.h>
+struct device;
+struct fwnode_handle;
+struct of_phandle_args;
struct pwm_chip;
/**
>
> to replace that. (But that would need another patch like this one, as
> then e.g. drivers/pwm/pwm-sl28cpld.c fails to compile because
> device_property_read_u32() is undeclared. It would need to #include
> <linux/property.h> which now it gets transitively via <linux/of.h>.)
property.h is added in this patch, so it should be okay?
> If <linux/pwm.h> is planed to continue #including <linux/of.h>, the
> explicit include here isn't necessary (and probably elsewhere).
I would like to drop including of.h, but probably not this cycle.
Either way, I thought kernel best practice was to not rely on implicit
includes.
BTW, linux/i2c.h is another source of lots of implicit of.h includes.
That one looks like we can't get rid of.
> I don't care much either way, but maybe your quest would be a bit
> simpler if you only touch files that include the two files you want to
> modify?
Yes, that's how it started. I kind of decided it wasn't worth trying
to split things up by every separate reason explicit includes were not
correct.
>
> *shrug*, this patch is still an improvement so:
>
> Acked-by: Uwe Kleine-Köng <u.kleine-koenig@pengutronix.de>
>
> Another thing I wonder is: How did you identify the files that need
> these includes. I guess you have a list of types for each header and
> search for files that use any of the types but doesn't include the
> respecitve header? I wonder if tracking this type -> header mapping in
> machine readable form somewhere would be nice, to e.g. make checkpatch
> warn if a file uses struct of_node but only gets it by chance?
It's been less automated than I'd like. It's been a lot of grepping
with a list of symbols the headers provide. For example, I get all the
files including of_device.h and then get the ones with no symbols from
of_device.h. And then do a manual review of what are the correct
headers for the file. And then run thru builds and fix all the issues.
Rob
^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH] pwm: Explicitly include correct DT includes
2023-07-14 17:48 [PATCH] pwm: Explicitly include correct DT includes Rob Herring
2023-07-17 4:01 ` Tzung-Bi Shih
2023-07-17 7:43 ` Uwe Kleine-König
@ 2023-07-17 22:39 ` nobuhiro1.iwamatsu
2023-07-20 14:41 ` Thierry Reding
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: nobuhiro1.iwamatsu @ 2023-07-17 22:39 UTC (permalink / raw)
To: robh, thierry.reding, u.kleine-koenig, marcan, sven, alyssa,
nicolas.ferre, alexandre.belloni, claudiu.beznea, bleung, groeck,
shawnguo, s.hauer, kernel, festevam, linux-imx, paul, vz,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
conor.dooley, daire.mcnamara, matthias.bgg,
angelogioacchino.delregno, palmer, paul.walmsley, michael,
orsonzhai, baolin.wang, zhang.lyra, wens, jernej.skrabec, samuel,
hammerh0314, jonathanh
Cc: devicetree, linux-pwm, linux-kernel, asahi, linux-arm-kernel,
chrome-platform, linux-mips, linux-amlogic, linux-riscv,
linux-mediatek, linux-sunxi, linux-tegra
Hi,
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Saturday, July 15, 2023 2:49 AM
> To: Thierry Reding <thierry.reding@gmail.com>; Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de>; Hector Martin <marcan@marcan.st>;
> Sven Peter <sven@svenpeter.dev>; Alyssa Rosenzweig
> <alyssa@rosenzweig.io>; Nicolas Ferre <nicolas.ferre@microchip.com>;
> Alexandre Belloni <alexandre.belloni@bootlin.com>; Claudiu Beznea
> <claudiu.beznea@microchip.com>; Benson Leung <bleung@chromium.org>;
> Guenter Roeck <groeck@chromium.org>; Shawn Guo
> <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> Pengutronix Kernel Team <kernel@pengutronix.de>; Fabio Estevam
> <festevam@gmail.com>; NXP Linux Team <linux-imx@nxp.com>; Paul
> Cercueil <paul@crapouillou.net>; Vladimir Zapolskiy <vz@mleia.com>; Neil
> Armstrong <neil.armstrong@linaro.org>; Kevin Hilman
> <khilman@baylibre.com>; Jerome Brunet <jbrunet@baylibre.com>; Martin
> Blumenstingl <martin.blumenstingl@googlemail.com>; Conor Dooley
> <conor.dooley@microchip.com>; Daire McNamara
> <daire.mcnamara@microchip.com>; Matthias Brugger
> <matthias.bgg@gmail.com>; AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com>; Palmer Dabbelt
> <palmer@dabbelt.com>; Paul Walmsley <paul.walmsley@sifive.com>;
> Michael Walle <michael@walle.cc>; Orson Zhai <orsonzhai@gmail.com>;
> Baolin Wang <baolin.wang@linux.alibaba.com>; Chunyan Zhang
> <zhang.lyra@gmail.com>; Chen-Yu Tsai <wens@csie.org>; Jernej Skrabec
> <jernej.skrabec@gmail.com>; Samuel Holland <samuel@sholland.org>;
> Hammer Hsieh <hammerh0314@gmail.com>; Jonathan Hunter
> <jonathanh@nvidia.com>; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ
> ○ＯＳＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>
> Cc: devicetree@vger.kernel.org; linux-pwm@vger.kernel.org;
> linux-kernel@vger.kernel.org; asahi@lists.linux.dev;
> linux-arm-kernel@lists.infradead.org; chrome-platform@lists.linux.dev;
> linux-mips@vger.kernel.org; linux-amlogic@lists.infradead.org;
> linux-riscv@lists.infradead.org; linux-mediatek@lists.infradead.org;
> linux-sunxi@lists.linux.dev; linux-tegra@vger.kernel.org
> Subject: [PATCH] pwm: Explicitly include correct DT includes
>
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they "temporarily"
> include each other. They also include platform_device.h and of.h. As a result,
> there's a pretty much random mix of those include files used throughout the
> tree. In order to detangle these headers and replace the implicit includes with
> struct declarations, users need to explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
For drivers/pwm/pwm-visconti.c:
Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Best regards,
Nobuhiro
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] pwm: Explicitly include correct DT includes
2023-07-14 17:48 [PATCH] pwm: Explicitly include correct DT includes Rob Herring
` (2 preceding siblings ...)
2023-07-17 22:39 ` nobuhiro1.iwamatsu
@ 2023-07-20 14:41 ` Thierry Reding
2023-09-11 4:31 ` patchwork-bot+chrome-platform
2023-09-11 4:49 ` patchwork-bot+chrome-platform
5 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2023-07-20 14:41 UTC (permalink / raw)
To: Uwe Kleine-König, Hector Martin, Sven Peter,
Alyssa Rosenzweig, Nicolas Ferre, Alexandre Belloni,
Claudiu Beznea, Benson Leung, Guenter Roeck, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Paul Cercueil, Vladimir Zapolskiy, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl, Conor Dooley,
Daire McNamara, Matthias Brugger, AngeloGioacchino Del Regno,
Palmer Dabbelt, Paul Walmsley, Michael Walle, Orson Zhai,
Baolin Wang, Chunyan Zhang, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, Hammer Hsieh, Jonathan Hunter, Nobuhiro Iwamatsu,
Rob Herring
Cc: devicetree, linux-pwm, linux-kernel, asahi, linux-arm-kernel,
chrome-platform, linux-mips, linux-amlogic, linux-riscv,
linux-mediatek, linux-sunxi, linux-tegra
On Fri, 14 Jul 2023 11:48:50 -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> [...]
Applied, thanks!
[1/1] pwm: Explicitly include correct DT includes
commit: 8d171282110fcde89bb4289c4010a15aca5cec95
Best regards,
--
Thierry Reding <thierry.reding@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] pwm: Explicitly include correct DT includes
2023-07-14 17:48 [PATCH] pwm: Explicitly include correct DT includes Rob Herring
` (3 preceding siblings ...)
2023-07-20 14:41 ` Thierry Reding
@ 2023-09-11 4:31 ` patchwork-bot+chrome-platform
2023-09-11 4:49 ` patchwork-bot+chrome-platform
5 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-09-11 4:31 UTC (permalink / raw)
To: Rob Herring
Cc: thierry.reding, u.kleine-koenig, marcan, sven, alyssa,
nicolas.ferre, alexandre.belloni, claudiu.beznea, bleung, groeck,
shawnguo, s.hauer, kernel, festevam, linux-imx, paul, vz,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
conor.dooley, daire.mcnamara, matthias.bgg,
angelogioacchino.delregno, palmer, paul.walmsley, michael,
orsonzhai, baolin.wang, zhang.lyra, wens, jernej.skrabec, samuel,
hammerh0314, jonathanh, nobuhiro1.iwamatsu, devicetree, linux-pwm,
linux-kernel, asahi, linux-arm-kernel, chrome-platform,
linux-mips, linux-amlogic, linux-riscv, linux-mediatek,
linux-sunxi, linux-tegra
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Thierry Reding <thierry.reding@gmail.com>:
On Fri, 14 Jul 2023 11:48:50 -0600 you wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> [...]
Here is the summary with links:
- pwm: Explicitly include correct DT includes
https://git.kernel.org/chrome-platform/c/0a41b0c5d97a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] pwm: Explicitly include correct DT includes
2023-07-14 17:48 [PATCH] pwm: Explicitly include correct DT includes Rob Herring
` (4 preceding siblings ...)
2023-09-11 4:31 ` patchwork-bot+chrome-platform
@ 2023-09-11 4:49 ` patchwork-bot+chrome-platform
5 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-09-11 4:49 UTC (permalink / raw)
To: Rob Herring
Cc: thierry.reding, u.kleine-koenig, marcan, sven, alyssa,
nicolas.ferre, alexandre.belloni, claudiu.beznea, bleung, groeck,
shawnguo, s.hauer, kernel, festevam, linux-imx, paul, vz,
neil.armstrong, khilman, jbrunet, martin.blumenstingl,
conor.dooley, daire.mcnamara, matthias.bgg,
angelogioacchino.delregno, palmer, paul.walmsley, michael,
orsonzhai, baolin.wang, zhang.lyra, wens, jernej.skrabec, samuel,
hammerh0314, jonathanh, nobuhiro1.iwamatsu, devicetree, linux-pwm,
linux-kernel, asahi, linux-arm-kernel, chrome-platform,
linux-mips, linux-amlogic, linux-riscv, linux-mediatek,
linux-sunxi, linux-tegra
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Thierry Reding <thierry.reding@gmail.com>:
On Fri, 14 Jul 2023 11:48:50 -0600 you wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> [...]
Here is the summary with links:
- pwm: Explicitly include correct DT includes
https://git.kernel.org/chrome-platform/c/0a41b0c5d97a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 8+ messages in thread