From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Artur Weber <aweber.kernel@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [RESEND PATCH 2/2] Input: mms114 - add support for touch keys
Date: Tue, 18 Jul 2023 23:22:26 -0700 [thread overview]
Message-ID: <ZLeBIma/CLcK++RF@google.com> (raw)
In-Reply-To: <20230714100424.29798-3-aweber.kernel@gmail.com>
On Fri, Jul 14, 2023 at 12:04:24PM +0200, Artur Weber wrote:
> + } else if (data->num_keycodes > MMS114_MAX_TOUCHKEYS) {
> + dev_warn(&client->dev,
> + "Found %d linux,keycodes but max is %zd, ignoring the rest\n",
> + data->num_keycodes, MMS114_MAX_TOUCHKEYS);
This gives me the following warning:
drivers/input/touchscreen/mms114.c: In function ‘mms114_probe’:
drivers/input/touchscreen/mms114.c:520:25: error: format ‘%zd’ expects argument of type ‘signed size_t’, but argument 4 has type ‘int’ [-Werror=format=]
520 | "Found %d linux,keycodes but max is %zd, ignoring the rest\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I changed the format specifier to "%d" and applied.
Thanks.
--
Dmitry
prev parent reply other threads:[~2023-07-19 6:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 10:04 [RESEND PATCH 0/2] mms114: add support for touch keys Artur Weber
2023-07-14 10:04 ` [RESEND PATCH 1/2] dt-bindings: mms114: Add linux,keycodes property " Artur Weber
2023-07-14 10:04 ` [RESEND PATCH 2/2] Input: mms114 - add support " Artur Weber
2023-07-19 6:22 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLeBIma/CLcK++RF@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=aweber.kernel@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).