[PATCH 1/4] arm64: dts: qcom: sc8180x-pmics: add missing qcom,spmi-gpio fallbacks

[PATCH 1/4] arm64: dts: qcom: sc8180x-pmics: add missing qcom,spmi-gpio fallbacks

[Krzysztof Kozlowski]

The GPIO children of PMICs should use qcom,spmi-gpio fallback:

  sc8180x-primus.dtb: pmic@0: gpio@c000:compatible: ['qcom,pmc8180-gpio'] is too short

Fixes: d3302290f59e ("arm64: dts: qcom: sc8180x: Add pmics")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
index 4556af6cd103..ef2f8b732833 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
@@ -142,7 +142,7 @@ rtc@6000 {
 		};
 
 		pmc8180_gpios: gpio@c000 {
-			compatible = "qcom,pmc8180-gpio";
+			compatible = "qcom,pmc8180-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
 			#gpio-cells = <2>;
@@ -300,7 +300,7 @@ pmc8180c_adc_tm: adc-tm@3500 {
 		};
 
 		pmc8180c_gpios: gpio@c000 {
-			compatible = "qcom,pmc8180c-gpio";
+			compatible = "qcom,pmc8180c-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
 			#gpio-cells = <2>;
-- 
2.34.1

[PATCH 2/4] arm64: dts: qcom: sc8180x-pmics: add missing gpio-ranges

[Krzysztof Kozlowski]

The GPIO children of PMICs should use gpio-ranges:

  sc8180x-primus.dtb: pmic@0: gpio@c000: 'gpio-ranges' is a required property

Fixes: d3302290f59e ("arm64: dts: qcom: sc8180x: Add pmics")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
index ef2f8b732833..53b283e29407 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
@@ -145,6 +145,7 @@ pmc8180_gpios: gpio@c000 {
 			compatible = "qcom,pmc8180-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
+			gpio-ranges = <&pmc8180_gpios 0 0 10>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
@@ -303,6 +304,7 @@ pmc8180c_gpios: gpio@c000 {
 			compatible = "qcom,pmc8180c-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
+			gpio-ranges = <&pmc8180c_gpios 0 0 12>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
-- 
2.34.1

Re: [PATCH 2/4] arm64: dts: qcom: sc8180x-pmics: add missing gpio-ranges

[Konrad Dybcio]

On 20.07.2023 10:34, Krzysztof Kozlowski wrote:
> The GPIO children of PMICs should use gpio-ranges:
> 
>   sc8180x-primus.dtb: pmic@0: gpio@c000: 'gpio-ranges' is a required property
> 
> Fixes: d3302290f59e ("arm64: dts: qcom: sc8180x: Add pmics")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH 2/4] arm64: dts: qcom: sc8180x-pmics: add missing gpio-ranges

[Vinod Koul]

On 20-07-23, 10:34, Krzysztof Kozlowski wrote:
> The GPIO children of PMICs should use gpio-ranges:
> 
>   sc8180x-primus.dtb: pmic@0: gpio@c000: 'gpio-ranges' is a required property

Reviewed-by: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod

[PATCH 3/4] arm64: dts: qcom: sc8180x-pmics: align SPMI PMIC Power-on node name with dtschema

[Krzysztof Kozlowski]

Bindings expect the Power-on node name to be "pon":

  sc8180x-lenovo-flex-5g.dtb: pmic@0: 'power-on@800' does not match any of the regexes:

Fixes: d3302290f59e ("arm64: dts: qcom: sc8180x: Add pmics")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
index 53b283e29407..bc17d22dbefc 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
@@ -74,7 +74,7 @@ pmc8180_0: pmic@0 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		pon: power-on@800 {
+		pon: pon@800 {
 			compatible = "qcom,pm8916-pon";
 			reg = <0x0800>;
 			pwrkey {
@@ -247,7 +247,7 @@ pmic@4 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		power-on@800 {
+		pon@800 {
 			compatible = "qcom,pm8916-pon";
 			reg = <0x0800>;
 
-- 
2.34.1

Re: [PATCH 3/4] arm64: dts: qcom: sc8180x-pmics: align SPMI PMIC Power-on node name with dtschema

[Konrad Dybcio]

On 20.07.2023 10:34, Krzysztof Kozlowski wrote:
> Bindings expect the Power-on node name to be "pon":
> 
>   sc8180x-lenovo-flex-5g.dtb: pmic@0: 'power-on@800' does not match any of the regexes:
> 
> Fixes: d3302290f59e ("arm64: dts: qcom: sc8180x: Add pmics")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH 3/4] arm64: dts: qcom: sc8180x-pmics: align SPMI PMIC Power-on node name with dtschema

[Vinod Koul]

On 20-07-23, 10:34, Krzysztof Kozlowski wrote:
> Bindings expect the Power-on node name to be "pon":
> 
>   sc8180x-lenovo-flex-5g.dtb: pmic@0: 'power-on@800' does not match any of the regexes:

Reviewed-by: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod

[PATCH 4/4] arm64: dts: qcom: sc8180x-pmics: align LPG node name with dtschema

[Krzysztof Kozlowski]

Bindings expect the LPG node name to be "pwm":

  sc8180x-lenovo-flex-5g.dtb: pmic@5: 'lpg' does not match any of the regexes:

Fixes: d3302290f59e ("arm64: dts: qcom: sc8180x: Add pmics")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
index bc17d22dbefc..ddc84282f142 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
@@ -315,7 +315,7 @@ pmic@5 {
 		compatible = "qcom,pmc8180c", "qcom,spmi-pmic";
 		reg = <0x5 SPMI_USID>;
 
-		pmc8180c_lpg: lpg {
+		pmc8180c_lpg: pwm {
 			compatible = "qcom,pmc8180c-lpg";
 
 			#address-cells = <1>;
-- 
2.34.1

Re: [PATCH 4/4] arm64: dts: qcom: sc8180x-pmics: align LPG node name with dtschema

[Konrad Dybcio]

On 20.07.2023 10:35, Krzysztof Kozlowski wrote:
> Bindings expect the LPG node name to be "pwm":
> 
>   sc8180x-lenovo-flex-5g.dtb: pmic@5: 'lpg' does not match any of the regexes:
> 
> Fixes: d3302290f59e ("arm64: dts: qcom: sc8180x: Add pmics")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH 4/4] arm64: dts: qcom: sc8180x-pmics: align LPG node name with dtschema

[Vinod Koul]

On 20-07-23, 10:35, Krzysztof Kozlowski wrote:
> Bindings expect the LPG node name to be "pwm":
> 
>   sc8180x-lenovo-flex-5g.dtb: pmic@5: 'lpg' does not match any of the regexes:

Reviewed-by: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod

Re: [PATCH 1/4] arm64: dts: qcom: sc8180x-pmics: add missing qcom,spmi-gpio fallbacks

[Konrad Dybcio]

On 20.07.2023 10:34, Krzysztof Kozlowski wrote:
> The GPIO children of PMICs should use qcom,spmi-gpio fallback:
> 
>   sc8180x-primus.dtb: pmic@0: gpio@c000:compatible: ['qcom,pmc8180-gpio'] is too short
> 
> Fixes: d3302290f59e ("arm64: dts: qcom: sc8180x: Add pmics")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH 1/4] arm64: dts: qcom: sc8180x-pmics: add missing qcom,spmi-gpio fallbacks

[Vinod Koul]

On 20-07-23, 10:34, Krzysztof Kozlowski wrote:
> The GPIO children of PMICs should use qcom,spmi-gpio fallback:
> 
>   sc8180x-primus.dtb: pmic@0: gpio@c000:compatible: ['qcom,pmc8180-gpio'] is too short

Reviewed-by: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod

Re: (subset) [PATCH 1/4] arm64: dts: qcom: sc8180x-pmics: add missing qcom,spmi-gpio fallbacks

[Bjorn Andersson]

On Thu, 20 Jul 2023 10:34:57 +0200, Krzysztof Kozlowski wrote:
> The GPIO children of PMICs should use qcom,spmi-gpio fallback:
> 
>   sc8180x-primus.dtb: pmic@0: gpio@c000:compatible: ['qcom,pmc8180-gpio'] is too short
> 
> 

Applied, thanks!

[1/4] arm64: dts: qcom: sc8180x-pmics: add missing qcom,spmi-gpio fallbacks
      commit: 0304fc1de3d930db83749cca6ccb3a4f89918fc4
[2/4] arm64: dts: qcom: sc8180x-pmics: add missing gpio-ranges
      commit: 565951b1202e1984154abaae4567f16f8073fca3
[3/4] arm64: dts: qcom: sc8180x-pmics: align SPMI PMIC Power-on node name with dtschema
      commit: bf520227bd32381c587fa36271475e035daab3d7
[4/4] arm64: dts: qcom: sc8180x-pmics: align LPG node name with dtschema
      commit: 4af302a7e29e70bd930e80ab8f967da48a99a31a

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>