From: Thierry Reding <thierry.reding@gmail.com>
To: Mohan Kumar <mkumard@nvidia.com>
Cc: treding@nvidia.com, jonathanh@nvidia.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, spujar@nvidia.com
Subject: Re: [PATCH] arm64: tegra: Add audio support for IGX Orin
Date: Thu, 20 Jul 2023 18:40:02 +0200 [thread overview]
Message-ID: <ZLljYqE_gDzh_WgT@orome> (raw)
In-Reply-To: <ZLljRBBHl_3jsKGg@orome>
[-- Attachment #1: Type: text/plain, Size: 1888 bytes --]
On Thu, Jul 20, 2023 at 06:39:32PM +0200, Thierry Reding wrote:
> On Tue, Jun 20, 2023 at 09:28:47PM +0530, Mohan Kumar wrote:
> > Add audio support for the NVIDIA IGX Orin development kit having P3701
> > module with P3740 carrier board.
> >
> > Move the common device-tree nodes to a new file tegra234-p3701.dtsi and
> > use this for Jetson AGX Orin and NVIDIA IGX Orin platforms
> >
> > Signed-off-by: Mohan Kumar <mkumard@nvidia.com>
> > ---
> > .../boot/dts/nvidia/tegra234-p3701-0000.dtsi | 1 +
> > .../boot/dts/nvidia/tegra234-p3701-0008.dtsi | 1 +
> > .../arm64/boot/dts/nvidia/tegra234-p3701.dtsi | 1991 ++++++++++++++++
> > .../nvidia/tegra234-p3737-0000+p3701-0000.dts | 2009 -----------------
> > .../boot/dts/nvidia/tegra234-p3737-0000.dtsi | 41 +
> > .../nvidia/tegra234-p3740-0002+p3701-0008.dts | 91 +-
> > .../boot/dts/nvidia/tegra234-p3740-0002.dtsi | 56 +
> > 7 files changed, 2176 insertions(+), 2014 deletions(-)
> > create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-p3701.dtsi
> [...]
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> > index 43d797e5544f..2b7856b303b4 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> > +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> [...]
> > @@ -103,7 +99,7 @@
> > };
> >
> > hda@3510000 {
> > - nvidia,model = "NVIDIA IGX HDA";
> > + nvidia,model = "NVIDIA Jetson IGX Orin HDA";
> [...]
> > @@ -151,4 +147,89 @@
> [...]
> > + label = "NVIDIA Jetson IGX Orin APE";
> [...]
>
> The platform is called "NVIDIA IGX Orin Development Kit", so shouldn't
> these be "NVIDIA IGX Orin HDA" and "NVIDIA IGX Orin APE", respectively?
Oh, and no need to resend, I can fix this up when I apply.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-07-20 16:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 15:58 [PATCH] arm64: tegra: Add audio support for IGX Orin Mohan Kumar
2023-07-20 16:39 ` Thierry Reding
2023-07-20 16:40 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLljYqE_gDzh_WgT@orome \
--to=thierry.reding@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=spujar@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).