devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: tegra: Add PCIe and DP 3.3V supplies
@ 2023-05-31  8:50 Shubhi Garg
  2023-07-21 13:26 ` Jon Hunter
  2023-07-21 15:19 ` Thierry Reding
  0 siblings, 2 replies; 4+ messages in thread
From: Shubhi Garg @ 2023-05-31  8:50 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, thierry.reding, jonathanh,
	devicetree, linux-tegra
  Cc: shgarg

Add the 3.3V supplies for PCIe C1 controller and Display Port controller
for the NVIDIA IGX Orin platform.

Signed-off-by: Shubhi Garg <shgarg@nvidia.com>
---
 .../nvidia/tegra234-p3740-0002+p3701-0008.dts |  1 +
 .../boot/dts/nvidia/tegra234-p3740-0002.dtsi  | 28 +++++++++++++++++++
 2 files changed, 29 insertions(+)

diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
index 43d797e5544f..c0ba69c16382 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
@@ -35,6 +35,7 @@
 		pcie@14100000 {
 			status = "okay";
 			vddio-pex-ctl-supply = <&vdd_1v8_ao>;
+			vpcie3v3-supply = <&vdd_3v3_wifi>;
 			phys = <&p2u_hsio_3>;
 			phy-names = "p2u-0";
 		};
diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi
index c95063b19321..7f6c34b79491 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi
@@ -134,4 +134,32 @@
 				"usb3-0", "usb3-1", "usb3-2";
 		};
 	};
+
+	vdd_3v3_dp: regulator-vdd-3v3-dp {
+				compatible = "regulator-fixed";
+				regulator-name = "vdd-3v3-dp";
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+				vin-supply = <&vdd_3v3_sys>;
+				gpio = <&gpio TEGRA234_MAIN_GPIO(H, 6) 0>;
+				enable-active-high;
+				regulator-always-on;
+	};
+
+	vdd_3v3_sys: regulator-vdd-3v3-sys {
+				compatible = "regulator-fixed";
+				regulator-name = "vdd-3v3-sys";
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+	};
+
+	vdd_3v3_wifi: regulator-vdd-3v3-wifi {
+				compatible = "regulator-fixed";
+				regulator-name = "vdd-3v3-wifi";
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+				gpio = <&gpio TEGRA234_MAIN_GPIO(G, 3) GPIO_ACTIVE_HIGH>;
+				regulator-boot-on;
+				enable-active-high;
+	};
 };
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: tegra: Add PCIe and DP 3.3V supplies
  2023-05-31  8:50 [PATCH] arm64: tegra: Add PCIe and DP 3.3V supplies Shubhi Garg
@ 2023-07-21 13:26 ` Jon Hunter
  2023-07-21 15:19 ` Thierry Reding
  1 sibling, 0 replies; 4+ messages in thread
From: Jon Hunter @ 2023-07-21 13:26 UTC (permalink / raw)
  To: Shubhi Garg, robh+dt, krzysztof.kozlowski+dt, thierry.reding,
	devicetree, linux-tegra


On 31/05/2023 09:50, Shubhi Garg wrote:
> Add the 3.3V supplies for PCIe C1 controller and Display Port controller
> for the NVIDIA IGX Orin platform.
> 
> Signed-off-by: Shubhi Garg <shgarg@nvidia.com>
> ---
>   .../nvidia/tegra234-p3740-0002+p3701-0008.dts |  1 +
>   .../boot/dts/nvidia/tegra234-p3740-0002.dtsi  | 28 +++++++++++++++++++
>   2 files changed, 29 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> index 43d797e5544f..c0ba69c16382 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> @@ -35,6 +35,7 @@
>   		pcie@14100000 {
>   			status = "okay";
>   			vddio-pex-ctl-supply = <&vdd_1v8_ao>;
> +			vpcie3v3-supply = <&vdd_3v3_wifi>;
>   			phys = <&p2u_hsio_3>;
>   			phy-names = "p2u-0";
>   		};
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi
> index c95063b19321..7f6c34b79491 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi
> @@ -134,4 +134,32 @@
>   				"usb3-0", "usb3-1", "usb3-2";
>   		};
>   	};
> +
> +	vdd_3v3_dp: regulator-vdd-3v3-dp {
> +				compatible = "regulator-fixed";
> +				regulator-name = "vdd-3v3-dp";
> +				regulator-min-microvolt = <3300000>;
> +				regulator-max-microvolt = <3300000>;
> +				vin-supply = <&vdd_3v3_sys>;
> +				gpio = <&gpio TEGRA234_MAIN_GPIO(H, 6) 0>;
> +				enable-active-high;
> +				regulator-always-on;
> +	};
> +
> +	vdd_3v3_sys: regulator-vdd-3v3-sys {
> +				compatible = "regulator-fixed";
> +				regulator-name = "vdd-3v3-sys";
> +				regulator-min-microvolt = <3300000>;
> +				regulator-max-microvolt = <3300000>;
> +	};
> +
> +	vdd_3v3_wifi: regulator-vdd-3v3-wifi {
> +				compatible = "regulator-fixed";
> +				regulator-name = "vdd-3v3-wifi";
> +				regulator-min-microvolt = <3300000>;
> +				regulator-max-microvolt = <3300000>;
> +				gpio = <&gpio TEGRA234_MAIN_GPIO(G, 3) GPIO_ACTIVE_HIGH>;
> +				regulator-boot-on;
> +				enable-active-high;
> +	};
>   };


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thierry, OK to pick this up?

Jon

-- 
nvpublic

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: tegra: Add PCIe and DP 3.3V supplies
  2023-05-31  8:50 [PATCH] arm64: tegra: Add PCIe and DP 3.3V supplies Shubhi Garg
  2023-07-21 13:26 ` Jon Hunter
@ 2023-07-21 15:19 ` Thierry Reding
  2023-07-21 15:21   ` Thierry Reding
  1 sibling, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2023-07-21 15:19 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, thierry.reding, jonathanh,
	devicetree, linux-tegra, Shubhi Garg

From: Thierry Reding <treding@nvidia.com>


On Wed, 31 May 2023 08:50:52 +0000, Shubhi Garg wrote:
> Add the 3.3V supplies for PCIe C1 controller and Display Port controller
> for the NVIDIA IGX Orin platform.
> 
> 

Applied, thanks!

[1/1] arm64: tegra: Add PCIe and DP 3.3V supplies
      commit: 84ea422262387d050ed46e896371da79fc31e7f9

Best regards,
-- 
Thierry Reding <treding@nvidia.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: tegra: Add PCIe and DP 3.3V supplies
  2023-07-21 15:19 ` Thierry Reding
@ 2023-07-21 15:21   ` Thierry Reding
  0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2023-07-21 15:21 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, jonathanh, devicetree,
	linux-tegra, Shubhi Garg

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

On Fri, Jul 21, 2023 at 05:19:18PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> 
> On Wed, 31 May 2023 08:50:52 +0000, Shubhi Garg wrote:
> > Add the 3.3V supplies for PCIe C1 controller and Display Port controller
> > for the NVIDIA IGX Orin platform.
> > 
> > 
> 
> Applied, thanks!
> 
> [1/1] arm64: tegra: Add PCIe and DP 3.3V supplies
>       commit: 84ea422262387d050ed46e896371da79fc31e7f9

Note that I've renamed these for consistency with other regulators'
regulator-name property. Let me know if for some reason that doesn't
work.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-07-21 15:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-31  8:50 [PATCH] arm64: tegra: Add PCIe and DP 3.3V supplies Shubhi Garg
2023-07-21 13:26 ` Jon Hunter
2023-07-21 15:19 ` Thierry Reding
2023-07-21 15:21   ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).