From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73873C3DA40 for ; Fri, 21 Jul 2023 16:26:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232978AbjGUQ0y (ORCPT ); Fri, 21 Jul 2023 12:26:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232605AbjGUQ02 (ORCPT ); Fri, 21 Jul 2023 12:26:28 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D090F46A1; Fri, 21 Jul 2023 09:23:24 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="453435610" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="453435610" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 09:21:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="848870377" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="848870377" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 21 Jul 2023 09:21:03 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qMssF-00CCBV-0a; Fri, 21 Jul 2023 19:20:59 +0300 Date: Fri, 21 Jul 2023 19:20:58 +0300 From: Andy Shevchenko To: nikita.shubin@maquefel.me Cc: Hartley Sweeten , Lennert Buytenhek , Alexander Sverdlin , Russell King , Lukasz Majewski , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Daniel Lezcano , Thomas Gleixner , Alessandro Zummo , Alexandre Belloni , Wim Van Sebroeck , Guenter Roeck , Sebastian Reichel , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mark Brown , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Damien Le Moal , Sergey Shtylyov , Dmitry Torokhov , Arnd Bergmann , Olof Johansson , soc@kernel.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Michael Peters , Kris Bahnsen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-spi@vger.kernel.org, netdev@vger.kernel.org, dmaengine@vger.kernel.org, linux-mtd@lists.infradead.org, linux-ide@vger.kernel.org, linux-input@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v3 22/42] dma: cirrus: add DT support for Cirrus EP93xx Message-ID: References: <20230605-ep93xx-v3-0-3d63a5f1103e@maquefel.me> <20230605-ep93xx-v3-22-3d63a5f1103e@maquefel.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230605-ep93xx-v3-22-3d63a5f1103e@maquefel.me> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jul 20, 2023 at 02:29:22PM +0300, Nikita Shubin via B4 Relay wrote: > From: Nikita Shubin > > - drop subsys_initcall code > - add OF ID match table with data > - add of_probe for device tree ... > +#include Why? ... > +#ifdef CONFIG_OF Why this ugly ifdeffery? ... > + data = of_device_get_match_data(&pdev->dev); device_get_match_data() > + if (!data) > + return ERR_PTR(dev_err_probe(&pdev->dev, -ENODEV, "No device match found\n")); ... > + edma = devm_kzalloc(&pdev->dev, > + struct_size(edma, channels, data->num_channels), > + GFP_KERNEL); Something wrong with indentation. Not the first time, please check all your patches for this kind of issues. > + return ERR_PTR(-ENOMEM); ... > + edmac->regs = devm_platform_ioremap_resource(pdev, i); No check? > + edmac->irq = platform_get_irq(pdev, i); No check? > + edmac->edma = edma; > + > + edmac->clk = of_clk_get(np, i); > + Redundant blank line. Why one of devm_clk_get*() can't be called? > + if (IS_ERR(edmac->clk)) { > + dev_warn(&pdev->dev, "failed to get clock\n"); > + continue; > + } ... > + if (platform_get_device_id(pdev)) > + edma = ep93xx_init_from_pdata(pdev); > + else > + edma = ep93xx_dma_of_probe(pdev); > + Unneeded blank line. > + if (!edma) > + return PTR_ERR(edma); ... > --- a/include/linux/platform_data/dma-ep93xx.h > +++ b/include/linux/platform_data/dma-ep93xx.h > #include > #include > #include > +#include property.h. ... > + if (of_device_is_compatible(dev_of_node(chan->device->dev), "cirrus,ep9301-dma-m2p")) > + return true; > + device_is_compatible() -- With Best Regards, Andy Shevchenko