From: Jisheng Zhang <jszhang@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Conor Dooley" <conor@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: serial: snps-dw-apb-uart: make interrupt optional
Date: Sun, 6 Aug 2023 17:40:27 +0800 [thread overview]
Message-ID: <ZM9qi6VYo1qaBhoI@xhacker> (raw)
In-Reply-To: <ZMuSFYQ4YyIKnI0k@smile.fi.intel.com>
On Thu, Aug 03, 2023 at 02:40:05PM +0300, Andy Shevchenko wrote:
> On Wed, Aug 02, 2023 at 11:53:59PM +0100, Conor Dooley wrote:
> > On Thu, Aug 03, 2023 at 12:57:44AM +0300, Andy Shevchenko wrote:
> > > On Wed, Aug 02, 2023 at 04:43:48PM +0100, Conor Dooley wrote:
> > > > On Wed, Aug 02, 2023 at 11:05:44PM +0800, Jisheng Zhang wrote:
> > > > > The driver fall back to poll style when there's no irq. "poll" still
> > > > > looks better than no support.
> > > >
> > > > What is the user for this where the interrupt is not actually wired up
> > > > in the hardware?
> > >
> > > FYI: kernel console doesn't use interrupts, so for example it might be
> > > the debug port. Note, I have no idea of the Zhang's case, just my assumption.
Hi Conor, Andy,
Andy's assumption about the uart dedicated for debug purpose is true, since
it's for log only, so no interrupt need at all. We can also see such no
irq support in litex uart driver(liteuart.c) and even a 8250
variant(8250_ioc3.c).
Thanks
> >
> > I'm less interested in what the software is doing, it's what the device
> > that has not connected the interrupt is that I am curious about.
>
> As I said. The hw may be purely for debugging purposes (and yes, I have heard
> about such a hardware).
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
next prev parent reply other threads:[~2023-08-06 9:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 15:05 [PATCH 0/2] serial: 8250_dw: fall back to poll if there's no interrupt Jisheng Zhang
2023-08-02 15:05 ` [PATCH 1/2] dt-bindings: serial: snps-dw-apb-uart: make interrupt optional Jisheng Zhang
2023-08-02 15:43 ` Conor Dooley
2023-08-02 21:57 ` Andy Shevchenko
2023-08-02 22:53 ` Conor Dooley
2023-08-03 11:40 ` Andy Shevchenko
2023-08-06 9:40 ` Jisheng Zhang [this message]
2023-08-02 15:05 ` [PATCH 2/2] serial: 8250_dw: fall back to poll if there's no interrupt Jisheng Zhang
2023-08-02 21:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZM9qi6VYo1qaBhoI@xhacker \
--to=jszhang@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).