From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A250C41513 for ; Wed, 26 Jul 2023 16:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231925AbjGZQAI (ORCPT ); Wed, 26 Jul 2023 12:00:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235040AbjGZP72 (ORCPT ); Wed, 26 Jul 2023 11:59:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01E7CDD; Wed, 26 Jul 2023 08:59:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8BED061B9A; Wed, 26 Jul 2023 15:59:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63276C433C7; Wed, 26 Jul 2023 15:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690387163; bh=ZVYSAijYjAzVdSVVoPt4UJzIEJFPCTCkTsJbuNdi1QE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lojai7na1ElHe5GdMww572j/Z9Ep34SG463mNTa1IkFqPtSz5ExoO6xEoER5RjMAa 3Zqb6dekCRzIXOs6XQfoKaxQ3jKIDASssTP6msy122pbDrXSc2nvSMd3abg4FWxDsD WCO6MEqrFlCw5rmYOelxKWALqmZWMahQDAXrJ9MbeM4Mt8ohY6aorxSYwhzvag6z1s SiGJYjkm3jVgcFpyEDIFrBDFY2funfYuXJ9xDtWQAJ5xG2oBLsnl6taXxObIi0oV90 pkx/TjCZPKZeY1QXADLRLpUEsZxbUi8LWdX5jrL0loCKuG/n90RXTDdKJ7ZSFzrwee qoVKc1pIP5zqw== Date: Wed, 26 Jul 2023 23:47:44 +0800 From: Jisheng Zhang To: Rob Herring Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next 09/10] dt-bindings: net: snps,dwmac: add per channel irq support Message-ID: References: <20230723161029.1345-1-jszhang@kernel.org> <20230723161029.1345-10-jszhang@kernel.org> <20230726152439.GA1471409-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230726152439.GA1471409-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jul 26, 2023 at 09:24:39AM -0600, Rob Herring wrote: > On Mon, Jul 24, 2023 at 12:10:28AM +0800, Jisheng Zhang wrote: > > The IP supports per channel interrupt, add support for this usage case. > > > > Signed-off-by: Jisheng Zhang > > --- > > .../devicetree/bindings/net/snps,dwmac.yaml | 23 +++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index bb80ca205d26..525210c2c06c 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -101,6 +101,11 @@ properties: > > minItems: 1 > > maxItems: 2 > > > > + snps,per-channel-interrupt: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + Indicates that Rx and Tx complete will generate a unique interrupt for each channel > > Can't you determine this based on the number of interrupts or interrupt > names? Good idea! this flag can be dynamically detected based on the interrupt names. The driver code will be patched a bit ugly, I will try and send out for review. > > > + > > interrupts: > > minItems: 1 > > items: > > @@ -109,6 +114,8 @@ properties: > > - description: The interrupt that occurs when Rx exits the LPI state > > - description: The interrupt that occurs when Safety Feature Correctible Errors happen > > - description: The interrupt that occurs when Safety Feature Uncorrectible Errors happen > > + - description: All of the rx per-channel interrupts > > + - description: All of the tx per-channel interrupts > > You added 2 interrupts here and... I'm not sure how to write the description here, could it be one line "- description: All of the tx/rx per-channel interrupts"? > > > > > interrupt-names: > > minItems: 1 > > @@ -118,6 +125,22 @@ properties: > > - const: eth_lpi > > - const: sfty_ce_irq > > - const: sfty_ue_irq > > + - const: rx0 > > + - const: rx1 > > + - const: rx2 > > + - const: rx3 > > + - const: rx4 > > + - const: rx5 > > + - const: rx6 > > + - const: rx7 > > + - const: tx0 > > + - const: tx1 > > + - const: tx2 > > + - const: tx3 > > + - const: tx4 > > + - const: tx5 > > + - const: tx6 > > + - const: tx7 > > And 16 here? > oops, indeed HW supports up to 16 channels for tx and rx, thus up to 16 interrupts. > > > > clocks: > > minItems: 1 > > -- > > 2.40.1 > >