From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DED4C0015E for ; Thu, 27 Jul 2023 09:02:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231403AbjG0JCB (ORCPT ); Thu, 27 Jul 2023 05:02:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230098AbjG0JBe (ORCPT ); Thu, 27 Jul 2023 05:01:34 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EE3D4214 for ; Thu, 27 Jul 2023 01:41:40 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1b8b2b60731so3685665ad.2 for ; Thu, 27 Jul 2023 01:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1690447300; x=1691052100; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4kDK3i7/sRj1o3iJSqZ1qWTUMiecFrRZKOPsM2hxTr8=; b=evIUIKiizZRZxZVLDmc6BSWRfJgAiei1agcWhJlMlRyWLp22WZYoh8ktsfYdJucLjI po3Lny3K+4I3FI446Kv2VmEoLZl5GYWso3ptEMMbgGrsmtZvUO6GikdXQR0jF0XfY0mr 2hF3o/G2RogNOIiOj2yHZbn1y4XkFwCpo7jXwQ7VGkr/s2O6kLmBieWKBMzY2OJgnQFn qGKQef5mtn/uRG/T6YXqq40w8n1vXjQPOubLiPowXKPsf42M0UgIPThYgXFWQlwbWz/Z atArxyMy63mrn/E8EusmtaWe6azMbM0tKZud+QsEZa8Tyeg4GUPOt6va9RFIdeSeDcEh 8EPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690447300; x=1691052100; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4kDK3i7/sRj1o3iJSqZ1qWTUMiecFrRZKOPsM2hxTr8=; b=QC7JfZRI2KLagrfjhHGk0NhRmtM/GSq/pTofjoXaqaW5uekyWyYo6UEzJRKJM0zdeL Lo80ZCx9pP36ojSjzkGztAOSZR/fx2br4SRCwmO0wrkXwoHka5xwD+maoLT6QnhkMPd2 Gq1mkvxaGtOYY1DoMjKQhwQ0vuq4rs5qarxg348vaTMCxurfeFq2xDmx+n2QtWnwpBlV bTt2Ez8bTLgl0ushxaPPMObff0LjixhZqqxPPsHafm8mO3bCqfMFnccA9AOhXxtraoXZ pg/HF0A8M/R/Tc/w83E0BKzM+1DKualvfCgN5RpM3tQN3ksTOHD3Y5l30PAR0MmG+XHG bqwg== X-Gm-Message-State: ABy/qLaI4xafKgebrA0HtwdKHWmAzGonMJHpf2CaET1jDb6d/qrv7pSE UDffmpvwH9yR5X71hJIXBm7DOg== X-Google-Smtp-Source: APBJJlFNzb937sOtAwew9B0iPaqnJMzJx+v4W1dfU3BIcEBO4xpb7dilmt7NUGNhp5IuMAErdB6wWg== X-Received: by 2002:a17:902:7447:b0:1b8:1c9e:442c with SMTP id e7-20020a170902744700b001b81c9e442cmr3359282plt.20.1690447299788; Thu, 27 Jul 2023 01:41:39 -0700 (PDT) Received: from sunil-laptop ([106.51.190.25]) by smtp.gmail.com with ESMTPSA id w5-20020a170902d3c500b001bbd1562e75sm1025215plb.55.2023.07.27.01.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 01:41:39 -0700 (PDT) Date: Thu, 27 Jul 2023 14:11:30 +0530 From: Sunil V L To: Anup Patel Cc: Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley , Atish Patra , Andrew Jones , Saravana Kannan , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 04/14] irqchip/sifive-plic: Use platform driver probing for PLIC Message-ID: References: <20230719113542.2293295-1-apatel@ventanamicro.com> <20230719113542.2293295-5-apatel@ventanamicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230719113542.2293295-5-apatel@ventanamicro.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Anup, On Wed, Jul 19, 2023 at 05:05:32PM +0530, Anup Patel wrote: > The PLIC driver does not require very early initialization so let us > replace use of IRQCHIP_DECLARE() with IRQCHIP_PLATFORM_DRIVER_xyz() > so that PLIC is probed through platform driver probing. > > Signed-off-by: Anup Patel > --- > drivers/irqchip/irq-sifive-plic.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c > index 56b0544b1f27..dc02f0761ced 100644 > --- a/drivers/irqchip/irq-sifive-plic.c > +++ b/drivers/irqchip/irq-sifive-plic.c > @@ -569,8 +569,10 @@ static int __init plic_init(struct device_node *node, > return __plic_init(node, parent, 0); > } > > -IRQCHIP_DECLARE(sifive_plic, "sifive,plic-1.0.0", plic_init); > -IRQCHIP_DECLARE(riscv_plic0, "riscv,plic0", plic_init); /* for legacy systems */ > +IRQCHIP_PLATFORM_DRIVER_BEGIN(sifive_plic) > +IRQCHIP_MATCH("sifive,plic-1.0.0", plic_init) > +IRQCHIP_MATCH("riscv,plic0", plic_init) /* for legacy systems */ > +IRQCHIP_PLATFORM_DRIVER_END(sifive_plic) > Few observations.. 1) IRQCHIP_PLATFORM_DRIVER_xyz work only for DT. Can we have more generic platform driver probe similar to APLIC driver? 2) With platform driver model, there is a crash some times. [ 0.198665] CPU: 4 PID: 32 Comm: cpuhp/4 Not tainted 6.5.0-rc3-00038-g782440711cdb #42 [ 0.198944] Hardware name: riscv-virtio,qemu (DT) [ 0.199125] epc : plic_starting_cpu+0x60/0xa6 [ 0.199545] ra : plic_starting_cpu+0x58/0xa6 [ 0.199676] epc : ffffffff8047396e ra : ffffffff80473966 sp : ff20000000173d80 [ 0.199899] gp : ffffffff81501740 tp : ff600000019bde00 t0 : ffffffff81200800 [ 0.200112] t1 : 0000000000000000 t2 : 0000000000001000 s0 : ff20000000173db0 [ 0.200324] s1 : ff6000007ef91eb0 a0 : ff600000019690b0 a1 : 0000000200000020 [ 0.200502] a2 : 0000000000000000 a3 : 0000000000000000 a4 : 0000000000000000 [ 0.200678] a5 : 0000000000000000 a6 : ff6000000184a108 a7 : ff6000000184a100 [ 0.200855] s2 : 000000000000000b s3 : ffffffff8153a550 s4 : 0000000000000004 [ 0.201032] s5 : 0000000000000001 s6 : 0000000000000002 s7 : ffffffff8047390e [ 0.201210] s8 : ffffffff80033f8a s9 : ffffffff80033f64 s10: 0000000000000000 [ 0.201392] s11: 0000000000000000 t3 : 0000000000000000 t4 : ffffffff81486c20 [ 0.201567] t5 : 0000000000000002 t6 : 0000000000000002 [ 0.201702] status: 0000000200000100 badaddr: 0000000000000000 cause: 000000000000000f [ 0.201962] [] plic_starting_cpu+0x60/0xa6 [ 0.202184] [] cpuhp_invoke_callback+0xb4/0x164 [ 0.202346] [] cpuhp_thread_fun+0x8a/0x11c [ 0.202493] [] smpboot_thread_fn+0xe4/0x1be [ 0.202639] [] kthread+0xc4/0xe0 [ 0.202759] [] ret_from_fork+0xa/0x1c [ 0.203038] Code: 89bd 854a 3097 ffbf 80e7 51e0 000f 0140 4781 6498 (c31c) 2703 3) Looks like an existing issue but I get below warning also. [ 0.207677] list_add double add: new=ffffffff814a0798, prev=ffffffff814a0798, next=ffffffff814be638. [ 0.208243] WARNING: CPU: 4 PID: 1 at lib/list_debug.c:33 __list_add_valid+0x46/0xac [ 0.208677] Modules linked in: [ 0.208780] CPU: 4 PID: 1 Comm: swapper/0 Not tainted 6.5.0-rc3-00038-g782440711cdb #28 [ 0.208862] Hardware name: riscv-virtio,qemu (DT) [ 0.208926] epc : __list_add_valid+0x46/0xac [ 0.208961] ra : __list_add_valid+0x46/0xac [ 0.208983] epc : ffffffff803cb356 ra : ffffffff803cb356 sp : ff200000000439f0 [ 0.208994] gp : ffffffff81501740 tp : ff600000018f0000 t0 : 2000000000000000 [ 0.209005] t1 : 000000000000006c t2 : 206464615f747369 s0 : ff20000000043a00 [ 0.209015] s1 : ffffffff814a0798 a0 : 0000000000000058 a1 : ffffffff81486828 [ 0.209025] a2 : 0000000000000000 a3 : fffffffffffffffe a4 : 0000000000000000 [ 0.209034] a5 : 0000000000000000 a6 : 0000000000000068 a7 : 0000000000000038 [ 0.209044] s2 : ffffffff814be5f8 s3 : ffffffff814a0798 s4 : ffffffff814be638 [ 0.209053] s5 : ff6000007fff75c0 s6 : 0000000000000060 s7 : ffffffff80c20eb0 [ 0.209063] s8 : 0000000000000008 s9 : 0000000000000004 s10: ffffffff80c20eb0 [ 0.209072] s11: ffffffff81038e80 t3 : ffffffff815159d7 t4 : ffffffff815159d7 [ 0.209081] t5 : ffffffff815159d8 t6 : ff200000000437f8 [ 0.209090] status: 0000000200000120 badaddr: 0000000000000000 cause: 0000000000000003 [ 0.209167] [] __list_add_valid+0x46/0xac [ 0.209219] [] register_syscore_ops+0x3e/0x70 [ 0.209245] [] __plic_init.isra.0+0x3e0/0x4e2 [ 0.209267] [] plic_init+0x12/0x1a [ 0.209281] [] platform_irqchip_probe+0x82/0xb4 [ 0.209292] [] platform_probe+0x4e/0xa6 [ 0.209301] [] really_probe+0x86/0x242 [ 0.209308] [] __driver_probe_device+0x5c/0xda [ 0.209316] [] driver_probe_device+0x2c/0xb2 [ 0.209324] [] __driver_attach+0x6c/0x11a [ 0.209331] [] bus_for_each_dev+0x60/0xae [ 0.209343] [] driver_attach+0x1a/0x22 [ 0.209352] [] bus_add_driver+0xd0/0x1ba [ 0.209362] [] driver_register+0x3e/0xd8 [ 0.209370] [] __platform_driver_register+0x1c/0x24 [ 0.209378] [] sifive_plic_driver_init+0x1a/0x22 [ 0.209389] [] do_one_initcall+0x58/0x19c [ 0.209399] [] kernel_init_freeable+0x20c/0x276 [ 0.209410] [] kernel_init+0x1e/0x10a [ 0.209421] [] ret_from_fork+0xa/0x1c [ 0.209477] ---[ end trace 0000000000000000 ]--- Thanks, Sunil