From: "Guido Günther" <guido.gunther@puri.sm>
To: David Heidelberg <david@ixit.cz>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
kernel@puri.sm,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply
Date: Mon, 31 Jul 2023 13:32:09 +0200 [thread overview]
Message-ID: <ZMebuXJKFMpjCuul@qwark.sigxcpu.org> (raw)
In-Reply-To: <20230730121047.43115-1-david@ixit.cz>
Hi,
On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote:
> Resolves following warning:
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected)
> from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#
>
> Cc: kernel@puri.sm
> Cc: Guido Günther <agx@sigxcpu.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index b3549eae6278..a8b5da3ca08f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -1031,7 +1031,7 @@ &usdhc2 {
> pinctrl-2 = <&pinctrl_usdhc2_200mhz>;
> bus-width = <4>;
> vmmc-supply = <®_usdhc2_vmmc>;
> - power-supply = <&wifi_pwr_en>;
> + vqmmc-supply = <&wifi_pwr_en>;
From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE`
so I don't think vqmmc is correct here. I wonder if there's a better way
to model that in DT? Any suggestions would be welcome.
Cheers,
-- Guido
> broken-cd;
> disable-wp;
> cap-sdio-irq;
> --
> 2.40.1
>
next prev parent reply other threads:[~2023-07-31 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 12:10 [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply David Heidelberg
2023-07-31 11:32 ` Guido Günther [this message]
2023-07-31 12:42 ` Ahmad Fatoum
2023-08-10 5:23 ` David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMebuXJKFMpjCuul@qwark.sigxcpu.org \
--to=guido.gunther@puri.sm \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).