From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A1AEC001DE for ; Mon, 31 Jul 2023 11:50:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231490AbjGaLu1 (ORCPT ); Mon, 31 Jul 2023 07:50:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230210AbjGaLu1 (ORCPT ); Mon, 31 Jul 2023 07:50:27 -0400 X-Greylist: delayed 599 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 31 Jul 2023 04:50:25 PDT Received: from honk.sigxcpu.org (honk.sigxcpu.org [24.134.29.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6E84B0; Mon, 31 Jul 2023 04:50:25 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 21658FB03; Mon, 31 Jul 2023 13:32:12 +0200 (CEST) Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OTNelOZNj6Y2; Mon, 31 Jul 2023 13:32:11 +0200 (CEST) Date: Mon, 31 Jul 2023 13:32:09 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: David Heidelberg Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Peng Fan , kernel@puri.sm, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply Message-ID: References: <20230730121047.43115-1-david@ixit.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230730121047.43115-1-david@ixit.cz> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote: > Resolves following warning: > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected) > from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml# > > Cc: kernel@puri.sm > Cc: Guido Günther > Signed-off-by: David Heidelberg > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > index b3549eae6278..a8b5da3ca08f 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > @@ -1031,7 +1031,7 @@ &usdhc2 { > pinctrl-2 = <&pinctrl_usdhc2_200mhz>; > bus-width = <4>; > vmmc-supply = <®_usdhc2_vmmc>; > - power-supply = <&wifi_pwr_en>; > + vqmmc-supply = <&wifi_pwr_en>; >From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE` so I don't think vqmmc is correct here. I wonder if there's a better way to model that in DT? Any suggestions would be welcome. Cheers, -- Guido > broken-cd; > disable-wp; > cap-sdio-irq; > -- > 2.40.1 >