From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84CE5C001E0 for ; Wed, 2 Aug 2023 13:41:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231683AbjHBNlL (ORCPT ); Wed, 2 Aug 2023 09:41:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233699AbjHBNlK (ORCPT ); Wed, 2 Aug 2023 09:41:10 -0400 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F367269E; Wed, 2 Aug 2023 06:41:09 -0700 (PDT) Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 2B985209F0; Wed, 2 Aug 2023 15:41:07 +0200 (CEST) Date: Wed, 2 Aug 2023 15:41:03 +0200 From: Francesco Dolcini To: Nishanth Menon Cc: Francesco Dolcini , Jai Luthra , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Francesco Dolcini Subject: Re: [PATCH v1 1/4] arm64: dts: ti: k3-am62x: Enable AUDIO_REFCLKx Message-ID: References: <20230731142135.108477-1-francesco@dolcini.it> <20230731142135.108477-2-francesco@dolcini.it> <23C6E13C-3F10-490B-A18E-C67B91CBAF35@dolcini.it> <20230802133244.b66pg3mztotgqotm@steerable> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230802133244.b66pg3mztotgqotm@steerable> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Aug 02, 2023 at 08:32:44AM -0500, Nishanth Menon wrote: > On 13:37-20230802, Francesco Dolcini wrote: > > Il 2 agosto 2023 13:23:50 CEST, Jai Luthra ha scritto: > > >On Jul 31, 2023 at 16:21:32 +0200, Francesco Dolcini wrote: > > >> From: Jai Luthra > > >> > > >> On AM62-based SoCs the AUDIO_REFCLKx clocks can be used as an input to > > >> external peripherals when configured through CTRL_MMR, so add the > > >> clock nodes. > > >> > > >> Signed-off-by: Jai Luthra > > >> Signed-off-by: Francesco Dolcini > > >> --- > > >> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 18 ++++++++++++++++++ > > >> arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 18 ++++++++++++++++++ > > > > > >Given currently none of the AM62A boards are using the refclks, can you > > >drop those or just mark the nodes as disabled. Whoever is the first user > > >can enable them. > > > > I can drop the 2 clocks from AM62A, however, should we really do it? > > These clocks exist and they are just defined in the DTS, they are > > not going to be enabled if not used, "ti,am62-epwm-tbclk" is also > > not disabled for example. > > Overall, the SoC clock as such has nothing to do with board specific, so > leave it default (enabled) in SoC.dts - just want to make sure that the > clk-parent selection doesn't get in the way of platforms and is a sane > default. When I looked into that, months ago, this looked to me the correct and a sane default. I had the same in our downstream way before the addition from Jai Luthra to the SoC dtsi. Not sure if Jai can add more on that regard. > pll2_hsdiv8 output - which looks like the default mux value anyways.. > I am ok for it being explicit, but wondering if that works for boards > that do not use this default. IFF needed, it would be very easy to just override from the board dts, using the labels that are already there (audio_refclk0, audio_refclk1). > (sidenote): Fransesco - your new mail client has line wrap issues ;) Yep, I had the crazy idea to reply from my mobile phone while having a walk. It's already a success that I did not top post ;-) Francesco