* [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement
@ 2023-07-30 18:41 David Heidelberg
2023-08-02 9:51 ` Guido Günther
2023-08-17 15:26 ` Guido Günther
0 siblings, 2 replies; 7+ messages in thread
From: David Heidelberg @ 2023-07-30 18:41 UTC (permalink / raw)
To: Marek Vasut, Stefan Agner, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Liu Ying
Cc: kernel, Guido Günther, David Heidelberg, Krzysztof Kozlowski,
Rob Herring, dri-devel, devicetree, linux-kernel
i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers
requirement of power-domains, thou it's not required.
Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
.../devicetree/bindings/display/fsl,lcdif.yaml | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index fc11ab5fc465..2d868276b0f9 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -129,8 +129,15 @@ allOf:
- fsl,imx8mp-lcdif
- fsl,imx93-lcdif
then:
- required:
- - power-domains
+ if:
+ properties:
+ compatible:
+ not:
+ contains:
+ const: fsl,imx8mq-lcdif
+ then:
+ required:
+ - power-domains
examples:
- |
--
2.40.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement 2023-07-30 18:41 [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement David Heidelberg @ 2023-08-02 9:51 ` Guido Günther 2023-08-10 19:30 ` Conor Dooley 2023-08-17 15:26 ` Guido Günther 1 sibling, 1 reply; 7+ messages in thread From: Guido Günther @ 2023-08-02 9:51 UTC (permalink / raw) To: David Heidelberg Cc: Marek Vasut, Stefan Agner, David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Liu Ying, kernel, Krzysztof Kozlowski, Rob Herring, dri-devel, devicetree, linux-kernel Hi, On Sun, Jul 30, 2023 at 09:41:20PM +0300, David Heidelberg wrote: > i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers > requirement of power-domains, thou it's not required. > > Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property") > > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > .../devicetree/bindings/display/fsl,lcdif.yaml | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index fc11ab5fc465..2d868276b0f9 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -129,8 +129,15 @@ allOf: > - fsl,imx8mp-lcdif > - fsl,imx93-lcdif > then: > - required: > - - power-domains > + if: > + properties: > + compatible: > + not: > + contains: > + const: fsl,imx8mq-lcdif > + then: > + required: > + - power-domains We currently enable the mipi power domain for the mipi dphy and nwl bridge only but not for LCDIF itself assuming it's not needed (as there's other outputs LCDIF can drive). I *think* this is correct but maybe Marek or Liu can confirm? Cheers, -- Guido > > examples: > - | > -- > 2.40.1 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement 2023-08-02 9:51 ` Guido Günther @ 2023-08-10 19:30 ` Conor Dooley 2023-08-11 3:47 ` Marek Vasut ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Conor Dooley @ 2023-08-10 19:30 UTC (permalink / raw) To: Guido Günther Cc: David Heidelberg, Marek Vasut, Stefan Agner, David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Liu Ying, kernel, Krzysztof Kozlowski, Rob Herring, dri-devel, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1675 bytes --] On Wed, Aug 02, 2023 at 11:51:17AM +0200, Guido Günther wrote: > Hi, > On Sun, Jul 30, 2023 at 09:41:20PM +0300, David Heidelberg wrote: > > i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers > > requirement of power-domains, thou it's not required. > > > > Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property") > > > > Signed-off-by: David Heidelberg <david@ixit.cz> > > --- > > .../devicetree/bindings/display/fsl,lcdif.yaml | 11 +++++++++-- > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > index fc11ab5fc465..2d868276b0f9 100644 > > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > @@ -129,8 +129,15 @@ allOf: > > - fsl,imx8mp-lcdif > > - fsl,imx93-lcdif > > then: > > - required: > > - - power-domains > > + if: > > + properties: > > + compatible: > > + not: > > + contains: > > + const: fsl,imx8mq-lcdif > > + then: > > + required: > > + - power-domains > > We currently enable the mipi power domain for the mipi dphy and nwl > bridge only but not for LCDIF itself assuming it's not needed (as there's > other outputs LCDIF can drive). I *think* this is correct but maybe > Marek or Liu can confirm? I'm happy to Ack this, but I've been sitting on it waiting to see if Marek or Liu popped up.. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement 2023-08-10 19:30 ` Conor Dooley @ 2023-08-11 3:47 ` Marek Vasut 2023-08-11 5:49 ` Ying Liu 2023-08-11 6:53 ` Conor Dooley 2 siblings, 0 replies; 7+ messages in thread From: Marek Vasut @ 2023-08-11 3:47 UTC (permalink / raw) To: Conor Dooley, Guido Günther Cc: David Heidelberg, Stefan Agner, David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Liu Ying, kernel, Krzysztof Kozlowski, Rob Herring, dri-devel, devicetree, linux-kernel On 8/10/23 21:30, Conor Dooley wrote: > On Wed, Aug 02, 2023 at 11:51:17AM +0200, Guido Günther wrote: >> Hi, >> On Sun, Jul 30, 2023 at 09:41:20PM +0300, David Heidelberg wrote: >>> i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers >>> requirement of power-domains, thou it's not required. >>> >>> Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property") >>> >>> Signed-off-by: David Heidelberg <david@ixit.cz> >>> --- >>> .../devicetree/bindings/display/fsl,lcdif.yaml | 11 +++++++++-- >>> 1 file changed, 9 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>> index fc11ab5fc465..2d868276b0f9 100644 >>> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml >>> @@ -129,8 +129,15 @@ allOf: >>> - fsl,imx8mp-lcdif >>> - fsl,imx93-lcdif >>> then: >>> - required: >>> - - power-domains >>> + if: >>> + properties: >>> + compatible: >>> + not: >>> + contains: >>> + const: fsl,imx8mq-lcdif >>> + then: >>> + required: >>> + - power-domains >> >> We currently enable the mipi power domain for the mipi dphy and nwl >> bridge only but not for LCDIF itself assuming it's not needed (as there's >> other outputs LCDIF can drive). I *think* this is correct but maybe >> Marek or Liu can confirm? > > I'm happy to Ack this, but I've been sitting on it waiting to see if > Marek or Liu popped up.. I don't see anything which would resemble power domains like on MX8MM/N/P on the MQ MXSFB, there are such domains for the VPU and DCSS, but not MXSFB. So Reviewed-by: Marek Vasut <marex@denx.de> ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement 2023-08-10 19:30 ` Conor Dooley 2023-08-11 3:47 ` Marek Vasut @ 2023-08-11 5:49 ` Ying Liu 2023-08-11 6:53 ` Conor Dooley 2 siblings, 0 replies; 7+ messages in thread From: Ying Liu @ 2023-08-11 5:49 UTC (permalink / raw) To: Conor Dooley, Guido Günther Cc: David Heidelberg, Marek Vasut, Stefan Agner, David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, kernel@puri.sm, Krzysztof Kozlowski, Rob Herring, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org On Friday, August 11, 2023 3:30 AM Conor Dooley <conor@kernel.org> wrote: > > On Wed, Aug 02, 2023 at 11:51:17AM +0200, Guido Günther wrote: > > Hi, > > On Sun, Jul 30, 2023 at 09:41:20PM +0300, David Heidelberg wrote: > > > i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers > > > requirement of power-domains, thou it's not required. > > > > > > Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document > i.MX8M/i.MX6SX/i.MX6SL power-domains property") > > > > > > Signed-off-by: David Heidelberg <david@ixit.cz> > > > --- > > > .../devicetree/bindings/display/fsl,lcdif.yaml | 11 +++++++++-- > > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > > index fc11ab5fc465..2d868276b0f9 100644 > > > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > > @@ -129,8 +129,15 @@ allOf: > > > - fsl,imx8mp-lcdif > > > - fsl,imx93-lcdif > > > then: > > > - required: > > > - - power-domains > > > + if: > > > + properties: > > > + compatible: > > > + not: > > > + contains: > > > + const: fsl,imx8mq-lcdif > > > + then: > > > + required: > > > + - power-domains > > > > We currently enable the mipi power domain for the mipi dphy and nwl > > bridge only but not for LCDIF itself assuming it's not needed (as there's > > other outputs LCDIF can drive). I *think* this is correct but maybe > > Marek or Liu can confirm? > > I'm happy to Ack this, but I've been sitting on it waiting to see if > Marek or Liu popped up.. I see DCSS and HDMI controller/PHY sit in displaymix in a system bus diagram(internal only), but LCDIF and MIPI DSI controller/PHY are not in that mix. So, it seems that the "gpc_disp" power domain defined in imx8mq.dtsi supplies power for DCSS and HDMI controller/PHY only, though nxp,imx8mq-dcss.yaml doesn't even allow a "power-domains" property... Assuming that system bus diagram is correct and "gpc_disp" power domain does supply power for everything in displaymix only: Reviewed-by: Liu Ying <victor.liu@nxp.com> P.s., there are still a few warnings from dtbs-check, see build log[1]. Hope they can be addressed... [1] https://gitlab.com/robherring/dt-review-ci/-/jobs/4767324570/artifacts/raw/build-dtbs-1814673.log Liu Ying ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement 2023-08-10 19:30 ` Conor Dooley 2023-08-11 3:47 ` Marek Vasut 2023-08-11 5:49 ` Ying Liu @ 2023-08-11 6:53 ` Conor Dooley 2 siblings, 0 replies; 7+ messages in thread From: Conor Dooley @ 2023-08-11 6:53 UTC (permalink / raw) To: Conor Dooley Cc: Guido Günther, David Heidelberg, Marek Vasut, Stefan Agner, David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Liu Ying, kernel, Krzysztof Kozlowski, Rob Herring, dri-devel, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1936 bytes --] On Thu, Aug 10, 2023 at 08:30:21PM +0100, Conor Dooley wrote: > On Wed, Aug 02, 2023 at 11:51:17AM +0200, Guido Günther wrote: > > Hi, > > On Sun, Jul 30, 2023 at 09:41:20PM +0300, David Heidelberg wrote: > > > i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers > > > requirement of power-domains, thou it's not required. > > > > > > Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property") > > > > > > Signed-off-by: David Heidelberg <david@ixit.cz> > > > --- > > > .../devicetree/bindings/display/fsl,lcdif.yaml | 11 +++++++++-- > > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > > index fc11ab5fc465..2d868276b0f9 100644 > > > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > > > @@ -129,8 +129,15 @@ allOf: > > > - fsl,imx8mp-lcdif > > > - fsl,imx93-lcdif > > > then: > > > - required: > > > - - power-domains > > > + if: > > > + properties: > > > + compatible: > > > + not: > > > + contains: > > > + const: fsl,imx8mq-lcdif > > > + then: > > > + required: > > > + - power-domains > > > > We currently enable the mipi power domain for the mipi dphy and nwl > > bridge only but not for LCDIF itself assuming it's not needed (as there's > > other outputs LCDIF can drive). I *think* this is correct but maybe > > Marek or Liu can confirm? > > I'm happy to Ack this, but I've been sitting on it waiting to see if > Marek or Liu popped up.. Well, I got two positive responses, so Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement 2023-07-30 18:41 [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement David Heidelberg 2023-08-02 9:51 ` Guido Günther @ 2023-08-17 15:26 ` Guido Günther 1 sibling, 0 replies; 7+ messages in thread From: Guido Günther @ 2023-08-17 15:26 UTC (permalink / raw) To: David Heidelberg Cc: Marek Vasut, Stefan Agner, David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Liu Ying, kernel, dri-devel, devicetree, linux-kernel Hi, On Sun, Jul 30, 2023 at 09:41:20PM +0300, David Heidelberg wrote: > i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers > requirement of power-domains, thou it's not required. > > Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property") > > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > .../devicetree/bindings/display/fsl,lcdif.yaml | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index fc11ab5fc465..2d868276b0f9 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -129,8 +129,15 @@ allOf: > - fsl,imx8mp-lcdif > - fsl,imx93-lcdif > then: > - required: > - - power-domains > + if: > + properties: > + compatible: > + not: > + contains: > + const: fsl,imx8mq-lcdif > + then: > + required: > + - power-domains > > examples: > - | > -- > 2.40.1 > Thanks a lot to Marek and Liu for confirming! Acked-by: Guido Günther <agx@sigxcpu.org> Cheers, -- Guido ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-08-17 15:27 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-07-30 18:41 [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement David Heidelberg 2023-08-02 9:51 ` Guido Günther 2023-08-10 19:30 ` Conor Dooley 2023-08-11 3:47 ` Marek Vasut 2023-08-11 5:49 ` Ying Liu 2023-08-11 6:53 ` Conor Dooley 2023-08-17 15:26 ` Guido Günther
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).