From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Kent Gustavsson <kent@minoris.se>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Cosmin Tanislav <demonsingur@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
ChiYuan Huang <cy_huang@richtek.com>,
Haibo Chen <haibo.chen@nxp.com>,
Ramona Bolboaca <ramona.bolboaca@analog.com>,
Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
ChiaEn Wu <chiaen_wu@richtek.com>,
William Breathitt Gray <william.gray@linaro.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 6/6] iio: adc: mcp3911: add support for the whole MCP39xx family
Date: Thu, 17 Aug 2023 15:58:43 +0300 [thread overview]
Message-ID: <ZN4Zg235AdYwI70E@smile.fi.intel.com> (raw)
In-Reply-To: <20230817120518.153728-6-marcus.folkesson@gmail.com>
On Thu, Aug 17, 2023 at 02:05:18PM +0200, Marcus Folkesson wrote:
> Microchip does have many similar chips, add support for those.
>
> The new supported chips are:
> - microchip,mcp3910
> - microchip,mcp3912
> - microchip,mcp3913
> - microchip,mcp3914
> - microchip,mcp3918
> - microchip,mcp3919
...
> +static int mcp3910_set_offset(struct mcp3911 *adc, int channel, int val)
> +{
unsigned int mask = MCP3910_CONFIG0_EN_OFFCAL;
> + int ret;
> +
> + /* Write offset */
> + ret = mcp3911_write(adc, MCP3910_OFFCAL(channel), val, 3);
> + if (ret)
> + return ret;
> +
> + /* Enable offset */
> + return mcp3911_update(adc, MCP3910_REG_CONFIG0,
> + MCP3910_CONFIG0_EN_OFFCAL,
> + MCP3910_CONFIG0_EN_OFFCAL, 3);
return mcp3911_update(adc, MCP3910_REG_CONFIG0, mask, mask, 3);
> +}
...
> +static int mcp3911_set_offset(struct mcp3911 *adc, int channel, int val)
> +{
As per above.
> +}
...
> +static int mcp3910_set_osr(struct mcp3911 *adc, u32 val)
> +{
unsigned int mask = MCP3910_CONFIG0_OSR;
> + int osr = FIELD_PREP(MCP3910_CONFIG0_OSR, val);
> +
> + return mcp3911_update(adc, MCP3910_REG_CONFIG0,
> + MCP3910_CONFIG0_OSR, osr, 3);
return mcp3911_update(adc, MCP3910_REG_CONFIG0, mask, osr, 3);
> +}
...
> +static int mcp3911_set_osr(struct mcp3911 *adc, u32 val)
In the similar way.
...
> +static int mcp3910_set_scale(struct mcp3911 *adc, int channel, u32 val)
> +{
> + return mcp3911_update(adc, MCP3910_REG_GAIN,
> + MCP3911_GAIN_MASK(channel),
> + MCP3911_GAIN_VAL(channel, val), 3);
> +}
> +
> +static int mcp3911_set_scale(struct mcp3911 *adc, int channel, u32 val)
> +{
> + return mcp3911_update(adc, MCP3911_REG_GAIN,
> + MCP3911_GAIN_MASK(channel),
> + MCP3911_GAIN_VAL(channel, val), 1);
> +}
These can be also converted, but I don't see much difference
(same LoC amount, similar readability).
...
> + /* Disable offset to ignore any old values in offset register */
> + return mcp3911_update(adc, MCP3910_REG_CONFIG0,
> + MCP3910_CONFIG0_EN_OFFCAL,
> + MCP3910_CONFIG0_EN_OFFCAL, 3);
This is a dup code with some of mcp3910_set_offset(). Perhaps a helper?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-17 12:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 12:05 [PATCH v6 1/6] dt-bindings: iio: adc: mcp3911: add support for the whole MCP39xx family Marcus Folkesson
2023-08-17 12:05 ` [PATCH v6 2/6] iio: adc: mcp3911: make use of dev_err_probe() Marcus Folkesson
2023-08-17 12:05 ` [PATCH v6 3/6] iio: adc: mcp3911: simplify usage of spi->dev Marcus Folkesson
2023-08-17 12:48 ` Andy Shevchenko
2023-08-17 12:05 ` [PATCH v6 4/6] iio: adc: mcp3911: fix indentation Marcus Folkesson
2023-08-17 12:48 ` Andy Shevchenko
2023-08-17 12:05 ` [PATCH v6 5/6] iio: adc: mcp3911: avoid ambiguity parameters in macros Marcus Folkesson
2023-08-17 12:49 ` Andy Shevchenko
2023-08-17 12:05 ` [PATCH v6 6/6] iio: adc: mcp3911: add support for the whole MCP39xx family Marcus Folkesson
2023-08-17 12:58 ` Andy Shevchenko [this message]
2023-08-17 12:42 ` [PATCH v6 1/6] dt-bindings: " Andy Shevchenko
2023-08-17 12:42 ` Andy Shevchenko
2023-08-27 18:24 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN4Zg235AdYwI70E@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Ibrahim.Tilki@analog.com \
--cc=arnd@arndb.de \
--cc=chiaen_wu@richtek.com \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=demonsingur@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=haibo.chen@nxp.com \
--cc=jic23@kernel.org \
--cc=kent@minoris.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=ramona.bolboaca@analog.com \
--cc=robh+dt@kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox