From: John Watts <contact@jookia.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
patches@opensource.cirrus.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ASoC: dt-bindings: wlf,wm8782: Add max-rate property
Date: Sat, 12 Aug 2023 00:26:15 +1000 [thread overview]
Message-ID: <ZNZFB2-kBrpnMSn1@titan> (raw)
In-Reply-To: <ZNY+x/R8/T5ysPhy@finisterre.sirena.org.uk>
On Fri, Aug 11, 2023 at 02:59:35PM +0100, Mark Brown wrote:
> On Fri, Aug 11, 2023 at 08:49:30AM +1000, John Watts wrote:
>
> > + - max-rate : max supported audio rate configured by FSAMPEN pin, defaults to 48000
>
> This seems like a cumbersome and error prone way to configure this - why
> not just have the binding specify the state of the pin? That's just a
> boolean high/low whereas this requires getting the rate right and then
> having the driver validate it.
Hi there, the pin is tristate, Z, 0 and 1. How would that be represented?
John.
next prev parent reply other threads:[~2023-08-11 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 22:49 [PATCH 0/3] ASoC: wm8782: Allow higher audio rates John Watts
2023-08-10 22:49 ` [PATCH 1/3] ASoC: wm8782: Handle maximum audio rate at runtime John Watts
2023-08-10 22:49 ` [PATCH 2/3] ASoC: wm8782: Use max-rate device tree property John Watts
2023-08-10 22:49 ` [PATCH 3/3] ASoC: dt-bindings: wlf,wm8782: Add max-rate property John Watts
2023-08-11 13:59 ` Mark Brown
2023-08-11 14:26 ` John Watts [this message]
2023-08-14 18:27 ` Mark Brown
2023-08-14 21:44 ` John Watts
2023-08-21 17:28 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNZFB2-kBrpnMSn1@titan \
--to=contact@jookia.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).