From: andy.shevchenko@gmail.com
To: TY Chang <tychang@realtek.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] pinctrl: realtek: Add pinctrl driver for RTD1315E
Date: Tue, 15 Aug 2023 00:06:15 +0300 [thread overview]
Message-ID: <ZNqXRyryCSRTM0IA@surfacebook.localdomain> (raw)
In-Reply-To: <20230726090409.16606-3-tychang@realtek.com>
Wed, Jul 26, 2023 at 05:04:04PM +0800, TY Chang kirjoitti:
> Add RTD1315E support using realtek common pinctrl driver.
...
> +config PINCTRL_RTD1315E
> + tristate "Realtek DHC 1315E pin controller driver"
> + depends on PINCTRL_RTD
Why not select and the above be hidden symbol?
...
> +#include <linux/module.h>
> +#include <linux/of.h>
Not used. Use correct headers
> +#include <linux/platform_device.h>
+ Blank line
> +#include <linux/pinctrl/pinctrl.h>
Make use of struct pinconfig, struct pinfunction and respective PINCTRL_PIN*()
macros.
...
> +#define RTD1315E_GROUP(_name) \
> + { \
> + .name = # _name, \
> + .pins = rtd1315e_ ## _name ## _pins, \
> + .num_pins = ARRAY_SIZE(rtd1315e_ ## _name ## _pins), \
> + }
NIH PINCTRL_PINGROUP().
...
> +#define RTD1315E_FUNC(_name) \
> + { \
> + .name = # _name, \
> + .groups = rtd1315e_ ## _name ## _groups, \
> + .num_groups = ARRAY_SIZE(rtd1315e_ ## _name ## _groups), \
> + }
NIH PINCTRL_PINFUNCTION().
...
> +static const struct of_device_id rtd1315e_pinctrl_of_match[] = {
> + { .compatible = "realtek,rtd13xxe-pinctrl", },
> + {},
No comma for the terminator entry.
> +};
...
Same comments for all new drivers in the series.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-14 21:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 9:04 [PATCH 0/7] Add pinctrl driver support for Realtek DHC SoCs TY Chang
2023-07-26 9:04 ` [PATCH 1/7] pinctrl: realtek: Add common pinctrl driver for Realtek DHC RTD SoCs TY Chang
2023-08-14 21:29 ` andy.shevchenko
2023-07-26 9:04 ` [PATCH 2/7] pinctrl: realtek: Add pinctrl driver for RTD1315E TY Chang
2023-08-14 21:06 ` andy.shevchenko [this message]
2023-07-26 9:04 ` [PATCH 3/7] pinctrl: realtek: Add pinctrl driver for RTD1319D TY Chang
2023-07-26 9:04 ` [PATCH 4/7] pinctrl: realtek: Add pinctrl driver for RTD1619B TY Chang
2023-07-26 9:04 ` [PATCH 5/7] dt-bindings: pinctrl: realtek: add RTD1315E pinctrl binding TY Chang
2023-08-03 0:33 ` Rob Herring
2023-08-14 6:49 ` TY_Chang[張子逸]
2023-08-07 12:52 ` Linus Walleij
2023-08-23 7:56 ` TY_Chang[張子逸]
2023-07-26 9:04 ` [PATCH 6/7] dt-bindings: pinctrl: realtek: add RTD1319D " TY Chang
2023-07-26 9:04 ` [PATCH 7/7] dt-bindings: pinctrl: realtek: add RTD1619B " TY Chang
2023-07-26 11:52 ` Rob Herring
2023-07-27 8:22 ` TY_Chang[張子逸]
2023-07-26 14:15 ` Rob Herring
2023-07-27 10:03 ` TY_Chang[張子逸]
2023-08-07 12:55 ` [PATCH 0/7] Add pinctrl driver support for Realtek DHC SoCs Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNqXRyryCSRTM0IA@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tychang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox