From: Richard Acayan <mailingradian@gmail.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFT 2/6] arm64: dts: qcom: sdm670: Add PDC
Date: Tue, 15 Aug 2023 21:31:48 -0400 [thread overview]
Message-ID: <ZNwnBIDGZi11QT0P@radian> (raw)
In-Reply-To: <20230811-topic-tlmm_wakeup-v1-2-5616a7da1fff@linaro.org>
On Fri, Aug 11, 2023 at 10:48:35PM +0200, Konrad Dybcio wrote:
> Add support for the PDC to enable deep sleep wakeup from external sources.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
Apologies for not testing this. I am not subscribed to the mailing list
and just found this patch. You may CC me or ping me on #linux-msm if you
want anything tested on SDM670 hardware.
> arch/arm64/boot/dts/qcom/sdm670.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi
> index a1c207c0266d..da10f0a6d92e 100644
> --- a/arch/arm64/boot/dts/qcom/sdm670.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi
> @@ -1169,6 +1169,16 @@ usb_1_dwc3: usb@a600000 {
> };
> };
>
> + pdc: interrupt-controller@b220000 {
> + compatible = "qcom,sdm670-pdc", "qcom,pdc";
> + reg = <0 0x0b220000 0 0x30000>;
> + qcom,pdc-ranges = <0 480 40>, <41 521 7>, <49 529 4>,
> + <54 534 24>, <79 559 30>, <115 630 7>;
The <79 559 30> range is not continuous, just like on SDM845. While PDC
interrupt 93 is on hwirq 573, PDC interrupt 94 is on hwirq 609.
Another patch is needed to fix this because this was already applied.
This does not cause a regression, though, because the pinctrl driver has
no wakeirq map yet.
https://android.googlesource.com/kernel/msm/+/d8e93ac1450a783fc095f082b0e5324cedee2e75/drivers/irqchip/qcom/pdc-sdm670.c#108
> + #interrupt-cells = <2>;
> + interrupt-parent = <&intc>;
> + interrupt-controller;
> + };
> +
> spmi_bus: spmi@c440000 {
> compatible = "qcom,spmi-pmic-arb";
> reg = <0 0x0c440000 0 0x1100>,
>
> --
> 2.41.0
>
next prev parent reply other threads:[~2023-08-16 1:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 20:48 [PATCH 0/6] Add missing wakeup-parent to TLMM Konrad Dybcio
2023-08-11 20:48 ` [PATCH 1/6] dt-bindings: interrupt-controller: qcom,pdc: Add SDM670 Konrad Dybcio
2023-08-14 19:27 ` Krzysztof Kozlowski
2023-08-17 18:04 ` Rob Herring
2023-08-11 20:48 ` [PATCH RFT 2/6] arm64: dts: qcom: sdm670: Add PDC Konrad Dybcio
2023-08-16 1:31 ` Richard Acayan [this message]
2023-08-11 20:48 ` [PATCH 3/6] arm64: dts: qcom: sc8280xp: Hook up PDC as wakeup-parent of TLMM Konrad Dybcio
2023-08-11 20:48 ` [PATCH 4/6] arm64: dts: qcom: sa8775p: " Konrad Dybcio
2023-08-11 20:48 ` [PATCH 5/6] arm64: dts: qcom: sdm670: " Konrad Dybcio
2023-08-11 20:48 ` [PATCH 6/6] arm64: dts: qcom: sm6350: " Konrad Dybcio
2023-08-15 18:49 ` (subset) [PATCH 0/6] Add missing wakeup-parent to TLMM Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNwnBIDGZi11QT0P@radian \
--to=mailingradian@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).