From: Thierry Reding <thierry.reding@gmail.com>
To: Brad Griffis <bgriffis@nvidia.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64: tegra: fix p3767 card detect polarity
Date: Wed, 16 Aug 2023 18:18:46 +0200 [thread overview]
Message-ID: <ZNz25l6UGK2eNMWg@orome> (raw)
In-Reply-To: <CH2PR12MB42783D51FD5FD9327C8EBE43AC14A@CH2PR12MB4278.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]
On Tue, Aug 15, 2023 at 01:37:40PM +0000, Brad Griffis wrote:
> On Fri, Jul 21, 2023 at 6:22 AM +0000, Thierry Reding wrote:
> > On Mon, Jun 26, 2023 at 06:09:19PM +0000, Brad Griffis wrote:
> > > The card detect pin on Orin Nano SKU5 (p3767-0005) is active-low.
> > >
> > > Fixes: 13b0aca303e9 ("arm64: tegra: Support Jetson Orin NX")
> > > Signed-off-by: Brad Griffis <bgriffis@nvidia.com>
> > > ---
> > > arch/arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > This DTS include is also used by Jetson Orin NX, but I assume that the same
> > polarity applies to that as well?
>
> The polarity is the same for all Orin NX/Nano modules that have SD card.
>
> > Actually, looking at the Orin NX, I don't see an SD card slot and judging by the
> > documentation that I was able to find it's not documented for Orin Nano
> > either. Or is it only certain variants that were equipped with the SD slot?
>
> UEFI dynamically disables this mmc instance on SKUs that do not support it.
Okay, good. I've adjusted the commit message a tiny little bit to
clarify that this applies to all NX/Nano SKUs that have an SD card slot
equipped.
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-08-16 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 18:09 [PATCH 1/2] arm64: tegra: fix p3767 card detect polarity Brad Griffis
2023-06-26 18:09 ` [PATCH 2/2] arm64: tegra: fix p3767 QSPI speed Brad Griffis
2023-07-21 6:26 ` Thierry Reding
2023-08-15 13:38 ` Brad Griffis
2023-08-16 16:17 ` Thierry Reding
2023-07-21 6:21 ` [PATCH 1/2] arm64: tegra: fix p3767 card detect polarity Thierry Reding
2023-08-15 13:37 ` Brad Griffis
2023-08-16 16:18 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNz25l6UGK2eNMWg@orome \
--to=thierry.reding@gmail.com \
--cc=bgriffis@nvidia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).