From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A4FBC001E0 for ; Wed, 16 Aug 2023 15:52:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235270AbjHPPw0 (ORCPT ); Wed, 16 Aug 2023 11:52:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344461AbjHPPwO (ORCPT ); Wed, 16 Aug 2023 11:52:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF5F626AD; Wed, 16 Aug 2023 08:52:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 534E066B4B; Wed, 16 Aug 2023 15:52:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 891AEC433C8; Wed, 16 Aug 2023 15:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692201131; bh=TIjmNB9p3Z/mYIestCCsQETqQqkBVHq59rkmx1l98tA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NmQqVHOpb7712AfKgM+B5SW3Twh3u+wfuMdaMR2kdraPNtxc51ZTVcveQS/KsnlI7 z5d8o/ARnKgq2cHsoOamkNT7PcIXW/dfBNvMYNyE17sOZpCv6JH9zLXj+iR1RzH6sN +10ByFqwsvqIalj7HygKCrPScZ1NhSqy9RBtaYuTNq4Ne4eaw7lf3qy2TR+8Xwdh7q oVzdbYk5sIhqrwe7MxDX8MuALkWgLbeVCqO/RWvXIJpuvPF6YHTuq2MJQE22mCN4LB j7y0XTEuhaZd+4mqnlR5YrS3t/2aTcEC+Wfu0Q2OvoL/FuzYabSBlIEIH4Jsbc0/qn EverZ1UpwQCnw== Date: Wed, 16 Aug 2023 23:40:25 +0800 From: Jisheng Zhang To: "G Thomas, Rohan" Cc: "alexandre.torgue@foss.st.com" , "conor+dt@kernel.org" , "davem@davemloft.net" , "devicetree@vger.kernel.org" , "edumazet@google.com" , "joabreu@synopsys.com" , "krzysztof.kozlowski+dt@linaro.org" , "kuba@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "netdev@vger.kernel.org" , "pabeni@redhat.com" , "peppe.cavallaro@st.com" , "robh+dt@kernel.org" Subject: Re: [PATCH net-next v3 03/10] net: stmmac: mdio: enlarge the max XGMAC C22 ADDR to 31 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Aug 13, 2023 at 02:18:27PM +0000, G Thomas, Rohan wrote: > > On 8/9/23 18:50, Jisheng Zhang wrote: > > The IP can support up to 31 xgmac c22 addresses now. > > > > Signed-off-by: Jisheng Zhang > > --- > > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > > index 3db1cb0fd160..e6d8e34fafef 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > > @@ -40,7 +40,7 @@ > > #define MII_XGMAC_WRITE (1 << MII_XGMAC_CMD_SHIFT) > > #define MII_XGMAC_READ (3 << MII_XGMAC_CMD_SHIFT) > > #define MII_XGMAC_BUSY BIT(22) > > -#define MII_XGMAC_MAX_C22ADDR 3 > > +#define MII_XGMAC_MAX_C22ADDR 31 > > #define MII_XGMAC_C22P_MASK GENMASK(MII_XGMAC_MAX_C22ADDR, 0) > > #define MII_XGMAC_PA_SHIFT 16 > > #define MII_XGMAC_DA_SHIFT 21 > > Recent commit 10857e677905 ("net: stmmac: XGMAC support for mdio C22 > addr > 3") already addressed this in a different way. As per Synopsis > IP team until version 2.2, XGMAC supports only MDIO devices 0 - 3. An I didn't find your patch in mailist when I submit the v1 on 23 July, in fact my series was earlier than yours. > XGMAC IP version check is newly added for the same reason. I think this > covers your commit also. Please have a look and if so you can drop this > commit. Dropped in new version. > > BR, > Rohan >