[PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode

[PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode

[Jim Quinlan]

[-- Attachment #1: Type: text/plain, Size: 3487 bytes --]

v6 -- No code has been changed.
   -- Changed commit subject and comment in "#PERST" commit (Bjorn, Cyril)
   -- Changed sign-off and author email address for all commits.
      This was due to a change in Broadcom's upstreaming policy.

v5 -- Remove DT property "brcm,completion-timeout-us" from	 
      "DT bindings" commit.  Although this error may be reported	 
      as a completion timeout, its cause was traced to an	 
      internal bus timeout which may occur even when there is	 
      no PCIe access being processed.  We set a timeout of four	 
      seconds only if we are operating in "L1SS CLKREQ#" mode.
   -- Correct CEM 2.0 reference provided by HW engineer,
      s/3.2.5.2.5/3.2.5.2.2/ (Bjorn)
   -- Add newline to dev_info() string (Stefan)
   -- Change variable rval to unsigned (Stefan)
   -- s/implementaion/implementation/ (Bjorn)
   -- s/superpowersave/powersupersave/ (Bjorn)
   -- Slightly modify message on "PERST#" commit.
   -- Rebase to torvalds master

v4 -- New commit that asserts PERST# for 2711/RPi SOCs at PCIe RC
      driver probe() time.  This is done in Raspian Linux and its
      absence may be the cause of a failing test case.
   -- New commit that removes stale comment.

v3 -- Rewrote commit msgs and comments refering panics if L1SS
      is enabled/disabled; the code snippet that unadvertises L1SS
      eliminates the panic scenario. (Bjorn)
   -- Add reference for "400ns of CLKREQ# assertion" blurb (Bjorn)
   -- Put binding names in DT commit Subject (Bjorn)
   -- Add a verb to a commit's subject line (Bjorn)
   -- s/accomodat(\w+)/accommodat$1/g (Bjorn)
   -- Rewrote commit msgs and comments refering panics if L1SS
      is enabled/disabled; the code snippet that unadvertises L1SS
      eliminates the panic scenario. (Bjorn)

v2 -- Changed binding property 'brcm,completion-timeout-msec' to
      'brcm,completion-timeout-us'.  (StefanW for standard suffix).
   -- Warn when clamping timeout value, and include clamped
      region in message. Also add min and max in YAML. (StefanW)
   -- Qualify description of "brcm,completion-timeout-us" so that
      it refers to PCIe transactions. (StefanW)
   -- Remvove mention of Linux specifics in binding description. (StefanW)
   -- s/clkreq#/CLKREQ#/g (Bjorn)
   -- Refactor completion-timeout-us code to compare max and min to
      value given by the property (as opposed to the computed value).

v1 -- The current driver assumes the downstream devices can
      provide CLKREQ# for ASPM.  These commits accomodate devices
      w/ or w/o clkreq# and also handle L1SS-capable devices.

   -- The Raspian Linux folks have already been using a PCIe RC
      property "brcm,enable-l1ss".  These commits use the same
      property, in a backward-compatible manner, and the implementaion
      adds more detail and also automatically identifies devices w/o
      a clkreq# signal, i.e. most devices plugged into an RPi CM4
      IO board.


Jim Quinlan (5):
  dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property
  PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream
    device
  PCI: brcmstb: Set higher value for internal bus timeout
  PCI: brcmstb: Assert PERST# on BCM2711
  PCI: brcmstb: Remove stale comment

 .../bindings/pci/brcm,stb-pcie.yaml           |  9 ++
 drivers/pci/controller/pcie-brcmstb.c         | 91 ++++++++++++++++---
 2 files changed, 89 insertions(+), 11 deletions(-)


base-commit: 8a28a0b6f1a1dcbf5a834600a9acfbe2ba51e5eb
-- 
2.17.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4210 bytes --]

[PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property

[Jim Quinlan]

[-- Attachment #1: Type: text/plain, Size: 2221 bytes --]

This commit adds the boolean "brcm,enable-l1ss" property:

  The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
  requires the driver probe() to deliberately place the HW one of three
  CLKREQ# modes:

  (a) CLKREQ# driven by the RC unconditionally
  (b) CLKREQ# driven by the EP for ASPM L0s, L1
  (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).

  The HW+driver can tell the difference between downstream devices that
  need (a) and (b), but does not know when to configure (c).  All devices
  should work fine when the driver chooses (a) or (b), but (c) may be
  desired to realize the extra power savings that L1SS offers.  So we
  introduce the boolean "brcm,enable-l1ss" property to inform the driver
  that (c) is desired.  Setting this property only makes sense when the
  downstream device is L1SS-capable and the OS is configured to activate
  this mode (e.g. policy==powersupersave).

  This property is already present in the Raspian version of Linux, but the
  upstream driver implementation that follows adds more details and
  discerns between (a) and (b).

Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
index 7e15aae7d69e..8b61c2179608 100644
--- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
@@ -64,6 +64,15 @@ properties:
 
   aspm-no-l0s: true
 
+  brcm,enable-l1ss:
+    description: Indicates that PCIe L1SS power savings
+      are desired, the downstream device is L1SS-capable, and the
+      OS has been configured to enable this mode.  For boards
+      using a mini-card connector, this mode may not meet the
+      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
+      of the PCI Express Mini CEM 2.0 specification.
+    type: boolean
+
   brcm,scb-sizes:
     description: u64 giving the 64bit PCIe memory
       viewport size of a memory controller.  There may be up to
-- 
2.17.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4210 bytes --]

Re: [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property

[Lorenzo Pieralisi]

On Fri, Jun 23, 2023 at 10:40:54AM -0400, Jim Quinlan wrote:
> This commit adds the boolean "brcm,enable-l1ss" property:
> 
>   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
>   requires the driver probe() to deliberately place the HW one of three
>   CLKREQ# modes:
> 
>   (a) CLKREQ# driven by the RC unconditionally
>   (b) CLKREQ# driven by the EP for ASPM L0s, L1
>   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> 
>   The HW+driver can tell the difference between downstream devices that
>   need (a) and (b), but does not know when to configure (c).  All devices
>   should work fine when the driver chooses (a) or (b), but (c) may be
>   desired to realize the extra power savings that L1SS offers.  So we
>   introduce the boolean "brcm,enable-l1ss" property to inform the driver
>   that (c) is desired.  Setting this property only makes sense when the
>   downstream device is L1SS-capable and the OS is configured to activate
>   this mode (e.g. policy==powersupersave).
> 
>   This property is already present in the Raspian version of Linux, but the
>   upstream driver implementation that follows adds more details and
>   discerns between (a) and (b).
> 
> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 7e15aae7d69e..8b61c2179608 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -64,6 +64,15 @@ properties:
>  
>    aspm-no-l0s: true
>  
> +  brcm,enable-l1ss:
> +    description: Indicates that PCIe L1SS power savings
> +      are desired, the downstream device is L1SS-capable, and the
> +      OS has been configured to enable this mode.  For boards

What does this mean ? I don't think DT properties are supposed
to carry information related to how the OS is configured.

Again - it depends on what DT should be used for, I am not claiming to
have any authority on that, just asking.

Thanks,
Lorenzo

> +      using a mini-card connector, this mode may not meet the
> +      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
> +      of the PCI Express Mini CEM 2.0 specification.
> +    type: boolean
> +
>    brcm,scb-sizes:
>      description: u64 giving the 64bit PCIe memory
>        viewport size of a memory controller.  There may be up to
> -- 
> 2.17.1
> 

Re: [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property

[Jim Quinlan]

[-- Attachment #1: Type: text/plain, Size: 3510 bytes --]

On Mon, Aug 21, 2023 at 10:47 AM Lorenzo Pieralisi
<lpieralisi@kernel.org> wrote:
>
> On Fri, Jun 23, 2023 at 10:40:54AM -0400, Jim Quinlan wrote:
> > This commit adds the boolean "brcm,enable-l1ss" property:
> >
> >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> >   requires the driver probe() to deliberately place the HW one of three
> >   CLKREQ# modes:
> >
> >   (a) CLKREQ# driven by the RC unconditionally
> >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> >
> >   The HW+driver can tell the difference between downstream devices that
> >   need (a) and (b), but does not know when to configure (c).  All devices
> >   should work fine when the driver chooses (a) or (b), but (c) may be
> >   desired to realize the extra power savings that L1SS offers.  So we
> >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> >   that (c) is desired.  Setting this property only makes sense when the
> >   downstream device is L1SS-capable and the OS is configured to activate
> >   this mode (e.g. policy==powersupersave).
> >
> >   This property is already present in the Raspian version of Linux, but the
> >   upstream driver implementation that follows adds more details and
> >   discerns between (a) and (b).
> >
> > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > index 7e15aae7d69e..8b61c2179608 100644
> > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > @@ -64,6 +64,15 @@ properties:
> >
> >    aspm-no-l0s: true
> >
> > +  brcm,enable-l1ss:
> > +    description: Indicates that PCIe L1SS power savings
> > +      are desired, the downstream device is L1SS-capable, and the
> > +      OS has been configured to enable this mode.  For boards
>
> What does this mean ? I don't think DT properties are supposed
> to carry information related to how the OS is configured.

The DT setting in question is unrelated to the statement "and the OS
has been configured to
enable this mode".

This is merely saying that even if you enable "brcm,l1ss-enable"
that you may not get L1SS power savings w/o setting
"CONFIG_PCIEASPM_POWER_SUPERSAVE=y".
I mentioned that exact term but a reviewer nakked it because
apparently DT descriptions should not be OS specific.

I am actually open for this to be a command-line option but I wanted to honor
what the Raspian OS folks have already done.  RaspianOS already has
"brcm,enable-l1ss"
set in their DTS files.

Regards,
Jim

> Again - it depends on what DT should be used for, I am not claiming to
> have any authority on that, just asking.
>
> Thanks,
> Lorenzo
>
> > +      using a mini-card connector, this mode may not meet the
> > +      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
> > +      of the PCI Express Mini CEM 2.0 specification.
> > +    type: boolean
> > +
> >    brcm,scb-sizes:
> >      description: u64 giving the 64bit PCIe memory
> >        viewport size of a memory controller.  There may be up to
> > --
> > 2.17.1
> >
>
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4210 bytes --]

Re: [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property

[Lorenzo Pieralisi]

On Mon, Aug 21, 2023 at 11:25:11AM -0400, Jim Quinlan wrote:
> On Mon, Aug 21, 2023 at 10:47 AM Lorenzo Pieralisi
> <lpieralisi@kernel.org> wrote:
> >
> > On Fri, Jun 23, 2023 at 10:40:54AM -0400, Jim Quinlan wrote:
> > > This commit adds the boolean "brcm,enable-l1ss" property:
> > >
> > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > >   requires the driver probe() to deliberately place the HW one of three
> > >   CLKREQ# modes:
> > >
> > >   (a) CLKREQ# driven by the RC unconditionally
> > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > >
> > >   The HW+driver can tell the difference between downstream devices that
> > >   need (a) and (b), but does not know when to configure (c).  All devices
> > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > >   desired to realize the extra power savings that L1SS offers.  So we
> > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > >   that (c) is desired.  Setting this property only makes sense when the
> > >   downstream device is L1SS-capable and the OS is configured to activate
> > >   this mode (e.g. policy==powersupersave).
> > >
> > >   This property is already present in the Raspian version of Linux, but the
> > >   upstream driver implementation that follows adds more details and
> > >   discerns between (a) and (b).
> > >
> > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > ---
> > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > >  1 file changed, 9 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > index 7e15aae7d69e..8b61c2179608 100644
> > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > @@ -64,6 +64,15 @@ properties:
> > >
> > >    aspm-no-l0s: true
> > >
> > > +  brcm,enable-l1ss:
> > > +    description: Indicates that PCIe L1SS power savings
> > > +      are desired, the downstream device is L1SS-capable, and the
> > > +      OS has been configured to enable this mode.  For boards
> >
> > What does this mean ? I don't think DT properties are supposed
> > to carry information related to how the OS is configured.
> 
> The DT setting in question is unrelated to the statement "and the OS
> has been configured to
> enable this mode".
> 
> This is merely saying that even if you enable "brcm,l1ss-enable"
> that you may not get L1SS power savings w/o setting
> "CONFIG_PCIEASPM_POWER_SUPERSAVE=y".
> I mentioned that exact term but a reviewer nakked it because
> apparently DT descriptions should not be OS specific.
> 
> I am actually open for this to be a command-line option but I wanted to honor
> what the Raspian OS folks have already done.  RaspianOS already has
> "brcm,enable-l1ss"
> set in their DTS files.

This is about the mainline kernel, I don't have any visibility into
downstream kernels (where that property management was added without DT
and PCI maintainers supervision).

Raspian OS folks' choice is theirs but it can't and it shouldn't override
the mainline review process even though I understand the position you
are in.

Thanks,
Lorenzo

> 
> Regards,
> Jim
> 
> > Again - it depends on what DT should be used for, I am not claiming to
> > have any authority on that, just asking.
> >
> > Thanks,
> > Lorenzo
> >
> > > +      using a mini-card connector, this mode may not meet the
> > > +      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
> > > +      of the PCI Express Mini CEM 2.0 specification.
> > > +    type: boolean
> > > +
> > >    brcm,scb-sizes:
> > >      description: u64 giving the 64bit PCIe memory
> > >        viewport size of a memory controller.  There may be up to
> > > --
> > > 2.17.1
> > >
> >
> >

Re: [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property

[Jim Quinlan]

[-- Attachment #1: Type: text/plain, Size: 5354 bytes --]

On Mon, Aug 21, 2023 at 11:41 AM Lorenzo Pieralisi
<lpieralisi@kernel.org> wrote:
>
> On Mon, Aug 21, 2023 at 11:25:11AM -0400, Jim Quinlan wrote:
> > On Mon, Aug 21, 2023 at 10:47 AM Lorenzo Pieralisi
> > <lpieralisi@kernel.org> wrote:
> > >
> > > On Fri, Jun 23, 2023 at 10:40:54AM -0400, Jim Quinlan wrote:
> > > > This commit adds the boolean "brcm,enable-l1ss" property:
> > > >
> > > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > > >   requires the driver probe() to deliberately place the HW one of three
> > > >   CLKREQ# modes:
> > > >
> > > >   (a) CLKREQ# driven by the RC unconditionally
> > > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > > >
> > > >   The HW+driver can tell the difference between downstream devices that
> > > >   need (a) and (b), but does not know when to configure (c).  All devices
> > > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > > >   desired to realize the extra power savings that L1SS offers.  So we
> > > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > > >   that (c) is desired.  Setting this property only makes sense when the
> > > >   downstream device is L1SS-capable and the OS is configured to activate
> > > >   this mode (e.g. policy==powersupersave).
> > > >
> > > >   This property is already present in the Raspian version of Linux, but the
> > > >   upstream driver implementation that follows adds more details and
> > > >   discerns between (a) and (b).
> > > >
> > > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > ---
> > > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > > >  1 file changed, 9 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > index 7e15aae7d69e..8b61c2179608 100644
> > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > @@ -64,6 +64,15 @@ properties:
> > > >
> > > >    aspm-no-l0s: true
> > > >
> > > > +  brcm,enable-l1ss:
> > > > +    description: Indicates that PCIe L1SS power savings
> > > > +      are desired, the downstream device is L1SS-capable, and the
> > > > +      OS has been configured to enable this mode.  For boards
> > >
> > > What does this mean ? I don't think DT properties are supposed
> > > to carry information related to how the OS is configured.
> >
> > The DT setting in question is unrelated to the statement "and the OS
> > has been configured to
> > enable this mode".
> >
> > This is merely saying that even if you enable "brcm,l1ss-enable"
> > that you may not get L1SS power savings w/o setting
> > "CONFIG_PCIEASPM_POWER_SUPERSAVE=y".
> > I mentioned that exact term but a reviewer nakked it because
> > apparently DT descriptions should not be OS specific.
> >
> > I am actually open for this to be a command-line option but I wanted to honor
> > what the Raspian OS folks have already done.  RaspianOS already has
> > "brcm,enable-l1ss"
> > set in their DTS files.
>
> This is about the mainline kernel, I don't have any visibility into
> downstream kernels (where that property management was added without DT
> and PCI maintainers supervision).
>
> Raspian OS folks' choice is theirs but it can't and it shouldn't override
> the mainline review process even though I understand the position you
> are in.

Understood, but using the command line has its warts as well; I now recall the
discussion Bjorn and I  had regarding this option.  I'm pretty sure
that upstreaam will not allow the following
possible command line kernel params:

    brcm,enable-l1ss
    pci=brcm,entable-l1ss

Bjorn suggested using the  documented but (IMO) obscure  and  rarely
used  format

    pci=[<domain>:]<bus>:<dev>.<func>[/<dev>.<func>]*pci:<vendor>:<device>[:<subvendor>:<subdevice>]

but this is just going in the wrong direction; here's why.  Using the
above iformat s completely dependent on the
PCI "linux-domaiin"  property,  a non-HW related DT property I  might
add.  Since "linux-domain" is already
a valid and well-used  DT property, and the value of  the above
command line format is dependent
on the value of the "linux-domain", why not be consistent and let
"brcm,enable-l1ss" be a Broadcom specific property?

Regards,
Jim Quinlan
Broadcom STB/CM


>
> Thanks,
> Lorenzo
>
> >
> > Regards,
> > Jim
> >
> > > Again - it depends on what DT should be used for, I am not claiming to
> > > have any authority on that, just asking.
> > >
> > > Thanks,
> > > Lorenzo
> > >
> > > > +      using a mini-card connector, this mode may not meet the
> > > > +      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
> > > > +      of the PCI Express Mini CEM 2.0 specification.
> > > > +    type: boolean
> > > > +
> > > >    brcm,scb-sizes:
> > > >      description: u64 giving the 64bit PCIe memory
> > > >        viewport size of a memory controller.  There may be up to
> > > > --
> > > > 2.17.1
> > > >
> > >
> > >
>
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4210 bytes --]

Re: [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property

[Lorenzo Pieralisi]

On Mon, Aug 21, 2023 at 12:01:50PM -0400, Jim Quinlan wrote:
> On Mon, Aug 21, 2023 at 11:41 AM Lorenzo Pieralisi
> <lpieralisi@kernel.org> wrote:
> >
> > On Mon, Aug 21, 2023 at 11:25:11AM -0400, Jim Quinlan wrote:
> > > On Mon, Aug 21, 2023 at 10:47 AM Lorenzo Pieralisi
> > > <lpieralisi@kernel.org> wrote:
> > > >
> > > > On Fri, Jun 23, 2023 at 10:40:54AM -0400, Jim Quinlan wrote:
> > > > > This commit adds the boolean "brcm,enable-l1ss" property:
> > > > >
> > > > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > > > >   requires the driver probe() to deliberately place the HW one of three
> > > > >   CLKREQ# modes:
> > > > >
> > > > >   (a) CLKREQ# driven by the RC unconditionally
> > > > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > > > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > > > >
> > > > >   The HW+driver can tell the difference between downstream devices that
> > > > >   need (a) and (b), but does not know when to configure (c).  All devices
> > > > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > > > >   desired to realize the extra power savings that L1SS offers.  So we
> > > > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > > > >   that (c) is desired.  Setting this property only makes sense when the
> > > > >   downstream device is L1SS-capable and the OS is configured to activate
> > > > >   this mode (e.g. policy==powersupersave).
> > > > >
> > > > >   This property is already present in the Raspian version of Linux, but the
> > > > >   upstream driver implementation that follows adds more details and
> > > > >   discerns between (a) and (b).
> > > > >
> > > > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> > > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > > ---
> > > > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > > > >  1 file changed, 9 insertions(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > index 7e15aae7d69e..8b61c2179608 100644
> > > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > @@ -64,6 +64,15 @@ properties:
> > > > >
> > > > >    aspm-no-l0s: true
> > > > >
> > > > > +  brcm,enable-l1ss:
> > > > > +    description: Indicates that PCIe L1SS power savings
> > > > > +      are desired, the downstream device is L1SS-capable, and the
> > > > > +      OS has been configured to enable this mode.  For boards
> > > >
> > > > What does this mean ? I don't think DT properties are supposed
> > > > to carry information related to how the OS is configured.
> > >
> > > The DT setting in question is unrelated to the statement "and the OS
> > > has been configured to
> > > enable this mode".
> > >
> > > This is merely saying that even if you enable "brcm,l1ss-enable"
> > > that you may not get L1SS power savings w/o setting
> > > "CONFIG_PCIEASPM_POWER_SUPERSAVE=y".
> > > I mentioned that exact term but a reviewer nakked it because
> > > apparently DT descriptions should not be OS specific.
> > >
> > > I am actually open for this to be a command-line option but I wanted to honor
> > > what the Raspian OS folks have already done.  RaspianOS already has
> > > "brcm,enable-l1ss"
> > > set in their DTS files.
> >
> > This is about the mainline kernel, I don't have any visibility into
> > downstream kernels (where that property management was added without DT
> > and PCI maintainers supervision).
> >
> > Raspian OS folks' choice is theirs but it can't and it shouldn't override
> > the mainline review process even though I understand the position you
> > are in.
> 
> Understood, but using the command line has its warts as well; I now recall the
> discussion Bjorn and I  had regarding this option.  I'm pretty sure
> that upstreaam will not allow the following
> possible command line kernel params:
> 
>     brcm,enable-l1ss
>     pci=brcm,entable-l1ss
> 
> Bjorn suggested using the  documented but (IMO) obscure  and  rarely
> used  format
> 
>     pci=[<domain>:]<bus>:<dev>.<func>[/<dev>.<func>]*pci:<vendor>:<device>[:<subvendor>:<subdevice>]
> 
> but this is just going in the wrong direction; here's why.  Using the
> above iformat s completely dependent on the
> PCI "linux-domaiin"  property,  a non-HW related DT property I  might
> add.  Since "linux-domain" is already
> a valid and well-used  DT property, and the value of  the above
> command line format is dependent
> on the value of the "linux-domain", why not be consistent and let
> "brcm,enable-l1ss" be a Broadcom specific property?

I am just asking to add a module_param to the host controller driver.

Anyway - time is running out for v6.6, I need Rob's feedback, if I don't
hear from him today I will merge the last three patches and postpone the
discussion.

Thanks,
Lorenzo

> 
> Regards,
> Jim Quinlan
> Broadcom STB/CM
> 
> 
> >
> > Thanks,
> > Lorenzo
> >
> > >
> > > Regards,
> > > Jim
> > >
> > > > Again - it depends on what DT should be used for, I am not claiming to
> > > > have any authority on that, just asking.
> > > >
> > > > Thanks,
> > > > Lorenzo
> > > >
> > > > > +      using a mini-card connector, this mode may not meet the
> > > > > +      TCRLon maximum time of 400ns, as specified in 3.2.5.2.2
> > > > > +      of the PCI Express Mini CEM 2.0 specification.
> > > > > +    type: boolean
> > > > > +
> > > > >    brcm,scb-sizes:
> > > > >      description: u64 giving the 64bit PCIe memory
> > > > >        viewport size of a memory controller.  There may be up to
> > > > > --
> > > > > 2.17.1
> > > > >
> > > >
> > > >
> >
> >

Re: [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property

[Bjorn Helgaas]

On Wed, Aug 23, 2023 at 09:30:48AM +0200, Lorenzo Pieralisi wrote:
> On Mon, Aug 21, 2023 at 12:01:50PM -0400, Jim Quinlan wrote:
> > On Mon, Aug 21, 2023 at 11:41 AM Lorenzo Pieralisi
> > <lpieralisi@kernel.org> wrote:
> > > On Mon, Aug 21, 2023 at 11:25:11AM -0400, Jim Quinlan wrote:
> > > > On Mon, Aug 21, 2023 at 10:47 AM Lorenzo Pieralisi
> > > > <lpieralisi@kernel.org> wrote:
> > > > > On Fri, Jun 23, 2023 at 10:40:54AM -0400, Jim Quinlan wrote:
> > > > > > This commit adds the boolean "brcm,enable-l1ss" property:
> > > > > >
> > > > > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > > > > >   requires the driver probe() to deliberately place the HW one of three
> > > > > >   CLKREQ# modes:
> > > > > >
> > > > > >   (a) CLKREQ# driven by the RC unconditionally
> > > > > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > > > > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > > > > >
> > > > > >   The HW+driver can tell the difference between downstream devices that
> > > > > >   need (a) and (b), but does not know when to configure (c).  All devices
> > > > > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > > > > >   desired to realize the extra power savings that L1SS offers.  So we
> > > > > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > > > > >   that (c) is desired.  Setting this property only makes sense when the
> > > > > >   downstream device is L1SS-capable and the OS is configured to activate
> > > > > >   this mode (e.g. policy==powersupersave).
> > > > > >
> > > > > >   This property is already present in the Raspian version of Linux, but the
> > > > > >   upstream driver implementation that follows adds more details and
> > > > > >   discerns between (a) and (b).
> > > > > >
> > > > > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> > > > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > > > ---
> > > > > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > > > > >  1 file changed, 9 insertions(+)
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > index 7e15aae7d69e..8b61c2179608 100644
> > > > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > @@ -64,6 +64,15 @@ properties:
> > > > > >
> > > > > >    aspm-no-l0s: true
> > > > > >
> > > > > > +  brcm,enable-l1ss:
> > > > > > +    description: Indicates that PCIe L1SS power savings
> > > > > > +      are desired, the downstream device is L1SS-capable, and the
> > > > > > +      OS has been configured to enable this mode.  For boards
> > > > >
> > > > > What does this mean ? I don't think DT properties are supposed
> > > > > to carry information related to how the OS is configured.
> > > >
> > > > The DT setting in question is unrelated to the statement "and the OS
> > > > has been configured to
> > > > enable this mode".
> > > >
> > > > This is merely saying that even if you enable "brcm,l1ss-enable"
> > > > that you may not get L1SS power savings w/o setting
> > > > "CONFIG_PCIEASPM_POWER_SUPERSAVE=y".
> > > > I mentioned that exact term but a reviewer nakked it because
> > > > apparently DT descriptions should not be OS specific.
> > > >
> > > > I am actually open for this to be a command-line option but I wanted to honor
> > > > what the Raspian OS folks have already done.  RaspianOS already has
> > > > "brcm,enable-l1ss"
> > > > set in their DTS files.
> > >
> > > This is about the mainline kernel, I don't have any visibility into
> > > downstream kernels (where that property management was added without DT
> > > and PCI maintainers supervision).
> > >
> > > Raspian OS folks' choice is theirs but it can't and it shouldn't override
> > > the mainline review process even though I understand the position you
> > > are in.
> > 
> > Understood, but using the command line has its warts as well; I now recall the
> > discussion Bjorn and I  had regarding this option.  I'm pretty sure
> > that upstreaam will not allow the following
> > possible command line kernel params:
> > 
> >     brcm,enable-l1ss
> >     pci=brcm,entable-l1ss
> > 
> > Bjorn suggested using the  documented but (IMO) obscure  and  rarely
> > used  format
> > 
> >     pci=[<domain>:]<bus>:<dev>.<func>[/<dev>.<func>]*pci:<vendor>:<device>[:<subvendor>:<subdevice>]
> > 
> > but this is just going in the wrong direction; here's why.  Using the
> > above iformat s completely dependent on the
> > PCI "linux-domaiin"  property,  a non-HW related DT property I  might
> > add.  Since "linux-domain" is already
> > a valid and well-used  DT property, and the value of  the above
> > command line format is dependent
> > on the value of the "linux-domain", why not be consistent and let
> > "brcm,enable-l1ss" be a Broadcom specific property?
> 
> I am just asking to add a module_param to the host controller driver.

A module_param sounds possible to me.  IIRC the bidirectional CLKREQ#
(config (c)) has been tested and there are no known problems even if
the OS doesn't enable L1SS.  The only issue (again, IIRC) is that the
hardware engineer has unspecified reservations about it.

Is there any room to make (c) the default and have a module_param to
*disable* the L1SS support?  I think the driver knows enough to then
select (a) or (b) by itself.

Bjorn

Re: [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property

[Jim Quinlan]

[-- Attachment #1: Type: text/plain, Size: 7905 bytes --]

On Wed, Aug 23, 2023 at 8:42 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Wed, Aug 23, 2023 at 09:30:48AM +0200, Lorenzo Pieralisi wrote:
> > On Mon, Aug 21, 2023 at 12:01:50PM -0400, Jim Quinlan wrote:
> > > On Mon, Aug 21, 2023 at 11:41 AM Lorenzo Pieralisi
> > > <lpieralisi@kernel.org> wrote:
> > > > On Mon, Aug 21, 2023 at 11:25:11AM -0400, Jim Quinlan wrote:
> > > > > On Mon, Aug 21, 2023 at 10:47 AM Lorenzo Pieralisi
> > > > > <lpieralisi@kernel.org> wrote:
> > > > > > On Fri, Jun 23, 2023 at 10:40:54AM -0400, Jim Quinlan wrote:
> > > > > > > This commit adds the boolean "brcm,enable-l1ss" property:
> > > > > > >
> > > > > > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > > > > > >   requires the driver probe() to deliberately place the HW one of three
> > > > > > >   CLKREQ# modes:
> > > > > > >
> > > > > > >   (a) CLKREQ# driven by the RC unconditionally
> > > > > > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > > > > > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > > > > > >
> > > > > > >   The HW+driver can tell the difference between downstream devices that
> > > > > > >   need (a) and (b), but does not know when to configure (c).  All devices
> > > > > > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > > > > > >   desired to realize the extra power savings that L1SS offers.  So we
> > > > > > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > > > > > >   that (c) is desired.  Setting this property only makes sense when the
> > > > > > >   downstream device is L1SS-capable and the OS is configured to activate
> > > > > > >   this mode (e.g. policy==powersupersave).
> > > > > > >
> > > > > > >   This property is already present in the Raspian version of Linux, but the
> > > > > > >   upstream driver implementation that follows adds more details and
> > > > > > >   discerns between (a) and (b).
> > > > > > >
> > > > > > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> > > > > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > > > > ---
> > > > > > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > > > > > >  1 file changed, 9 insertions(+)
> > > > > > >
> > > > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > index 7e15aae7d69e..8b61c2179608 100644
> > > > > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > @@ -64,6 +64,15 @@ properties:
> > > > > > >
> > > > > > >    aspm-no-l0s: true
> > > > > > >
> > > > > > > +  brcm,enable-l1ss:
> > > > > > > +    description: Indicates that PCIe L1SS power savings
> > > > > > > +      are desired, the downstream device is L1SS-capable, and the
> > > > > > > +      OS has been configured to enable this mode.  For boards
> > > > > >
> > > > > > What does this mean ? I don't think DT properties are supposed
> > > > > > to carry information related to how the OS is configured.
> > > > >
> > > > > The DT setting in question is unrelated to the statement "and the OS
> > > > > has been configured to
> > > > > enable this mode".
> > > > >
> > > > > This is merely saying that even if you enable "brcm,l1ss-enable"
> > > > > that you may not get L1SS power savings w/o setting
> > > > > "CONFIG_PCIEASPM_POWER_SUPERSAVE=y".
> > > > > I mentioned that exact term but a reviewer nakked it because
> > > > > apparently DT descriptions should not be OS specific.
> > > > >
> > > > > I am actually open for this to be a command-line option but I wanted to honor
> > > > > what the Raspian OS folks have already done.  RaspianOS already has
> > > > > "brcm,enable-l1ss"
> > > > > set in their DTS files.
> > > >
> > > > This is about the mainline kernel, I don't have any visibility into
> > > > downstream kernels (where that property management was added without DT
> > > > and PCI maintainers supervision).
> > > >
> > > > Raspian OS folks' choice is theirs but it can't and it shouldn't override
> > > > the mainline review process even though I understand the position you
> > > > are in.
> > >
> > > Understood, but using the command line has its warts as well; I now recall the
> > > discussion Bjorn and I  had regarding this option.  I'm pretty sure
> > > that upstreaam will not allow the following
> > > possible command line kernel params:
> > >
> > >     brcm,enable-l1ss
> > >     pci=brcm,entable-l1ss
> > >
> > > Bjorn suggested using the  documented but (IMO) obscure  and  rarely
> > > used  format
> > >
> > >     pci=[<domain>:]<bus>:<dev>.<func>[/<dev>.<func>]*pci:<vendor>:<device>[:<subvendor>:<subdevice>]
> > >
> > > but this is just going in the wrong direction; here's why.  Using the
> > > above iformat s completely dependent on the
> > > PCI "linux-domaiin"  property,  a non-HW related DT property I  might
> > > add.  Since "linux-domain" is already
> > > a valid and well-used  DT property, and the value of  the above
> > > command line format is dependent
> > > on the value of the "linux-domain", why not be consistent and let
> > > "brcm,enable-l1ss" be a Broadcom specific property?
> >
> > I am just asking to add a module_param to the host controller driver.

Adding a module_param, which would have a command line setting such as
"brcm_pcie.enable-l1ss=1"
is for the driver -- we need a per PCIe controller param, as each
controller may have a different setting.

Which brings us to the alternative, a command line param using
pci_dev_str_match() such as

      pci=brcm,enable-l1ss=1:0:0.0

Implementing this would require this AFAICT:

    (1) New file:  drivers/pci/controller/pcie-brcmstb.h
    (2) The "pci.c" file would have to include the above file which I
don't think is a good thing.

>
> A module_param sounds possible to me.  IIRC the bidirectional CLKREQ#
> (config (c)) has been tested and there are no known problems even if
> the OS doesn't enable L1SS.

Ah, I have an update on this.  I was able to communicate with the HW
designer and he explained
that when setting the PCIe core "l1ss bit"  one  loses the benefit  of
Clock Power  Management.  Actually,
let me quote his email so I do not distort his words:

   "If RC is placed in L1SS clkreq mode, may take advantage
    of L1SS power savings, L0s, and L1 power savings, but cannot
    employ Clock Power Management power savings.

    If the RC is placed in "clkreq" clkreq mode, it can only take
    advantage of L0s, L1 power savings, and Clock Power Management
    savings - only omitting L1SS power savings

    The issue is that the Clock Power Management and PM L1 Substates
    are incompatible. The original Clock Power Management feature
    requires the clock to turn on within Tclron=400ns from CLKREQ#
    deassertion, and we feel we need to continue to support products
    that were designed to this requirement. The CLKREQ# deassertion
    to clock turned on requirement with PM L1 Substates was relaxed
    with the addition of the Latency Tolerance Reporting (LTR)
    mechanism. We use the mode bit to distinguish the two modes of
    operation, but currently we aren't looking at whether the RC+EP
    both support the LTR mechanism to make the decision."

I'm not sure if this changes your mind one way or another.

Regards,
Jim Quinlan
Broadcom STB/CM





The only issue (again, IIRC) is that the
> hardware engineer has unspecified reservations about it.
>
> Is there any room to make (c) the default and have a module_param to
> *disable* the L1SS support?  I think the driver knows enough to then
> select (a) or (b) by itself.
>
> Bjorn

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4210 bytes --]

Re: [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property

[Rob Herring]

On Wed, Aug 23, 2023 at 2:30 AM Lorenzo Pieralisi <lpieralisi@kernel.org> wrote:
>
> On Mon, Aug 21, 2023 at 12:01:50PM -0400, Jim Quinlan wrote:
> > On Mon, Aug 21, 2023 at 11:41 AM Lorenzo Pieralisi
> > <lpieralisi@kernel.org> wrote:
> > >
> > > On Mon, Aug 21, 2023 at 11:25:11AM -0400, Jim Quinlan wrote:
> > > > On Mon, Aug 21, 2023 at 10:47 AM Lorenzo Pieralisi
> > > > <lpieralisi@kernel.org> wrote:
> > > > >
> > > > > On Fri, Jun 23, 2023 at 10:40:54AM -0400, Jim Quinlan wrote:
> > > > > > This commit adds the boolean "brcm,enable-l1ss" property:
> > > > > >
> > > > > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > > > > >   requires the driver probe() to deliberately place the HW one of three
> > > > > >   CLKREQ# modes:
> > > > > >
> > > > > >   (a) CLKREQ# driven by the RC unconditionally
> > > > > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > > > > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > > > > >
> > > > > >   The HW+driver can tell the difference between downstream devices that
> > > > > >   need (a) and (b), but does not know when to configure (c).  All devices
> > > > > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > > > > >   desired to realize the extra power savings that L1SS offers.  So we
> > > > > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > > > > >   that (c) is desired.  Setting this property only makes sense when the
> > > > > >   downstream device is L1SS-capable and the OS is configured to activate
> > > > > >   this mode (e.g. policy==powersupersave).
> > > > > >
> > > > > >   This property is already present in the Raspian version of Linux, but the
> > > > > >   upstream driver implementation that follows adds more details and
> > > > > >   discerns between (a) and (b).
> > > > > >
> > > > > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> > > > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > > > ---
> > > > > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > > > > >  1 file changed, 9 insertions(+)
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > index 7e15aae7d69e..8b61c2179608 100644
> > > > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > @@ -64,6 +64,15 @@ properties:
> > > > > >
> > > > > >    aspm-no-l0s: true
> > > > > >
> > > > > > +  brcm,enable-l1ss:
> > > > > > +    description: Indicates that PCIe L1SS power savings
> > > > > > +      are desired, the downstream device is L1SS-capable, and the
> > > > > > +      OS has been configured to enable this mode.  For boards
> > > > >
> > > > > What does this mean ? I don't think DT properties are supposed
> > > > > to carry information related to how the OS is configured.
> > > >
> > > > The DT setting in question is unrelated to the statement "and the OS
> > > > has been configured to
> > > > enable this mode".
> > > >
> > > > This is merely saying that even if you enable "brcm,l1ss-enable"
> > > > that you may not get L1SS power savings w/o setting
> > > > "CONFIG_PCIEASPM_POWER_SUPERSAVE=y".
> > > > I mentioned that exact term but a reviewer nakked it because
> > > > apparently DT descriptions should not be OS specific.

Yeah, probably the OS part should be dropped.

> > > >
> > > > I am actually open for this to be a command-line option but I wanted to honor
> > > > what the Raspian OS folks have already done.  RaspianOS already has
> > > > "brcm,enable-l1ss"
> > > > set in their DTS files.
> > >
> > > This is about the mainline kernel, I don't have any visibility into
> > > downstream kernels (where that property management was added without DT
> > > and PCI maintainers supervision).
> > >
> > > Raspian OS folks' choice is theirs but it can't and it shouldn't override
> > > the mainline review process even though I understand the position you
> > > are in.

Sure, but we shouldn't change things just to be different from
downstream. If we're only discussing the color of the shed, then no
point changing it.

> >
> > Understood, but using the command line has its warts as well; I now recall the
> > discussion Bjorn and I  had regarding this option.  I'm pretty sure
> > that upstreaam will not allow the following
> > possible command line kernel params:
> >
> >     brcm,enable-l1ss
> >     pci=brcm,entable-l1ss
> >
> > Bjorn suggested using the  documented but (IMO) obscure  and  rarely
> > used  format
> >
> >     pci=[<domain>:]<bus>:<dev>.<func>[/<dev>.<func>]*pci:<vendor>:<device>[:<subvendor>:<subdevice>]
> >
> > but this is just going in the wrong direction; here's why.  Using the
> > above iformat s completely dependent on the
> > PCI "linux-domaiin"  property,  a non-HW related DT property I  might
> > add.  Since "linux-domain" is already
> > a valid and well-used  DT property, and the value of  the above
> > command line format is dependent
> > on the value of the "linux-domain", why not be consistent and let
> > "brcm,enable-l1ss" be a Broadcom specific property?
>
> I am just asking to add a module_param to the host controller driver.

FWIW, gregkh pretty much always nacks new module parameters.

>
> Anyway - time is running out for v6.6, I need Rob's feedback, if I don't
> hear from him today I will merge the last three patches and postpone the
> discussion.

You've already got my reviewed-by. If you aren't happy with this, then
fine. I don't know enough about L1SS to comment further. Is it
normally always supported or discoverable? If so, then I'd think we'd
want it default enabled with a disable override flag. Maybe it should
be generic?

Rob

Re: [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property

[Lorenzo Pieralisi]

On Wed, Aug 23, 2023 at 09:48:40AM -0500, Rob Herring wrote:
> On Wed, Aug 23, 2023 at 2:30 AM Lorenzo Pieralisi <lpieralisi@kernel.org> wrote:
> >
> > On Mon, Aug 21, 2023 at 12:01:50PM -0400, Jim Quinlan wrote:
> > > On Mon, Aug 21, 2023 at 11:41 AM Lorenzo Pieralisi
> > > <lpieralisi@kernel.org> wrote:
> > > >
> > > > On Mon, Aug 21, 2023 at 11:25:11AM -0400, Jim Quinlan wrote:
> > > > > On Mon, Aug 21, 2023 at 10:47 AM Lorenzo Pieralisi
> > > > > <lpieralisi@kernel.org> wrote:
> > > > > >
> > > > > > On Fri, Jun 23, 2023 at 10:40:54AM -0400, Jim Quinlan wrote:
> > > > > > > This commit adds the boolean "brcm,enable-l1ss" property:
> > > > > > >
> > > > > > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > > > > > >   requires the driver probe() to deliberately place the HW one of three
> > > > > > >   CLKREQ# modes:
> > > > > > >
> > > > > > >   (a) CLKREQ# driven by the RC unconditionally
> > > > > > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > > > > > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > > > > > >
> > > > > > >   The HW+driver can tell the difference between downstream devices that
> > > > > > >   need (a) and (b), but does not know when to configure (c).  All devices
> > > > > > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > > > > > >   desired to realize the extra power savings that L1SS offers.  So we
> > > > > > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > > > > > >   that (c) is desired.  Setting this property only makes sense when the
> > > > > > >   downstream device is L1SS-capable and the OS is configured to activate
> > > > > > >   this mode (e.g. policy==powersupersave).
> > > > > > >
> > > > > > >   This property is already present in the Raspian version of Linux, but the
> > > > > > >   upstream driver implementation that follows adds more details and
> > > > > > >   discerns between (a) and (b).
> > > > > > >
> > > > > > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> > > > > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > > > > ---
> > > > > > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > > > > > >  1 file changed, 9 insertions(+)
> > > > > > >
> > > > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > index 7e15aae7d69e..8b61c2179608 100644
> > > > > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > @@ -64,6 +64,15 @@ properties:
> > > > > > >
> > > > > > >    aspm-no-l0s: true
> > > > > > >
> > > > > > > +  brcm,enable-l1ss:
> > > > > > > +    description: Indicates that PCIe L1SS power savings
> > > > > > > +      are desired, the downstream device is L1SS-capable, and the
> > > > > > > +      OS has been configured to enable this mode.  For boards
> > > > > >
> > > > > > What does this mean ? I don't think DT properties are supposed
> > > > > > to carry information related to how the OS is configured.
> > > > >
> > > > > The DT setting in question is unrelated to the statement "and the OS
> > > > > has been configured to
> > > > > enable this mode".
> > > > >
> > > > > This is merely saying that even if you enable "brcm,l1ss-enable"
> > > > > that you may not get L1SS power savings w/o setting
> > > > > "CONFIG_PCIEASPM_POWER_SUPERSAVE=y".
> > > > > I mentioned that exact term but a reviewer nakked it because
> > > > > apparently DT descriptions should not be OS specific.
> 
> Yeah, probably the OS part should be dropped.

I will drop it - if you don't mind.

> > > > > I am actually open for this to be a command-line option but I wanted to honor
> > > > > what the Raspian OS folks have already done.  RaspianOS already has
> > > > > "brcm,enable-l1ss"
> > > > > set in their DTS files.
> > > >
> > > > This is about the mainline kernel, I don't have any visibility into
> > > > downstream kernels (where that property management was added without DT
> > > > and PCI maintainers supervision).
> > > >
> > > > Raspian OS folks' choice is theirs but it can't and it shouldn't override
> > > > the mainline review process even though I understand the position you
> > > > are in.
> 
> Sure, but we shouldn't change things just to be different from
> downstream. If we're only discussing the color of the shed, then no
> point changing it.

Sure, no problem.

> > > Understood, but using the command line has its warts as well; I now recall the
> > > discussion Bjorn and I  had regarding this option.  I'm pretty sure
> > > that upstreaam will not allow the following
> > > possible command line kernel params:
> > >
> > >     brcm,enable-l1ss
> > >     pci=brcm,entable-l1ss
> > >
> > > Bjorn suggested using the  documented but (IMO) obscure  and  rarely
> > > used  format
> > >
> > >     pci=[<domain>:]<bus>:<dev>.<func>[/<dev>.<func>]*pci:<vendor>:<device>[:<subvendor>:<subdevice>]
> > >
> > > but this is just going in the wrong direction; here's why.  Using the
> > > above iformat s completely dependent on the
> > > PCI "linux-domaiin"  property,  a non-HW related DT property I  might
> > > add.  Since "linux-domain" is already
> > > a valid and well-used  DT property, and the value of  the above
> > > command line format is dependent
> > > on the value of the "linux-domain", why not be consistent and let
> > > "brcm,enable-l1ss" be a Broadcom specific property?
> >
> > I am just asking to add a module_param to the host controller driver.
> 
> FWIW, gregkh pretty much always nacks new module parameters.

Fine by me.

> > Anyway - time is running out for v6.6, I need Rob's feedback, if I don't
> > hear from him today I will merge the last three patches and postpone the
> > discussion.
> 
> You've already got my reviewed-by. If you aren't happy with this, then
> fine. I don't know enough about L1SS to comment further. Is it
> normally always supported or discoverable? If so, then I'd think we'd
> want it default enabled with a disable override flag. Maybe it should
> be generic?

It is not that I am not happy with it - we asked questions to understand
what this property was for, I think that's normal.

I will merge this series as-is.

Lorenzo

Re: [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property

[Manivannan Sadhasivam]

On Wed, Aug 23, 2023 at 06:29:08PM +0200, Lorenzo Pieralisi wrote:
> On Wed, Aug 23, 2023 at 09:48:40AM -0500, Rob Herring wrote:
> > On Wed, Aug 23, 2023 at 2:30 AM Lorenzo Pieralisi <lpieralisi@kernel.org> wrote:
> > >
> > > On Mon, Aug 21, 2023 at 12:01:50PM -0400, Jim Quinlan wrote:
> > > > On Mon, Aug 21, 2023 at 11:41 AM Lorenzo Pieralisi
> > > > <lpieralisi@kernel.org> wrote:
> > > > >
> > > > > On Mon, Aug 21, 2023 at 11:25:11AM -0400, Jim Quinlan wrote:
> > > > > > On Mon, Aug 21, 2023 at 10:47 AM Lorenzo Pieralisi
> > > > > > <lpieralisi@kernel.org> wrote:
> > > > > > >
> > > > > > > On Fri, Jun 23, 2023 at 10:40:54AM -0400, Jim Quinlan wrote:
> > > > > > > > This commit adds the boolean "brcm,enable-l1ss" property:
> > > > > > > >
> > > > > > > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > > > > > > >   requires the driver probe() to deliberately place the HW one of three
> > > > > > > >   CLKREQ# modes:
> > > > > > > >
> > > > > > > >   (a) CLKREQ# driven by the RC unconditionally
> > > > > > > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > > > > > > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > > > > > > >
> > > > > > > >   The HW+driver can tell the difference between downstream devices that
> > > > > > > >   need (a) and (b), but does not know when to configure (c).  All devices
> > > > > > > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > > > > > > >   desired to realize the extra power savings that L1SS offers.  So we
> > > > > > > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > > > > > > >   that (c) is desired.  Setting this property only makes sense when the
> > > > > > > >   downstream device is L1SS-capable and the OS is configured to activate
> > > > > > > >   this mode (e.g. policy==powersupersave).
> > > > > > > >
> > > > > > > >   This property is already present in the Raspian version of Linux, but the
> > > > > > > >   upstream driver implementation that follows adds more details and
> > > > > > > >   discerns between (a) and (b).
> > > > > > > >
> > > > > > > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> > > > > > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > > > > > ---
> > > > > > > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > > > > > > >  1 file changed, 9 insertions(+)
> > > > > > > >
> > > > > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > > index 7e15aae7d69e..8b61c2179608 100644
> > > > > > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > > @@ -64,6 +64,15 @@ properties:
> > > > > > > >
> > > > > > > >    aspm-no-l0s: true
> > > > > > > >
> > > > > > > > +  brcm,enable-l1ss:
> > > > > > > > +    description: Indicates that PCIe L1SS power savings
> > > > > > > > +      are desired, the downstream device is L1SS-capable, and the
> > > > > > > > +      OS has been configured to enable this mode.  For boards
> > > > > > >
> > > > > > > What does this mean ? I don't think DT properties are supposed
> > > > > > > to carry information related to how the OS is configured.
> > > > > >
> > > > > > The DT setting in question is unrelated to the statement "and the OS
> > > > > > has been configured to
> > > > > > enable this mode".
> > > > > >
> > > > > > This is merely saying that even if you enable "brcm,l1ss-enable"
> > > > > > that you may not get L1SS power savings w/o setting
> > > > > > "CONFIG_PCIEASPM_POWER_SUPERSAVE=y".
> > > > > > I mentioned that exact term but a reviewer nakked it because
> > > > > > apparently DT descriptions should not be OS specific.
> > 
> > Yeah, probably the OS part should be dropped.
> 
> I will drop it - if you don't mind.
> 
> > > > > > I am actually open for this to be a command-line option but I wanted to honor
> > > > > > what the Raspian OS folks have already done.  RaspianOS already has
> > > > > > "brcm,enable-l1ss"
> > > > > > set in their DTS files.
> > > > >
> > > > > This is about the mainline kernel, I don't have any visibility into
> > > > > downstream kernels (where that property management was added without DT
> > > > > and PCI maintainers supervision).
> > > > >
> > > > > Raspian OS folks' choice is theirs but it can't and it shouldn't override
> > > > > the mainline review process even though I understand the position you
> > > > > are in.
> > 
> > Sure, but we shouldn't change things just to be different from
> > downstream. If we're only discussing the color of the shed, then no
> > point changing it.
> 
> Sure, no problem.
> 
> > > > Understood, but using the command line has its warts as well; I now recall the
> > > > discussion Bjorn and I  had regarding this option.  I'm pretty sure
> > > > that upstreaam will not allow the following
> > > > possible command line kernel params:
> > > >
> > > >     brcm,enable-l1ss
> > > >     pci=brcm,entable-l1ss
> > > >
> > > > Bjorn suggested using the  documented but (IMO) obscure  and  rarely
> > > > used  format
> > > >
> > > >     pci=[<domain>:]<bus>:<dev>.<func>[/<dev>.<func>]*pci:<vendor>:<device>[:<subvendor>:<subdevice>]
> > > >
> > > > but this is just going in the wrong direction; here's why.  Using the
> > > > above iformat s completely dependent on the
> > > > PCI "linux-domaiin"  property,  a non-HW related DT property I  might
> > > > add.  Since "linux-domain" is already
> > > > a valid and well-used  DT property, and the value of  the above
> > > > command line format is dependent
> > > > on the value of the "linux-domain", why not be consistent and let
> > > > "brcm,enable-l1ss" be a Broadcom specific property?
> > >
> > > I am just asking to add a module_param to the host controller driver.
> > 
> > FWIW, gregkh pretty much always nacks new module parameters.
> 
> Fine by me.
> 
> > > Anyway - time is running out for v6.6, I need Rob's feedback, if I don't
> > > hear from him today I will merge the last three patches and postpone the
> > > discussion.
> > 
> > You've already got my reviewed-by. If you aren't happy with this, then
> > fine. I don't know enough about L1SS to comment further. Is it
> > normally always supported or discoverable? If so, then I'd think we'd
> > want it default enabled with a disable override flag. Maybe it should
> > be generic?
> 
> It is not that I am not happy with it - we asked questions to understand
> what this property was for, I think that's normal.
> 
> I will merge this series as-is.
> 

There is a discussion ongoing here: https://lore.kernel.org/linux-pci/20230823181650.GL3737@thinkpad/T/#u

Can you please hold on to merging this series until we've reached a conclusion?

- Mani

> Lorenzo

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH v6 1/5] dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property

[Jim Quinlan]

[-- Attachment #1: Type: text/plain, Size: 8464 bytes --]

On Wed, Aug 23, 2023 at 2:26 PM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>
> On Wed, Aug 23, 2023 at 06:29:08PM +0200, Lorenzo Pieralisi wrote:
> > On Wed, Aug 23, 2023 at 09:48:40AM -0500, Rob Herring wrote:
> > > On Wed, Aug 23, 2023 at 2:30 AM Lorenzo Pieralisi <lpieralisi@kernel.org> wrote:
> > > >
> > > > On Mon, Aug 21, 2023 at 12:01:50PM -0400, Jim Quinlan wrote:
> > > > > On Mon, Aug 21, 2023 at 11:41 AM Lorenzo Pieralisi
> > > > > <lpieralisi@kernel.org> wrote:
> > > > > >
> > > > > > On Mon, Aug 21, 2023 at 11:25:11AM -0400, Jim Quinlan wrote:
> > > > > > > On Mon, Aug 21, 2023 at 10:47 AM Lorenzo Pieralisi
> > > > > > > <lpieralisi@kernel.org> wrote:
> > > > > > > >
> > > > > > > > On Fri, Jun 23, 2023 at 10:40:54AM -0400, Jim Quinlan wrote:
> > > > > > > > > This commit adds the boolean "brcm,enable-l1ss" property:
> > > > > > > > >
> > > > > > > > >   The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs --
> > > > > > > > >   requires the driver probe() to deliberately place the HW one of three
> > > > > > > > >   CLKREQ# modes:
> > > > > > > > >
> > > > > > > > >   (a) CLKREQ# driven by the RC unconditionally
> > > > > > > > >   (b) CLKREQ# driven by the EP for ASPM L0s, L1
> > > > > > > > >   (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS).
> > > > > > > > >
> > > > > > > > >   The HW+driver can tell the difference between downstream devices that
> > > > > > > > >   need (a) and (b), but does not know when to configure (c).  All devices
> > > > > > > > >   should work fine when the driver chooses (a) or (b), but (c) may be
> > > > > > > > >   desired to realize the extra power savings that L1SS offers.  So we
> > > > > > > > >   introduce the boolean "brcm,enable-l1ss" property to inform the driver
> > > > > > > > >   that (c) is desired.  Setting this property only makes sense when the
> > > > > > > > >   downstream device is L1SS-capable and the OS is configured to activate
> > > > > > > > >   this mode (e.g. policy==powersupersave).
> > > > > > > > >
> > > > > > > > >   This property is already present in the Raspian version of Linux, but the
> > > > > > > > >   upstream driver implementation that follows adds more details and
> > > > > > > > >   discerns between (a) and (b).
> > > > > > > > >
> > > > > > > > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> > > > > > > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > > > > > > ---
> > > > > > > > >  Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 9 +++++++++
> > > > > > > > >  1 file changed, 9 insertions(+)
> > > > > > > > >
> > > > > > > > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > > > index 7e15aae7d69e..8b61c2179608 100644
> > > > > > > > > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > > > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > > > > > > > > @@ -64,6 +64,15 @@ properties:
> > > > > > > > >
> > > > > > > > >    aspm-no-l0s: true
> > > > > > > > >
> > > > > > > > > +  brcm,enable-l1ss:
> > > > > > > > > +    description: Indicates that PCIe L1SS power savings
> > > > > > > > > +      are desired, the downstream device is L1SS-capable, and the
> > > > > > > > > +      OS has been configured to enable this mode.  For boards
> > > > > > > >
> > > > > > > > What does this mean ? I don't think DT properties are supposed
> > > > > > > > to carry information related to how the OS is configured.
> > > > > > >
> > > > > > > The DT setting in question is unrelated to the statement "and the OS
> > > > > > > has been configured to
> > > > > > > enable this mode".
> > > > > > >
> > > > > > > This is merely saying that even if you enable "brcm,l1ss-enable"
> > > > > > > that you may not get L1SS power savings w/o setting
> > > > > > > "CONFIG_PCIEASPM_POWER_SUPERSAVE=y".
> > > > > > > I mentioned that exact term but a reviewer nakked it because
> > > > > > > apparently DT descriptions should not be OS specific.
> > >
> > > Yeah, probably the OS part should be dropped.
> >
> > I will drop it - if you don't mind.
> >
> > > > > > > I am actually open for this to be a command-line option but I wanted to honor
> > > > > > > what the Raspian OS folks have already done.  RaspianOS already has
> > > > > > > "brcm,enable-l1ss"
> > > > > > > set in their DTS files.
> > > > > >
> > > > > > This is about the mainline kernel, I don't have any visibility into
> > > > > > downstream kernels (where that property management was added without DT
> > > > > > and PCI maintainers supervision).
> > > > > >
> > > > > > Raspian OS folks' choice is theirs but it can't and it shouldn't override
> > > > > > the mainline review process even though I understand the position you
> > > > > > are in.
> > >
> > > Sure, but we shouldn't change things just to be different from
> > > downstream. If we're only discussing the color of the shed, then no
> > > point changing it.
> >
> > Sure, no problem.
> >
> > > > > Understood, but using the command line has its warts as well; I now recall the
> > > > > discussion Bjorn and I  had regarding this option.  I'm pretty sure
> > > > > that upstreaam will not allow the following
> > > > > possible command line kernel params:
> > > > >
> > > > >     brcm,enable-l1ss
> > > > >     pci=brcm,entable-l1ss
> > > > >
> > > > > Bjorn suggested using the  documented but (IMO) obscure  and  rarely
> > > > > used  format
> > > > >
> > > > >     pci=[<domain>:]<bus>:<dev>.<func>[/<dev>.<func>]*pci:<vendor>:<device>[:<subvendor>:<subdevice>]
> > > > >
> > > > > but this is just going in the wrong direction; here's why.  Using the
> > > > > above iformat s completely dependent on the
> > > > > PCI "linux-domaiin"  property,  a non-HW related DT property I  might
> > > > > add.  Since "linux-domain" is already
> > > > > a valid and well-used  DT property, and the value of  the above
> > > > > command line format is dependent
> > > > > on the value of the "linux-domain", why not be consistent and let
> > > > > "brcm,enable-l1ss" be a Broadcom specific property?
> > > >
> > > > I am just asking to add a module_param to the host controller driver.
> > >
> > > FWIW, gregkh pretty much always nacks new module parameters.
> >
> > Fine by me.
> >
> > > > Anyway - time is running out for v6.6, I need Rob's feedback, if I don't
> > > > hear from him today I will merge the last three patches and postpone the
> > > > discussion.
> > >
> > > You've already got my reviewed-by. If you aren't happy with this, then
> > > fine. I don't know enough about L1SS to comment further. Is it
> > > normally always supported or discoverable? If so, then I'd think we'd
> > > want it default enabled with a disable override flag. Maybe it should
> > > be generic?
> >
> > It is not that I am not happy with it - we asked questions to understand
> > what this property was for, I think that's normal.
> >
> > I will merge this series as-is.
> >
>
> There is a discussion ongoing here: https://lore.kernel.org/linux-pci/20230823181650.GL3737@thinkpad/T/#u
>
> Can you please hold on to merging this series until we've reached a conclusion?
 (2) There are odd boards out there which

TL;DR:  I'm okay with postponing the two clkreq# commits.

Sigh.  I really wish we had this discussion months ago when this
series was submitted.

I do think the best -- but not perfect -- way to do this is with a DT
param.  AFAICT there
is no way to do this with a command line param with it being accepted,
module_param or otherwise; please see
my reasons from this thread.  Also, Rob just said that GregH will
probably reject a new module_param
anyway.

That being said, the recent discussions are insightful and have me
reconsidering having
the "l1ss mode" be the default -- it has certainly worked well for the
RaspianOS folks.
That being said, the RaspianOS folks do not experience the flavor of
form-factors and devices
as Broadcom STB, and the admonitions of our HW designer are of great
concern to me.

In light of the above I am okay with postponing the two clkreq-related
commits to avoid any missteps.

Regards,
Jim

>
> - Mani
>
> > Lorenzo
>
> --
> மணிவண்ணன் சதாசிவம்

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4210 bytes --]

Re: [PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode

[Cyril Brulebois]

[-- Attachment #1: Type: text/plain, Size: 2180 bytes --]

Hi Jim,

Jim Quinlan <james.quinlan@broadcom.com> (2023-06-23):
> v6 -- No code has been changed.
>    -- Changed commit subject and comment in "#PERST" commit (Bjorn, Cyril)
>    -- Changed sign-off and author email address for all commits.
>       This was due to a change in Broadcom's upstreaming policy.

I've just run some more tests to be on the safe side, and I can confirm
everything is still looking good with the updated series and the updated
base commit.

Test setup:
-----------

 - using a $CM with the 20230111 EEPROM
 - on the same CM4 IO Board
 - with a $PCIE board (PCIe to multiple USB ports)
 - and the same Samsung USB flash drive.

where $CM is one of:

 - CM4 Lite Rev 1.0
 - CM4 8/32 Rev 1.0
 - CM4 4/32 Rev 1.1

and $PCIE is one of:

 - SupaHub PCE6U1C-R02, VER 006
 - SupaHub PCE6U1C-R02, VER 006S


Results:
--------

 1. With an unpatched kernel, I'm getting the dreaded Serror for all
    $CM/$PCIE combinations. That's reproducible with:
     - the 6.1.y kernel shipped in Debian 12;
     - a locally-built v6.4-rc7-194-g8a28a0b6f1a1d kernel.

 2. With a patched kernel (v6.4-rc7-194-g8a28a0b6f1a1d + this series),
    for all $CM/$PCIE combinations, I'm getting a system that boots,
    sees the flash drive, and gives decent read performance on the USB
    flash drive (200+ MB/s on the CM4 Lite, 220+ MB/s on the non-Lite
    versions).


In passing, since that looks like it could be merged finally: I suppose
it's fair to say this series adds support for hardware that wasn't
working before, which means it's not a candidate for inclusion via
stable@ (even if it gets rid of a nasty failure to boot depending on
what hardware is plugged in at that time)?

In other words, downstream distributions should be expected to either
adjust their build systems to pick some future Linux release or consider
backporting this series on their own, to each base Linux version they
support?


Thanks again for all the help figuring this out.


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode

[Lorenzo Pieralisi]

On Fri, Jun 23, 2023 at 10:40:53AM -0400, Jim Quinlan wrote:
> v6 -- No code has been changed.
>    -- Changed commit subject and comment in "#PERST" commit (Bjorn, Cyril)
>    -- Changed sign-off and author email address for all commits.
>       This was due to a change in Broadcom's upstreaming policy.
> 
> v5 -- Remove DT property "brcm,completion-timeout-us" from	 
>       "DT bindings" commit.  Although this error may be reported	 
>       as a completion timeout, its cause was traced to an	 
>       internal bus timeout which may occur even when there is	 
>       no PCIe access being processed.  We set a timeout of four	 
>       seconds only if we are operating in "L1SS CLKREQ#" mode.
>    -- Correct CEM 2.0 reference provided by HW engineer,
>       s/3.2.5.2.5/3.2.5.2.2/ (Bjorn)
>    -- Add newline to dev_info() string (Stefan)
>    -- Change variable rval to unsigned (Stefan)
>    -- s/implementaion/implementation/ (Bjorn)
>    -- s/superpowersave/powersupersave/ (Bjorn)
>    -- Slightly modify message on "PERST#" commit.
>    -- Rebase to torvalds master
> 
> v4 -- New commit that asserts PERST# for 2711/RPi SOCs at PCIe RC
>       driver probe() time.  This is done in Raspian Linux and its
>       absence may be the cause of a failing test case.
>    -- New commit that removes stale comment.
> 
> v3 -- Rewrote commit msgs and comments refering panics if L1SS
>       is enabled/disabled; the code snippet that unadvertises L1SS
>       eliminates the panic scenario. (Bjorn)
>    -- Add reference for "400ns of CLKREQ# assertion" blurb (Bjorn)
>    -- Put binding names in DT commit Subject (Bjorn)
>    -- Add a verb to a commit's subject line (Bjorn)
>    -- s/accomodat(\w+)/accommodat$1/g (Bjorn)
>    -- Rewrote commit msgs and comments refering panics if L1SS
>       is enabled/disabled; the code snippet that unadvertises L1SS
>       eliminates the panic scenario. (Bjorn)
> 
> v2 -- Changed binding property 'brcm,completion-timeout-msec' to
>       'brcm,completion-timeout-us'.  (StefanW for standard suffix).
>    -- Warn when clamping timeout value, and include clamped
>       region in message. Also add min and max in YAML. (StefanW)
>    -- Qualify description of "brcm,completion-timeout-us" so that
>       it refers to PCIe transactions. (StefanW)
>    -- Remvove mention of Linux specifics in binding description. (StefanW)
>    -- s/clkreq#/CLKREQ#/g (Bjorn)
>    -- Refactor completion-timeout-us code to compare max and min to
>       value given by the property (as opposed to the computed value).
> 
> v1 -- The current driver assumes the downstream devices can
>       provide CLKREQ# for ASPM.  These commits accomodate devices
>       w/ or w/o clkreq# and also handle L1SS-capable devices.
> 
>    -- The Raspian Linux folks have already been using a PCIe RC
>       property "brcm,enable-l1ss".  These commits use the same
>       property, in a backward-compatible manner, and the implementaion
>       adds more detail and also automatically identifies devices w/o
>       a clkreq# signal, i.e. most devices plugged into an RPi CM4
>       IO board.
> 
> 
> Jim Quinlan (5):
>   dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property
>   PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream
>     device

I am not merging the first two patches since the discussion thread
is still open and I'd like to understand better what can/should be
done, sorry.

>   PCI: brcmstb: Set higher value for internal bus timeout
>   PCI: brcmstb: Assert PERST# on BCM2711
>   PCI: brcmstb: Remove stale comment

Is it OK to apply these three on their own ? Overall it would be
great to avoid mixing patches with different end goals in a single
series.

Thanks,
Lorenzo

>  .../bindings/pci/brcm,stb-pcie.yaml           |  9 ++
>  drivers/pci/controller/pcie-brcmstb.c         | 91 ++++++++++++++++---
>  2 files changed, 89 insertions(+), 11 deletions(-)
> 
> 
> base-commit: 8a28a0b6f1a1dcbf5a834600a9acfbe2ba51e5eb
> -- 
> 2.17.1
> 

Re: [PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode

[Jim Quinlan]

[-- Attachment #1: Type: text/plain, Size: 5667 bytes --]

On Mon, Aug 21, 2023 at 4:35 AM Lorenzo Pieralisi <lpieralisi@kernel.org> wrote:
>
> On Fri, Jun 23, 2023 at 10:40:53AM -0400, Jim Quinlan wrote:
> > v6 -- No code has been changed.
> >    -- Changed commit subject and comment in "#PERST" commit (Bjorn, Cyril)
> >    -- Changed sign-off and author email address for all commits.
> >       This was due to a change in Broadcom's upstreaming policy.
> >
> > v5 -- Remove DT property "brcm,completion-timeout-us" from
> >       "DT bindings" commit.  Although this error may be reported
> >       as a completion timeout, its cause was traced to an
> >       internal bus timeout which may occur even when there is
> >       no PCIe access being processed.  We set a timeout of four
> >       seconds only if we are operating in "L1SS CLKREQ#" mode.
> >    -- Correct CEM 2.0 reference provided by HW engineer,
> >       s/3.2.5.2.5/3.2.5.2.2/ (Bjorn)
> >    -- Add newline to dev_info() string (Stefan)
> >    -- Change variable rval to unsigned (Stefan)
> >    -- s/implementaion/implementation/ (Bjorn)
> >    -- s/superpowersave/powersupersave/ (Bjorn)
> >    -- Slightly modify message on "PERST#" commit.
> >    -- Rebase to torvalds master
> >
> > v4 -- New commit that asserts PERST# for 2711/RPi SOCs at PCIe RC
> >       driver probe() time.  This is done in Raspian Linux and its
> >       absence may be the cause of a failing test case.
> >    -- New commit that removes stale comment.
> >
> > v3 -- Rewrote commit msgs and comments refering panics if L1SS
> >       is enabled/disabled; the code snippet that unadvertises L1SS
> >       eliminates the panic scenario. (Bjorn)
> >    -- Add reference for "400ns of CLKREQ# assertion" blurb (Bjorn)
> >    -- Put binding names in DT commit Subject (Bjorn)
> >    -- Add a verb to a commit's subject line (Bjorn)
> >    -- s/accomodat(\w+)/accommodat$1/g (Bjorn)
> >    -- Rewrote commit msgs and comments refering panics if L1SS
> >       is enabled/disabled; the code snippet that unadvertises L1SS
> >       eliminates the panic scenario. (Bjorn)
> >
> > v2 -- Changed binding property 'brcm,completion-timeout-msec' to
> >       'brcm,completion-timeout-us'.  (StefanW for standard suffix).
> >    -- Warn when clamping timeout value, and include clamped
> >       region in message. Also add min and max in YAML. (StefanW)
> >    -- Qualify description of "brcm,completion-timeout-us" so that
> >       it refers to PCIe transactions. (StefanW)
> >    -- Remvove mention of Linux specifics in binding description. (StefanW)
> >    -- s/clkreq#/CLKREQ#/g (Bjorn)
> >    -- Refactor completion-timeout-us code to compare max and min to
> >       value given by the property (as opposed to the computed value).
> >
> > v1 -- The current driver assumes the downstream devices can
> >       provide CLKREQ# for ASPM.  These commits accomodate devices
> >       w/ or w/o clkreq# and also handle L1SS-capable devices.
> >
> >    -- The Raspian Linux folks have already been using a PCIe RC
> >       property "brcm,enable-l1ss".  These commits use the same
> >       property, in a backward-compatible manner, and the implementaion
> >       adds more detail and also automatically identifies devices w/o
> >       a clkreq# signal, i.e. most devices plugged into an RPi CM4
> >       IO board.
> >
> >
> > Jim Quinlan (5):
> >   dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property
> >   PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream
> >     device
>
> I am not merging the first two patches since the discussion thread
> is still open and I'd like to understand better what can/should be
> done, sorry.

Hello Lorenzo,

This patch-set has been stable for months, V5 was out early May and
the V6 changes
did not involve code.  I'm a little surprised that you are voicing
concern at this stage.

The previous discussions covered all aspects of these commits AFAICT.
Please  review
them and the commit messages and let me know what issues you do not understand
or any topics that were not considered.

Are you concerned about the Broadcom STB/CM community  or the RPi community?
For the former, I have direct communication w/ our customers and none of them
are even close to using upstream (they may backport my commits).  For
the latter, I have
tested these commits on the official RPi4 and CM4 IO platforms, and
Cyril has also put in
an admiral amount of testing.

Note that I have on my desk a CM4 IO board w/ a conventional PCIe
device, and it does not boot
upstream master Linux until these patches are applied.

Further, Raspian OS has already introduced the "brcm,enable-l1ss"
property but did not upstream it, and
my commits are backwards compatible with this.

>
> >   PCI: brcmstb: Set higher value for internal bus timeout
> >   PCI: brcmstb: Assert PERST# on BCM2711
> >   PCI: brcmstb: Remove stale comment
>
> Is it OK to apply these three on their own ? Overall it would be
> great to avoid mixing patches with different end goals in a single
> series.

Well, they are related for one customer who wants to use L1SS power
savings AND require
a long  period for the internal timeout.  But, yes, these commits are
fine  to apply
independently.

Regards,
Jim Quinlan
Broadcom STB

>
> Thanks,
> Lorenzo
>
> >  .../bindings/pci/brcm,stb-pcie.yaml           |  9 ++
> >  drivers/pci/controller/pcie-brcmstb.c         | 91 ++++++++++++++++---
> >  2 files changed, 89 insertions(+), 11 deletions(-)
> >
> >
> > base-commit: 8a28a0b6f1a1dcbf5a834600a9acfbe2ba51e5eb
> > --
> > 2.17.1
> >
>
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4210 bytes --]

Re: [PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode

[Lorenzo Pieralisi]

On Mon, Aug 21, 2023 at 08:15:02AM -0400, Jim Quinlan wrote:
> On Mon, Aug 21, 2023 at 4:35 AM Lorenzo Pieralisi <lpieralisi@kernel.org> wrote:
> >
> > On Fri, Jun 23, 2023 at 10:40:53AM -0400, Jim Quinlan wrote:
> > > v6 -- No code has been changed.
> > >    -- Changed commit subject and comment in "#PERST" commit (Bjorn, Cyril)
> > >    -- Changed sign-off and author email address for all commits.
> > >       This was due to a change in Broadcom's upstreaming policy.
> > >
> > > v5 -- Remove DT property "brcm,completion-timeout-us" from
> > >       "DT bindings" commit.  Although this error may be reported
> > >       as a completion timeout, its cause was traced to an
> > >       internal bus timeout which may occur even when there is
> > >       no PCIe access being processed.  We set a timeout of four
> > >       seconds only if we are operating in "L1SS CLKREQ#" mode.
> > >    -- Correct CEM 2.0 reference provided by HW engineer,
> > >       s/3.2.5.2.5/3.2.5.2.2/ (Bjorn)
> > >    -- Add newline to dev_info() string (Stefan)
> > >    -- Change variable rval to unsigned (Stefan)
> > >    -- s/implementaion/implementation/ (Bjorn)
> > >    -- s/superpowersave/powersupersave/ (Bjorn)
> > >    -- Slightly modify message on "PERST#" commit.
> > >    -- Rebase to torvalds master
> > >
> > > v4 -- New commit that asserts PERST# for 2711/RPi SOCs at PCIe RC
> > >       driver probe() time.  This is done in Raspian Linux and its
> > >       absence may be the cause of a failing test case.
> > >    -- New commit that removes stale comment.
> > >
> > > v3 -- Rewrote commit msgs and comments refering panics if L1SS
> > >       is enabled/disabled; the code snippet that unadvertises L1SS
> > >       eliminates the panic scenario. (Bjorn)
> > >    -- Add reference for "400ns of CLKREQ# assertion" blurb (Bjorn)
> > >    -- Put binding names in DT commit Subject (Bjorn)
> > >    -- Add a verb to a commit's subject line (Bjorn)
> > >    -- s/accomodat(\w+)/accommodat$1/g (Bjorn)
> > >    -- Rewrote commit msgs and comments refering panics if L1SS
> > >       is enabled/disabled; the code snippet that unadvertises L1SS
> > >       eliminates the panic scenario. (Bjorn)
> > >
> > > v2 -- Changed binding property 'brcm,completion-timeout-msec' to
> > >       'brcm,completion-timeout-us'.  (StefanW for standard suffix).
> > >    -- Warn when clamping timeout value, and include clamped
> > >       region in message. Also add min and max in YAML. (StefanW)
> > >    -- Qualify description of "brcm,completion-timeout-us" so that
> > >       it refers to PCIe transactions. (StefanW)
> > >    -- Remvove mention of Linux specifics in binding description. (StefanW)
> > >    -- s/clkreq#/CLKREQ#/g (Bjorn)
> > >    -- Refactor completion-timeout-us code to compare max and min to
> > >       value given by the property (as opposed to the computed value).
> > >
> > > v1 -- The current driver assumes the downstream devices can
> > >       provide CLKREQ# for ASPM.  These commits accomodate devices
> > >       w/ or w/o clkreq# and also handle L1SS-capable devices.
> > >
> > >    -- The Raspian Linux folks have already been using a PCIe RC
> > >       property "brcm,enable-l1ss".  These commits use the same
> > >       property, in a backward-compatible manner, and the implementaion
> > >       adds more detail and also automatically identifies devices w/o
> > >       a clkreq# signal, i.e. most devices plugged into an RPi CM4
> > >       IO board.
> > >
> > >
> > > Jim Quinlan (5):
> > >   dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property
> > >   PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream
> > >     device
> >
> > I am not merging the first two patches since the discussion thread
> > is still open and I'd like to understand better what can/should be
> > done, sorry.
> 
> Hello Lorenzo,
> 
> This patch-set has been stable for months, V5 was out early May and
> the V6 changes
> did not involve code.  I'm a little surprised that you are voicing
> concern at this stage.
> 
> The previous discussions covered all aspects of these commits AFAICT.
> Please  review
> them and the commit messages and let me know what issues you do not understand
> or any topics that were not considered.

I disagree with the reasoning behind "brcm,enable-l1ss" property usage
instead of a command line option - at least I would like to get a
comment from DT maintainers about it.

I think Bjorn made the point consistently and I also think he is right.

I would like to get Rob's opinion on this. I know he acked the DT
bindings (I have a comment on those too) but regardless, it is clearly a
property used for what is a command line configuration parameter,
no two ways about it.

Thanks,
Lorenzo

> 
> Are you concerned about the Broadcom STB/CM community  or the RPi community?
> For the former, I have direct communication w/ our customers and none of them
> are even close to using upstream (they may backport my commits).  For
> the latter, I have
> tested these commits on the official RPi4 and CM4 IO platforms, and
> Cyril has also put in
> an admiral amount of testing.
> 
> Note that I have on my desk a CM4 IO board w/ a conventional PCIe
> device, and it does not boot
> upstream master Linux until these patches are applied.
> 
> Further, Raspian OS has already introduced the "brcm,enable-l1ss"
> property but did not upstream it, and
> my commits are backwards compatible with this.
> 
> >
> > >   PCI: brcmstb: Set higher value for internal bus timeout
> > >   PCI: brcmstb: Assert PERST# on BCM2711
> > >   PCI: brcmstb: Remove stale comment
> >
> > Is it OK to apply these three on their own ? Overall it would be
> > great to avoid mixing patches with different end goals in a single
> > series.
> 
> Well, they are related for one customer who wants to use L1SS power
> savings AND require
> a long  period for the internal timeout.  But, yes, these commits are
> fine  to apply
> independently.
> 
> Regards,
> Jim Quinlan
> Broadcom STB
> 
> >
> > Thanks,
> > Lorenzo
> >
> > >  .../bindings/pci/brcm,stb-pcie.yaml           |  9 ++
> > >  drivers/pci/controller/pcie-brcmstb.c         | 91 ++++++++++++++++---
> > >  2 files changed, 89 insertions(+), 11 deletions(-)
> > >
> > >
> > > base-commit: 8a28a0b6f1a1dcbf5a834600a9acfbe2ba51e5eb
> > > --
> > > 2.17.1
> > >
> >
> >

Re: (subset) [PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode

[Lorenzo Pieralisi]

On Fri, 23 Jun 2023 10:40:53 -0400, Jim Quinlan wrote:
> v6 -- No code has been changed.
>    -- Changed commit subject and comment in "#PERST" commit (Bjorn, Cyril)
>    -- Changed sign-off and author email address for all commits.
>       This was due to a change in Broadcom's upstreaming policy.
> 
> v5 -- Remove DT property "brcm,completion-timeout-us" from
>       "DT bindings" commit.  Although this error may be reported
>       as a completion timeout, its cause was traced to an
>       internal bus timeout which may occur even when there is
>       no PCIe access being processed.  We set a timeout of four
>       seconds only if we are operating in "L1SS CLKREQ#" mode.
>    -- Correct CEM 2.0 reference provided by HW engineer,
>       s/3.2.5.2.5/3.2.5.2.2/ (Bjorn)
>    -- Add newline to dev_info() string (Stefan)
>    -- Change variable rval to unsigned (Stefan)
>    -- s/implementaion/implementation/ (Bjorn)
>    -- s/superpowersave/powersupersave/ (Bjorn)
>    -- Slightly modify message on "PERST#" commit.
>    -- Rebase to torvalds master
> 
> [...]

Applied to controller/brcmstb, thanks!

[4/5] PCI: brcmstb: Assert PERST# on BCM2711
      https://git.kernel.org/pci/pci/c/8eb8c2735306
[5/5] PCI: brcmstb: Remove stale comment
      https://git.kernel.org/pci/pci/c/6dac1507a654

Thanks,
Lorenzo