From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ACB6C3DA6F for ; Thu, 24 Aug 2023 12:03:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237786AbjHXMD0 (ORCPT ); Thu, 24 Aug 2023 08:03:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241268AbjHXMC5 (ORCPT ); Thu, 24 Aug 2023 08:02:57 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 416E41993; Thu, 24 Aug 2023 05:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692878566; x=1724414566; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=7l+45aZuDPCBqNHBG172GCHD6wE4+ZCgsf7zR7CryYw=; b=Twdgx734olgG1bPRJiIc1bk5APn/d09ORdV3f+EPmZNPI70f6qYLSWII jltp59JcNKf7KGMxytU8t+ZMU1Tr9STjVWgRoKnedqm3WawxwDRdWC/z9 AqqdU/e/m7W/POFxDt7MWXDOYWeG+/ynQ95SoVdSOLdnQW2vVSgl3L6eV IACTDdF7hqxd51dwadVC1pArKIfnRDa74xwsQHs8WsvgvJ2eivL0Xm3K5 XEk4Vu3+HTB0lQOhluNaHY7VIqW4q2hl0YMNlzCFDMhuflZWTCoZMYAki oiBt3XwtQg1+xH/y44+wmD/MZbJIqc3P9le22P1GmSijyTy7qEOYqnY3K w==; X-IronPort-AV: E=McAfee;i="6600,9927,10811"; a="371825530" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="371825530" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2023 05:02:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10811"; a="1067796099" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="1067796099" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 24 Aug 2023 05:02:33 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qZ92l-002OWW-1H; Thu, 24 Aug 2023 15:02:31 +0300 Date: Thu, 24 Aug 2023 15:02:31 +0300 From: Andy Shevchenko To: Mehdi Djait Cc: jic23@kernel.org, mazziesaccount@gmail.com, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v8 7/7] iio: accel: Add support for Kionix/ROHM KX132-1211 accelerometer Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Aug 23, 2023 at 11:16:41PM +0200, Mehdi Djait wrote: > Kionix KX132-1211 is a tri-axis 16-bit accelerometer that can support > ranges from ±2G to ±16G, digital output through I²C/SPI. > Add support for basic accelerometer features such as reading acceleration > via IIO using raw reads, triggered buffer (data-ready), or the WMI IRQ. ... > help > - Enable support for the Kionix KX022A digital tri-axis > - accelerometer connected to I2C interface. > + Enable support for the Kionix KX022A, KX132-1211 digital tri-axis > + accelerometers connected to SPI interface. I know I have given a tag, but since it most likely require a new version, this can be amended for the better maintenance as Enable support for the Kionix digital tri-axis accelerometers connected to SPI interface. Supported devices are: KX022A, KX132-1211 ... > help > - Enable support for the Kionix KX022A digital tri-axis > - accelerometer connected to I2C interface. > + Enable support for the Kionix KX022A, KX132-1211 digital tri-axis > + accelerometers connected to I2C interface. Ditto. ... > +static const struct regmap_access_table kx132_volatile_regs = { > + .yes_ranges = &kx132_volatile_ranges[0], This should be the same as .yes_ranges = kx132_volatile_ranges, > + .n_yes_ranges = ARRAY_SIZE(kx132_volatile_ranges), > +}; Ditto for the following. > +static const struct regmap_access_table kx132_precious_regs = { > + .yes_ranges = &kx132_precious_ranges[0], > + .n_yes_ranges = ARRAY_SIZE(kx132_precious_ranges), > +}; > +static const struct regmap_access_table kx132_ro_regs = { > + .no_ranges = &kx132_read_only_ranges[0], > + .n_no_ranges = ARRAY_SIZE(kx132_read_only_ranges), > +}; > +static const struct regmap_access_table kx132_wo_regs = { > + .no_ranges = &kx132_write_only_ranges[0], > + .n_no_ranges = ARRAY_SIZE(kx132_write_only_ranges), > +}; > +static const struct regmap_access_table kx132_nir_regs = { > + .yes_ranges = &kx132_noinc_read_ranges[0], > + .n_yes_ranges = ARRAY_SIZE(kx132_noinc_read_ranges), > +}; -- With Best Regards, Andy Shevchenko