devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>,
	azkali <a.ffcc7@gmail.com>, Adam Jiang <chaoj@nvidia.com>,
	CTCaer <ctcaer@gmail.com>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Derek Kiernan <derek.kiernan@amd.com>,
	Dragan Cvetic <dragan.cvetic@amd.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] misc: bm92txx: Add driver for the ROHM BM92Txx
Date: Mon, 28 Aug 2023 17:06:05 +0200	[thread overview]
Message-ID: <ZOy33RB8aj3455ZQ@desktop> (raw)
In-Reply-To: <f79087c0-cc44-4fb6-fa2e-b43db5dfd6d4@linaro.org>

Hi,

On Thu, Aug 24, 2023 at 06:28:07PM +0200, Krzysztof Kozlowski wrote:
> On 24/08/2023 17:30, Emmanuel Gil Peyrot wrote:
> > From: azkali <a.ffcc7@gmail.com>
> > 
> > This is used as the USB-C Power Delivery controller of the Nintendo
> > Switch.
> > 
> > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
> > Signed-off-by: azkali <a.ffcc7@gmail.com>
> > Signed-off-by: Adam Jiang <chaoj@nvidia.com>
> > Signed-off-by: CTCaer <ctcaer@gmail.com>
> 
> These do not look like real identities. In this and previous patchset
> your author emails bounces, so I propose to drop all stale addresses and
> all anonymous entries.

I and the authors find that policy inacceptable, our work should be
credited and our copyright should hold despite our choice of name.

Given the amount of issues in this patchset I will drop it for now, we
will come back with a better patchset for this particular device in a
while.

> 
> Best regards,
> Krzysztof
> 

Thanks for the review, I already tried to clean it up but it was clearly
not as good as the expectations here.

-- 
Link Mauve

  reply	other threads:[~2023-08-28 15:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24 15:30 [PATCH 0/2] Add a driver for the ROHM BM92Txx USB-C Power Delivery controller Emmanuel Gil Peyrot
2023-08-24 15:30 ` [PATCH 1/2] dt-bindings: misc: rohm,bm92txx: Add BM92Txx support Emmanuel Gil Peyrot
2023-08-24 16:16   ` Krzysztof Kozlowski
2023-08-24 15:30 ` [PATCH 2/2] misc: bm92txx: Add driver for the ROHM BM92Txx Emmanuel Gil Peyrot
2023-08-24 15:40   ` Greg Kroah-Hartman
2023-08-24 16:26   ` Krzysztof Kozlowski
2023-08-24 16:28   ` Krzysztof Kozlowski
2023-08-28 15:06     ` Emmanuel Gil Peyrot [this message]
2023-08-28 17:05       ` Krzysztof Kozlowski
2023-08-28 17:08         ` Krzysztof Kozlowski
2023-08-25 18:24   ` kernel test robot
2023-08-25 18:45   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZOy33RB8aj3455ZQ@desktop \
    --to=linkmauve@linkmauve.fr \
    --cc=a.ffcc7@gmail.com \
    --cc=arnd@arndb.de \
    --cc=chaoj@nvidia.com \
    --cc=conor+dt@kernel.org \
    --cc=ctcaer@gmail.com \
    --cc=derek.kiernan@amd.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dragan.cvetic@amd.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).