From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4AA5C83F12 for ; Mon, 28 Aug 2023 15:06:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231231AbjH1PGT (ORCPT ); Mon, 28 Aug 2023 11:06:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbjH1PGN (ORCPT ); Mon, 28 Aug 2023 11:06:13 -0400 Received: from luna.linkmauve.fr (82-65-109-163.subs.proxad.net [82.65.109.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF31AF0; Mon, 28 Aug 2023 08:06:07 -0700 (PDT) Received: by luna.linkmauve.fr (Postfix, from userid 1000) id 00F208DA8B8; Mon, 28 Aug 2023 17:06:05 +0200 (CEST) Date: Mon, 28 Aug 2023 17:06:05 +0200 From: Emmanuel Gil Peyrot To: Krzysztof Kozlowski Cc: Emmanuel Gil Peyrot , azkali , Adam Jiang , CTCaer , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] misc: bm92txx: Add driver for the ROHM BM92Txx Message-ID: References: <20230824153059.212244-1-linkmauve@linkmauve.fr> <20230824153059.212244-3-linkmauve@linkmauve.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Jabber-ID: linkmauve@linkmauve.fr Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Thu, Aug 24, 2023 at 06:28:07PM +0200, Krzysztof Kozlowski wrote: > On 24/08/2023 17:30, Emmanuel Gil Peyrot wrote: > > From: azkali > > > > This is used as the USB-C Power Delivery controller of the Nintendo > > Switch. > > > > Signed-off-by: Emmanuel Gil Peyrot > > Signed-off-by: azkali > > Signed-off-by: Adam Jiang > > Signed-off-by: CTCaer > > These do not look like real identities. In this and previous patchset > your author emails bounces, so I propose to drop all stale addresses and > all anonymous entries. I and the authors find that policy inacceptable, our work should be credited and our copyright should hold despite our choice of name. Given the amount of issues in this patchset I will drop it for now, we will come back with a better patchset for this particular device in a while. > > Best regards, > Krzysztof > Thanks for the review, I already tried to clean it up but it was clearly not as good as the expectations here. -- Link Mauve