* Re: [PATCH v1] arm64: dts: qcom: msm8916: Fix iommu local address range
2023-09-15 14:33 [PATCH v1] arm64: dts: qcom: msm8916: Fix iommu local address range Gaurav Kohli
@ 2023-09-15 14:36 ` Konrad Dybcio
2023-09-15 14:42 ` Stephan Gerhold
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-09-15 14:36 UTC (permalink / raw)
To: Gaurav Kohli, agross, andersson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree, kernel
On 15.09.2023 16:33, Gaurav Kohli wrote:
> Fix the apps iommu local address space range as per data sheet.
>
> Fixes: 6a6729f38436 ("arm64: dts: qcom: msm8916: Add IOMMU support")
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
> ---
> Changes since v0:
> -Update Fixes tag.
Versions start from 1.
When resending new revisions, it's expected you provide
a link to the previous submission.
Other than that:
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 33fb65d73104..3c934363368c 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1813,7 +1813,7 @@
> #size-cells = <1>;
> #iommu-cells = <1>;
> compatible = "qcom,msm8916-iommu", "qcom,msm-iommu-v1";
> - ranges = <0 0x01e20000 0x40000>;
> + ranges = <0 0x01e20000 0x20000>;
> reg = <0x01ef0000 0x3000>;
> clocks = <&gcc GCC_SMMU_CFG_CLK>,
> <&gcc GCC_APSS_TCU_CLK>;
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1] arm64: dts: qcom: msm8916: Fix iommu local address range
2023-09-15 14:33 [PATCH v1] arm64: dts: qcom: msm8916: Fix iommu local address range Gaurav Kohli
2023-09-15 14:36 ` Konrad Dybcio
@ 2023-09-15 14:42 ` Stephan Gerhold
2023-09-15 15:03 ` Bryan O'Donoghue
2023-09-15 14:48 ` Stephan Gerhold
2023-09-19 23:07 ` Bjorn Andersson
3 siblings, 1 reply; 7+ messages in thread
From: Stephan Gerhold @ 2023-09-15 14:42 UTC (permalink / raw)
To: Gaurav Kohli
Cc: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
linux-arm-msm, devicetree, kernel
On Fri, Sep 15, 2023 at 08:03:04PM +0530, Gaurav Kohli wrote:
> Fix the apps iommu local address space range as per data sheet.
>
> Fixes: 6a6729f38436 ("arm64: dts: qcom: msm8916: Add IOMMU support")
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
Aside from the minor things Konrad mentioned (v1 -> v2) FWIW:
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
Although I can kind of understand that starting to count at 0 often
feels more intuitive, especially for Linux kernel things. :-)
> ---
> Changes since v0:
> -Update Fixes tag.
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 33fb65d73104..3c934363368c 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1813,7 +1813,7 @@
> #size-cells = <1>;
> #iommu-cells = <1>;
> compatible = "qcom,msm8916-iommu", "qcom,msm-iommu-v1";
> - ranges = <0 0x01e20000 0x40000>;
> + ranges = <0 0x01e20000 0x20000>;
> reg = <0x01ef0000 0x3000>;
> clocks = <&gcc GCC_SMMU_CFG_CLK>,
> <&gcc GCC_APSS_TCU_CLK>;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1] arm64: dts: qcom: msm8916: Fix iommu local address range
2023-09-15 14:42 ` Stephan Gerhold
@ 2023-09-15 15:03 ` Bryan O'Donoghue
0 siblings, 0 replies; 7+ messages in thread
From: Bryan O'Donoghue @ 2023-09-15 15:03 UTC (permalink / raw)
To: Stephan Gerhold, Gaurav Kohli
Cc: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
linux-arm-msm, devicetree, kernel
On 15/09/2023 15:42, Stephan Gerhold wrote:
> On Fri, Sep 15, 2023 at 08:03:04PM +0530, Gaurav Kohli wrote:
>> Fix the apps iommu local address space range as per data sheet.
>>
>> Fixes: 6a6729f38436 ("arm64: dts: qcom: msm8916: Add IOMMU support")
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
>
> Aside from the minor things Konrad mentioned (v1 -> v2) FWIW:
>
> Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
>
> Although I can kind of understand that starting to count at 0 often
> feels more intuitive, especially for Linux kernel things. :-)
Just put
OPTION BASE 0
at the start of your cover letter ;)
---
bod
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] arm64: dts: qcom: msm8916: Fix iommu local address range
2023-09-15 14:33 [PATCH v1] arm64: dts: qcom: msm8916: Fix iommu local address range Gaurav Kohli
2023-09-15 14:36 ` Konrad Dybcio
2023-09-15 14:42 ` Stephan Gerhold
@ 2023-09-15 14:48 ` Stephan Gerhold
2023-09-15 15:05 ` Gaurav Kohli
2023-09-19 23:07 ` Bjorn Andersson
3 siblings, 1 reply; 7+ messages in thread
From: Stephan Gerhold @ 2023-09-15 14:48 UTC (permalink / raw)
To: Gaurav Kohli
Cc: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
linux-arm-msm, devicetree, kernel
On Fri, Sep 15, 2023 at 08:03:04PM +0530, Gaurav Kohli wrote:
> Fix the apps iommu local address space range as per data sheet.
>
> Fixes: 6a6729f38436 ("arm64: dts: qcom: msm8916: Add IOMMU support")
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
> ---
> Changes since v0:
> -Update Fixes tag.
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 33fb65d73104..3c934363368c 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1813,7 +1813,7 @@
> #size-cells = <1>;
> #iommu-cells = <1>;
> compatible = "qcom,msm8916-iommu", "qcom,msm-iommu-v1";
> - ranges = <0 0x01e20000 0x40000>;
> + ranges = <0 0x01e20000 0x20000>;
Please also submit another patch to fix this in msm8939.dtsi. It has the
same mistake.
Thanks,
Stephan
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1] arm64: dts: qcom: msm8916: Fix iommu local address range
2023-09-15 14:48 ` Stephan Gerhold
@ 2023-09-15 15:05 ` Gaurav Kohli
0 siblings, 0 replies; 7+ messages in thread
From: Gaurav Kohli @ 2023-09-15 15:05 UTC (permalink / raw)
To: Stephan Gerhold
Cc: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
linux-arm-msm, devicetree, kernel
On 9/15/2023 8:18 PM, Stephan Gerhold wrote:
> On Fri, Sep 15, 2023 at 08:03:04PM +0530, Gaurav Kohli wrote:
>> Fix the apps iommu local address space range as per data sheet.
>>
>> Fixes: 6a6729f38436 ("arm64: dts: qcom: msm8916: Add IOMMU support")
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
>> ---
>> Changes since v0:
>> -Update Fixes tag.
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
>> index 33fb65d73104..3c934363368c 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
>> @@ -1813,7 +1813,7 @@
>> #size-cells = <1>;
>> #iommu-cells = <1>;
>> compatible = "qcom,msm8916-iommu", "qcom,msm-iommu-v1";
>> - ranges = <0 0x01e20000 0x40000>;
>> + ranges = <0 0x01e20000 0x20000>;
>
> Please also submit another patch to fix this in msm8939.dtsi. It has the
> same mistake.
thanks a lot for review, yes i will send it for other soc also.
>
> Thanks,
> Stephan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] arm64: dts: qcom: msm8916: Fix iommu local address range
2023-09-15 14:33 [PATCH v1] arm64: dts: qcom: msm8916: Fix iommu local address range Gaurav Kohli
` (2 preceding siblings ...)
2023-09-15 14:48 ` Stephan Gerhold
@ 2023-09-19 23:07 ` Bjorn Andersson
3 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2023-09-19 23:07 UTC (permalink / raw)
To: agross, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
Gaurav Kohli
Cc: linux-arm-msm, devicetree, kernel
On Fri, 15 Sep 2023 20:03:04 +0530, Gaurav Kohli wrote:
> Fix the apps iommu local address space range as per data sheet.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: msm8916: Fix iommu local address range
commit: 2de8ee9f58fa51f707c71f8fbcd8470ab0078102
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread