From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: netdev@vger.kernel.org, lorenzo.bianconi@redhat.com,
nbd@nbd.name, john@phrozen.org, sean.wang@mediatek.com,
Mark-MC.Lee@mediatek.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
daniel@makrotopia.org, linux-mediatek@lists.infradead.org,
sujuan.chen@mediatek.com, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 10/15] net: ethernet: mtk_wed: introduce WED support for MT7988
Date: Fri, 15 Sep 2023 18:28:48 +0200 [thread overview]
Message-ID: <ZQSGQH5n78e0wpz7@lore-desk> (raw)
In-Reply-To: <20230915145548.GA3704791-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
> On Thu, Sep 14, 2023 at 04:38:15PM +0200, Lorenzo Bianconi wrote:
> > From: Sujuan Chen <sujuan.chen@mediatek.com>
> >
> > Similar to MT7986 and MT7622, enable Wireless Ethernet Ditpatcher for
[...]
> > - ring_size = dev->wlan.nbuf & ~(MTK_WED_BUF_PER_PAGE - 1);
> > - n_pages = ring_size / MTK_WED_BUF_PER_PAGE;
> > + if (!mtk_wed_is_v3_or_greater(dev->hw)) {
> > + dev->tx_buf_ring.desc_size = sizeof(struct mtk_wdma_desc);
>
> Instead of checking the version or using of_device_is_compatible() in
> other places why don't you define driver match data for all this static
> data.
ack, I will look into it.
Regards,
Lorenzo
>
> Rob
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-09-15 16:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 14:38 [PATCH net-next 00/15] Add WED support for MT7988 chipset Lorenzo Bianconi
2023-09-14 14:38 ` [PATCH net-next 01/15] dt-bindings: soc: mediatek: mt7986-wo-ccif: add binding for MT7988 SoC Lorenzo Bianconi
2023-09-15 14:56 ` Rob Herring
2023-09-14 14:38 ` [PATCH net-next 02/15] dt-bindings: arm: mediatek: mt7622-wed: add WED " Lorenzo Bianconi
2023-09-15 14:57 ` Rob Herring
2023-09-14 14:38 ` [PATCH net-next 03/15] net: ethernet: mtk_wed: introduce versioning utility routines Lorenzo Bianconi
2023-09-14 14:38 ` [PATCH net-next 04/15] net: ethernet: mtk_wed: introduce mtk_wed_wdma_get_desc_size utility routine Lorenzo Bianconi
2023-09-14 14:38 ` [PATCH net-next 05/15] net: ethernet: mtk_wed: do not configure rx offload if not supported Lorenzo Bianconi
2023-09-14 14:38 ` [PATCH net-next 06/15] net: ethernet: mtk_wed: rename mtk_rxbm_desc in mtk_wed_bm_desc Lorenzo Bianconi
2023-09-14 14:38 ` [PATCH net-next 07/15] net: ethernet: mtk_wed: introduce mtk_wed_buf structure Lorenzo Bianconi
2023-09-14 14:38 ` [PATCH net-next 08/15] net: ethernet: mtk_wed: move mem_region array out of mtk_wed_mcu_load_firmware Lorenzo Bianconi
2023-09-14 14:38 ` [PATCH net-next 09/15] net: ethernet: mtk_wed: make memory region optional Lorenzo Bianconi
2023-09-14 14:38 ` [PATCH net-next 10/15] net: ethernet: mtk_wed: introduce WED support for MT7988 Lorenzo Bianconi
2023-09-15 14:55 ` Rob Herring
2023-09-15 16:28 ` Lorenzo Bianconi [this message]
2023-09-14 14:38 ` [PATCH net-next 11/15] net: ethernet: mtk_wed: refactor mtk_wed_check_wfdma_rx_fill routine Lorenzo Bianconi
2023-09-14 14:38 ` [PATCH net-next 12/15] net: ethernet: mtk_wed: introduce partial AMSDU offload support for MT7988 Lorenzo Bianconi
2023-09-14 14:38 ` [PATCH net-next 13/15] net: ethernet: mtk_wed: introduce hw_rro " Lorenzo Bianconi
2023-09-17 8:47 ` Simon Horman
2023-09-18 7:54 ` Lorenzo Bianconi
2023-09-14 14:38 ` [PATCH net-next 14/15] net: ethernet: mtk_wed: debugfs: move wed_v2 specific regs out of regs array Lorenzo Bianconi
2023-09-14 14:38 ` [PATCH net-next 15/15] net: ethernet: mtk_wed: debugfs: add WED 3.0 debugfs entries Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQSGQH5n78e0wpz7@lore-desk \
--to=lorenzo@kernel.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=john@phrozen.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=sujuan.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).